Code Review for open

Prepared by: vyom tewari (vytewari) on Thu May 10 17:52:15 IST 2018
Workspace:/home/vytewari/source/jdk/open
Summary of changes: 813 lines changed: 769 ins; 13 del; 31 mod; 6433 unchg
Patch of changes: open.patch
Bug id: JDK-8194298 : Add support for per Socket configuration of TCP keepalive
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/lib/Lib-jdk.net.gmk

1 line changed: 0 ins; 0 del; 1 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/net/ext/ExtendedSocketOptions.java

16 lines changed: 15 ins; 0 del; 1 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/AsynchronousServerSocketChannelImpl.java

3 lines changed: 2 ins; 0 del; 1 mod; 262 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/AsynchronousSocketChannelImpl.java

5 lines changed: 0 ins; 2 del; 3 mod; 603 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 1334 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/ServerSocketChannelImpl.java

2 lines changed: 2 ins; 0 del; 0 mod; 553 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 1116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/classes/java/net/PlainDatagramSocketImpl.java

10 lines changed: 0 ins; 8 del; 2 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/classes/java/net/PlainSocketImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.net/linux/classes/jdk/net/LinuxSocketOptions.java

43 lines changed: 39 ins; 0 del; 4 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.net/linux/native/libextnet/LinuxSocketOptions.c

115 lines changed: 114 ins; 0 del; 1 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.net/share/classes/jdk/net/ExtendedSocketOptions.java

154 lines changed: 149 ins; 0 del; 5 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.net/share/classes/jdk/net/Sockets.java

26 lines changed: 25 ins; 0 del; 1 mod; 352 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nio/channels/AsynchronousServerSocketChannel/Basic.java

17 lines changed: 16 ins; 0 del; 1 mod; 181 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nio/channels/AsynchronousSocketChannel/Basic.java

25 lines changed: 24 ins; 1 del; 0 mod; 923 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nio/channels/ServerSocketChannel/SocketOptionTests.java

19 lines changed: 17 ins; 1 del; 1 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/nio/channels/SocketChannel/SocketOptionTests.java

27 lines changed: 22 ins; 1 del; 4 mod; 136 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.net/macosx/classes/jdk/net/UnixSocketOptions.java

85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.net/macosx/native/libextnet/UnixSocketOptions.c

146 lines changed: 146 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/net/SocketOption/TcpKeepAliveTest.java

113 lines changed: 113 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/vytewari/webrev-ksh/webrev.ksh (vers 25.16-hg+openjdk.java.net).