< prev index next >
src/jdk.dev/share/classes/com/sun/tools/hat/internal/model/JavaValueArray.java
Print this page
rev 10793 : 8055723: Replace concat String to append in StringBuilder parameters
*** 344,370 ****
return valueString(true);
}
public String valueString(boolean bigLimit) {
// Char arrays deserve special treatment
! StringBuffer result;
byte[] value = getValue();
int max = value.length;
byte elementSignature = getElementType();
if (elementSignature == 'C') {
! result = new StringBuffer();
for (int i = 0; i < value.length; ) {
char val = charAt(i, value);
result.append(val);
i += 2;
}
} else {
int limit = 8;
if (bigLimit) {
limit = 1000;
}
! result = new StringBuffer("{");
int num = 0;
for (int i = 0; i < value.length; ) {
if (num > 0) {
result.append(", ");
}
--- 344,370 ----
return valueString(true);
}
public String valueString(boolean bigLimit) {
// Char arrays deserve special treatment
! StringBuilder result;
byte[] value = getValue();
int max = value.length;
byte elementSignature = getElementType();
if (elementSignature == 'C') {
! result = new StringBuilder();
for (int i = 0; i < value.length; ) {
char val = charAt(i, value);
result.append(val);
i += 2;
}
} else {
int limit = 8;
if (bigLimit) {
limit = 1000;
}
! result = new StringBuilder("{");
int num = 0;
for (int i = 0; i < value.length; ) {
if (num > 0) {
result.append(", ");
}
*** 384,433 ****
i++;
break;
}
case 'B': {
int val = 0xFF & byteAt(i, value);
! result.append("0x" + Integer.toString(val, 16));
i++;
break;
}
case 'S': {
short val = shortAt(i, value);
i += 2;
! result.append("" + val);
break;
}
case 'I': {
int val = intAt(i, value);
i += 4;
! result.append("" + val);
break;
}
case 'J': { // long
long val = longAt(i, value);
! result.append("" + val);
i += 8;
break;
}
case 'F': {
float val = floatAt(i, value);
! result.append("" + val);
i += 4;
break;
}
case 'D': { // double
double val = doubleAt(i, value);
! result.append("" + val);
i += 8;
break;
}
default: {
throw new RuntimeException("unknown primitive type?");
}
}
}
! result.append("}");
}
return result.toString();
}
}
--- 384,433 ----
i++;
break;
}
case 'B': {
int val = 0xFF & byteAt(i, value);
! result.append("0x").append(Integer.toString(val, 16));
i++;
break;
}
case 'S': {
short val = shortAt(i, value);
i += 2;
! result.append(val);
break;
}
case 'I': {
int val = intAt(i, value);
i += 4;
! result.append(val);
break;
}
case 'J': { // long
long val = longAt(i, value);
! result.append(val);
i += 8;
break;
}
case 'F': {
float val = floatAt(i, value);
! result.append(val);
i += 4;
break;
}
case 'D': { // double
double val = doubleAt(i, value);
! result.append(val);
i += 8;
break;
}
default: {
throw new RuntimeException("unknown primitive type?");
}
}
}
! result.append('}');
}
return result.toString();
}
}
< prev index next >