# HG changeset patch
# User weijun
# Date 1429934975 -28800
# Sat Apr 25 12:09:35 2015 +0800
# Node ID 858843d51c957c843a38ed498e1d00c047bc9227
# Parent b291aed5dd5aaff9d11a0fe3545e3b967e881de4
8078439: Kerberos auth fails if client proposes MS krb5 OID
diff --git a/src/java.security.jgss/share/classes/sun/security/jgss/GSSUtil.java b/src/java.security.jgss/share/classes/sun/security/jgss/GSSUtil.java
--- a/src/java.security.jgss/share/classes/sun/security/jgss/GSSUtil.java
+++ b/src/java.security.jgss/share/classes/sun/security/jgss/GSSUtil.java
@@ -59,6 +59,8 @@
GSSUtil.createOid("1.2.840.113554.1.2.2");
public static final Oid GSS_KRB5_MECH_OID2 =
GSSUtil.createOid("1.3.5.1.5.2");
+ public static final Oid GSS_KRB5_MECH_OID_MS =
+ GSSUtil.createOid("1.2.840.48018.1.2.2");
public static final Oid GSS_SPNEGO_MECH_OID =
GSSUtil.createOid("1.3.6.1.5.5.2");
@@ -101,7 +103,8 @@
public static boolean isKerberosMech(Oid oid) {
return (GSS_KRB5_MECH_OID.equals(oid) ||
- GSS_KRB5_MECH_OID2.equals(oid));
+ GSS_KRB5_MECH_OID2.equals(oid) ||
+ GSS_KRB5_MECH_OID_MS.equals(oid));
}
diff --git a/src/java.security.jgss/share/classes/sun/security/jgss/spnego/SpNegoContext.java b/src/java.security.jgss/share/classes/sun/security/jgss/spnego/SpNegoContext.java
--- a/src/java.security.jgss/share/classes/sun/security/jgss/spnego/SpNegoContext.java
+++ b/src/java.security.jgss/share/classes/sun/security/jgss/spnego/SpNegoContext.java
@@ -538,7 +538,9 @@
// get the token for mechanism
byte[] accept_token;
- if (mechList[0].equals(mech_wanted)) {
+ if (mechList[0].equals(mech_wanted) ||
+ (GSSUtil.isKerberosMech(mechList[0]) &&
+ GSSUtil.isKerberosMech(mech_wanted))) {
// get the mechanism token
byte[] mechToken = initToken.getMechToken();
if (mechToken == null) {
diff --git a/test/sun/security/krb5/auto/MSOID.java b/test/sun/security/krb5/auto/MSOID.java
new file mode 100644
--- /dev/null
+++ b/test/sun/security/krb5/auto/MSOID.java
@@ -0,0 +1,78 @@
+/*
+ * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+ * or visit www.oracle.com if you need additional information or have any
+ * questions.
+ */
+
+/*
+ * @test
+ * @bug 8078439
+ * @summary Kerberos auth fails if client proposes MS krb5 OID
+ * @compile -XDignore.symbol.file MSOID.java
+ * @run main/othervm MSOID
+ */
+
+import sun.security.jgss.GSSUtil;
+
+// The basic krb5 test skeleton you can copy from
+public class MSOID {
+
+ public static void main(String[] args) throws Exception {
+
+ new OneKDC(null).writeJAASConf();
+
+ Context c, s;
+ c = Context.fromJAAS("client");
+ s = Context.fromJAAS("server");
+
+ c.startAsClient(OneKDC.SERVER, GSSUtil.GSS_SPNEGO_MECH_OID);
+ s.startAsServer(GSSUtil.GSS_SPNEGO_MECH_OID);
+
+ byte[] t = new byte[0];
+ boolean first = true;
+ while (true) {
+ if (t != null || !c.x().isEstablished()) t = c.take(t);
+ if (first) {
+ // Tweak the packet to append an extra OID
+ int len = t.length;
+ byte[] nt = new byte[len + 11];
+ System.arraycopy(t, 0, nt, 0, 0x23);
+ System.arraycopy(t, 0x18, nt, 0x23, 11); // dup the OID
+ System.arraycopy(t, 0x23, nt, 0x2e, len-0x23);
+ nt[0x1d] = (byte)0x82; // change the 1st to MS OID
+ // Length bytes to be tweaked
+ for (int pos: new int[] {3, 0xf, 0x13, 0x15, 0x17}) {
+ nt[pos] = (byte)(nt[pos] + 11);
+ }
+ t = nt;
+ new sun.misc.HexDumpEncoder().encodeBuffer(t, System.out);
+ }
+ if (t != null || !s.x().isEstablished()) t = s.take(t);
+ if (c.x().isEstablished() && s.x().isEstablished()) break;
+ first = false;
+ }
+
+ Context.transmit("i say high --", c, s);
+ Context.transmit(" you say low", s, c);
+
+ s.dispose();
+ c.dispose();
+ }
+}