Code Review for hotspot

Prepared by:denghui.ddh@alibaba-inc.com on Fri Sep 27 13:26:02 CST 2019
Workspace:/ssd1/home/ddh/dev/jdk8u-jfr-incubator/hotspot
Compare against version:8a0aca5caca0
Summary of changes: 31 lines changed: 18 ins; 7 del; 6 mod; 2470 unchg
Patch of changes: hotspot.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/dcmd/jfrDcmds.cpp

rev 9060 : 8216064: -XX:StartFlightRecording:settings= doesn't work properly
Reviewed-by: mgronlun
7 lines changed: 6 ins; 0 del; 1 mod; 662 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/jni/jfrJavaCall.cpp

rev 9060 : 8216064: -XX:StartFlightRecording:settings= doesn't work properly
Reviewed-by: mgronlun
3 lines changed: 0 ins; 0 del; 3 mod; 377 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/jni/jfrJavaSupport.cpp

rev 9060 : 8216064: -XX:StartFlightRecording:settings= doesn't work properly
Reviewed-by: mgronlun
1 line changed: 0 ins; 0 del; 1 mod; 582 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/recorder/jfrRecorder.cpp

rev 9061 : 8227011: Starting a JFR recording in response to JVMTI VMInit and / or Java agent premain corrupts memory
Reviewed-by: egahlin, rwestberg
10 lines changed: 7 ins; 3 del; 0 mod; 398 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/recorder/jfrRecorder.hpp

rev 9061 : 8227011: Starting a JFR recording in response to JVMTI VMInit and / or Java agent premain corrupts memory
Reviewed-by: egahlin, rwestberg
1 line changed: 1 ins; 0 del; 0 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/support/jfrFlush.cpp

rev 9059 : 8224172: assert(jfr_is_event_enabled(id)) failed: invariant
Reviewed-by: dcubed, dholmes
1 line changed: 0 ins; 1 del; 0 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/writers/jfrJavaEventWriter.cpp

rev 9061 : 8227011: Starting a JFR recording in response to JVMTI VMInit and / or Java agent premain corrupts memory
Reviewed-by: egahlin, rwestberg
3 lines changed: 1 ins; 1 del; 1 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/jfr/writers/jfrJavaEventWriter.hpp

rev 9061 : 8227011: Starting a JFR recording in response to JVMTI VMInit and / or Java agent premain corrupts memory
Reviewed-by: egahlin, rwestberg
5 lines changed: 3 ins; 2 del; 0 mod; 48 unchg

This code review page was prepared using /home/denghui.ddh/webrev.ksh (vers 25.18-hg+openjdk.java.net).