Code Review for open

Prepared by:xuelei on Fri Jun 8 17:03:01 UTC 2018
Workspace:/export/home/xufan/workspaces/jdk-sandbox/open
Compare against: ssh://hg.openjdk.java.net/jdk/sandbox
Compare against version:8ff60b603991
Branch:JDK-8145252-TLS13-branch
Summary of changes: 1212 lines changed: 390 ins; 467 del; 355 mod; 31841 unchg
Patch of changes: open.patch
Bug id: JDK-8145252 : Transport Layer Security (TLS) 1.3
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/com/sun/crypto/provider/TlsMasterSecretGenerator.java

1 line changed: 0 ins; 0 del; 1 mod; 189 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java

39 lines changed: 5 ins; 30 del; 4 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java

19 lines changed: 1 ins; 10 del; 8 mod; 768 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/Alert.java

2 lines changed: 1 ins; 0 del; 1 mod; 268 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/AlpnExtension.java

4 lines changed: 0 ins; 0 del; 4 mod; 504 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/Authenticator.java

3 lines changed: 0 ins; 0 del; 3 mod; 640 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/CertSignAlgsExtension.java

6 lines changed: 0 ins; 0 del; 6 mod; 342 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/CertStatusExtension.java

10 lines changed: 4 ins; 0 del; 6 mod; 1209 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/ChangeCipherSpec.java

4 lines changed: 0 ins; 0 del; 4 mod; 234 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/CipherSuite.java

68 lines changed: 10 ins; 53 del; 5 mod; 1108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/ClientHandshakeContext.java

2 lines changed: 0 ins; 0 del; 2 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/ClientHello.java

32 lines changed: 18 ins; 3 del; 11 mod; 1368 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/ClientKeyExchange.java

2 lines changed: 0 ins; 0 del; 2 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/CookieExtension.java

5 lines changed: 0 ins; 0 del; 5 mod; 313 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/DTLSInputRecord.java

12 lines changed: 6 ins; 0 del; 6 mod; 1563 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/DTLSOutputRecord.java

1 line changed: 0 ins; 0 del; 1 mod; 586 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/ECPointFormatsExtension.java

4 lines changed: 0 ins; 0 del; 4 mod; 298 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/ExtendedMasterSecretExtension.java

3 lines changed: 0 ins; 0 del; 3 mod; 388 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/Finished.java

1 line changed: 0 ins; 0 del; 1 mod; 1077 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/HKDF.java

1 line changed: 0 ins; 0 del; 1 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/HandshakeConsumer.java

1 line changed: 0 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/HandshakeContext.java

2 lines changed: 0 ins; 2 del; 0 mod; 571 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/HelloCookieManager.java

108 lines changed: 33 ins; 39 del; 36 mod; 271 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/InputRecord.java

11 lines changed: 4 ins; 4 del; 3 mod; 381 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/JsseJce.java

4 lines changed: 0 ins; 4 del; 0 mod; 396 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/KeyShareExtension.java

4 lines changed: 0 ins; 0 del; 4 mod; 950 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/KeyUpdate.java

5 lines changed: 0 ins; 0 del; 5 mod; 318 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/MaxFragExtension.java

8 lines changed: 0 ins; 0 del; 8 mod; 612 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/NewSessionTicket.java

92 lines changed: 53 ins; 14 del; 25 mod; 314 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/OutputRecord.java

5 lines changed: 0 ins; 2 del; 3 mod; 530 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/PreSharedKeyExtension.java

50 lines changed: 43 ins; 2 del; 5 mod; 748 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/PskKeyExchangeModesExtension.java

236 lines changed: 176 ins; 16 del; 44 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/RSAClientKeyExchange.java

5 lines changed: 0 ins; 3 del; 2 mod; 317 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/RandomCookie.java

2 lines changed: 0 ins; 0 del; 2 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/Record.java

16 lines changed: 0 ins; 0 del; 16 mod; 180 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/RenegoInfoExtension.java

3 lines changed: 0 ins; 0 del; 3 mod; 555 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java

20 lines changed: 20 ins; 0 del; 0 mod; 413 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SSLContextImpl.java

9 lines changed: 0 ins; 1 del; 8 mod; 1862 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SSLEngineInputRecord.java

14 lines changed: 3 ins; 5 del; 6 mod; 401 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SSLEngineOutputRecord.java

1 line changed: 0 ins; 0 del; 1 mod; 556 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SSLExtension.java

52 lines changed: 5 ins; 7 del; 40 mod; 640 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SSLExtensions.java

5 lines changed: 0 ins; 3 del; 2 mod; 360 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SSLHandshake.java

2 lines changed: 0 ins; 0 del; 2 mod; 560 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java

11 lines changed: 0 ins; 2 del; 9 mod; 1118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SSLSocketInputRecord.java

18 lines changed: 7 ins; 5 del; 6 mod; 448 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SSLSocketOutputRecord.java

1 line changed: 0 ins; 0 del; 1 mod; 371 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/ServerHello.java

3 lines changed: 0 ins; 0 del; 3 mod; 1452 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/ServerKeyExchange.java

1 line changed: 0 ins; 0 del; 1 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/ServerNameExtension.java

6 lines changed: 0 ins; 0 del; 6 mod; 580 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SignatureAlgorithmsExtension.java

9 lines changed: 0 ins; 0 del; 9 mod; 546 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SupportedGroupsExtension.java

4 lines changed: 0 ins; 0 del; 4 mod; 1033 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SupportedVersionsExtension.java

6 lines changed: 0 ins; 0 del; 6 mod; 505 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/util/HostnameChecker.java

23 lines changed: 0 ins; 23 del; 0 mod; 447 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.naming/share/classes/com/sun/jndi/ldap/ext/StartTlsResponseImpl.java

21 lines changed: 1 ins; 12 del; 8 mod; 450 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java

1 line changed: 0 ins; 0 del; 1 mod; 1256 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.jgss/share/classes/sun/security/jgss/GSSCaller.java

3 lines changed: 0 ins; 2 del; 1 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.jgss/share/classes/sun/security/jgss/LoginConfigImpl.java

15 lines changed: 0 ins; 13 del; 2 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.security.jgss/share/classes/sun/security/krb5/EncryptedData.java

4 lines changed: 0 ins; 1 del; 3 mod; 382 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/net/httpclient/http2/TLSConnection.java

1 line changed: 0 ins; 0 del; 1 mod; 255 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/sun/security/krb5/auto/unbound.ssl.jaas.conf

40 lines changed: 0 ins; 40 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/sun/security/krb5/auto/unbound.ssl.policy

27 lines changed: 0 ins; 27 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/lib/jdk/test/lib/RSAUtil.java

144 lines changed: 0 ins; 144 del; 0 mod; 0 unchg

This code review page was prepared using /home/xufan/xuelei/toolkits/webrev.ksh (vers 25.16-hg+openjdk.java.net).