Code Review for zgc

Prepared by:ysuenaga ysuenaga on Sat Jan 13 12:12:33 JST 2018
Workspace:/home/ysuenaga/OpenJDK/zgc
Compare against: http://hg.openjdk.java.net/zgc/zgc/
Compare against version:48256
Branch:sa
Summary of changes: 1319 lines changed: 1310 ins; 0 del; 9 mod; 4973 unchg
Patch of changes: zgc.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zAddressRangeMap.hpp

rev 48258 : Patch from Stephan
2 lines changed: 1 ins; 0 del; 1 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zCollectedHeap.hpp

rev 48257 : SA for ZGC
2 lines changed: 2 ins; 0 del; 0 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zForwardingTable.hpp

rev 48258 : Patch from Stephan
2 lines changed: 1 ins; 0 del; 1 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zHeap.hpp

rev 48257 : SA for ZGC
2 lines changed: 2 ins; 0 del; 0 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPage.hpp

rev 48258 : Patch from Stephan
2 lines changed: 1 ins; 0 del; 1 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPageAllocator.hpp

rev 48257 : SA for ZGC
2 lines changed: 2 ins; 0 del; 0 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPageTable.hpp

rev 48258 : Patch from Stephan
2 lines changed: 1 ins; 0 del; 1 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPhysicalMemory.hpp

rev 48257 : SA for ZGC
2 lines changed: 2 ins; 0 del; 0 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zVirtualMemory.hpp

rev 48258 : Patch from Stephan
3 lines changed: 2 ins; 0 del; 1 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vmStructs.cpp

rev 48259 : SA for GC - patch 2
25 lines changed: 24 ins; 0 del; 1 mod; 3506 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/CollectedHeap.java

rev 48258 : Patch from Stephan
11 lines changed: 10 ins; 0 del; 1 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/CollectedHeapName.java

rev 48257 : SA for ZGC
1 line changed: 1 ins; 0 del; 0 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/memory/Universe.java

rev 48257 : SA for ZGC
2 lines changed: 2 ins; 0 del; 0 mod; 188 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Oop.java

rev 48258 : Patch from Stephan
1 line changed: 0 ins; 0 del; 1 mod; 214 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/OopField.java

rev 48258 : Patch from Stephan
2 lines changed: 1 ins; 0 del; 1 mod; 71 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/z/vmStructs_z.hpp

rev 48259 : SA for GC - patch 2
95 lines changed: 95 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddress.java

rev 48259 : SA for GC - patch 2
88 lines changed: 88 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java

rev 48259 : SA for GC - patch 2
69 lines changed: 69 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZBarrier.java

rev 48259 : SA for GC - patch 2
100 lines changed: 100 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZCollectedHeap.java

rev 48258 : Patch from Stephan
95 lines changed: 95 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZForwardingTable.java

rev 48258 : Patch from Stephan
117 lines changed: 117 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZForwardingTableCursor.java

rev 48258 : Patch from Stephan
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZForwardingTableEntry.java

rev 48258 : Patch from Stephan
55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZHash.java

rev 48258 : Patch from Stephan
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZHeap.java

rev 48259 : SA for GC - patch 2
99 lines changed: 99 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZOop.java

rev 48259 : SA for GC - patch 2
42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZPage.java

rev 48259 : SA for GC - patch 2
120 lines changed: 120 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZPageAllocator.java

rev 48257 : SA for ZGC
74 lines changed: 74 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZPageTable.java

rev 48259 : SA for GC - patch 2
66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZPageTableEntry.java

rev 48259 : SA for GC - patch 2
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZPhysicalMemoryManager.java

rev 48257 : SA for ZGC
64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZVirtualMemory.java

rev 48258 : Patch from Stephan
60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/ysuenaga/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).