Code Review for penrose

Prepared by:Shi Jun Zhang on Tue Feb 28 16:12:07 CST 2012
Workspace:/home/chance/workspace/penrose/penrose
Compare against: http://hg.openjdk.java.net/penrose/penrose
Summary of changes: 15344 lines changed: 15344 ins; 0 del; 0 mod; 0 unchg
Patch of changes: penrose.patch
Legend: Modified file
Deleted file
New file

------ ------ ------ ------ --- New Patch Raw demo/java2d/README

13 lines changed: 13 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/build.sh

14 lines changed: 14 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/deploy/configuration/config.ini

3 lines changed: 3 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw demo/java2d/deploy/org.eclipse.osgi_3.7.0.v20110613.jar

755 lines changed: 755 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/run_as_jigsaw_modules.sh

3 lines changed: 3 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/run_as_osgi_bundles.sh

2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos.arcs/java2d/demos/Arcs_Curves/Arcs.java

157 lines changed: 157 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos.arcs/java2d/demos/Arcs_Curves/BezierAnim.java

309 lines changed: 309 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos.arcs/java2d/demos/Arcs_Curves/Curves.java

145 lines changed: 145 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos.arcs/java2d/demos/Arcs_Curves/Ellipses.java

119 lines changed: 119 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos.arcs/module-info.java

30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos.clipping/java2d/demos/Clipping/Areas.java

218 lines changed: 218 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos.clipping/java2d/demos/Clipping/ClipAnim.java

283 lines changed: 283 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos.clipping/java2d/demos/Clipping/Intersection.java

246 lines changed: 246 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos.clipping/java2d/demos/Clipping/Text.java

221 lines changed: 221 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos.clipping/module-info.java

30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/Activator.java

57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/AnimatingControlsSurface.java

83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/AnimatingSurface.java

96 lines changed: 96 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/CloningFeature.java

169 lines changed: 169 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/ControlsSurface.java

81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/CustomControls.java

123 lines changed: 123 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/CustomControlsContext.java

56 lines changed: 56 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/DemoFonts.java

86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/DemoGroup.java

354 lines changed: 354 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/DemoImages.java

108 lines changed: 108 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/DemoPanel.java

128 lines changed: 128 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/GlobalControls.java

152 lines changed: 152 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/GlobalPanel.java

107 lines changed: 107 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/Intro.java

1677 lines changed: 1677 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/Java2Demo.java

547 lines changed: 547 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/Java2DemoApplet.java

187 lines changed: 187 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/MemoryMonitor.java

330 lines changed: 330 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/PerformanceMonitor.java

195 lines changed: 195 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/RunWindow.java

329 lines changed: 329 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/Surface.java

489 lines changed: 489 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/TextureChooser.java

223 lines changed: 223 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/Tools.java

470 lines changed: 470 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Colors/BullsEye.java

82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Colors/ColorConvert.java

125 lines changed: 125 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Colors/Rotator3D.java

414 lines changed: 414 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Composite/ACimages.java

116 lines changed: 116 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Composite/ACrules.java

268 lines changed: 268 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Composite/FadeAnim.java

443 lines changed: 443 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Fonts/AllFonts.java

177 lines changed: 177 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Fonts/AttributedStr.java

183 lines changed: 183 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Fonts/Highlighting.java

140 lines changed: 140 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Fonts/Outline.java

113 lines changed: 113 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Fonts/Tree.java

134 lines changed: 134 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Images/DukeAnim.java

104 lines changed: 104 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Images/ImageOps.java

257 lines changed: 257 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Images/WarpImage.java

137 lines changed: 137 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Lines/Caps.java

85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Lines/Dash.java

122 lines changed: 122 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Lines/Joins.java

210 lines changed: 210 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Lines/LineAnim.java

162 lines changed: 162 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Mix/Balls.java

354 lines changed: 354 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Mix/BezierScroller.java

355 lines changed: 355 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Mix/Stars3D.java

308 lines changed: 308 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Paint/GradAnim.java

317 lines changed: 317 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Paint/Gradient.java

196 lines changed: 196 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Paint/Texture.java

164 lines changed: 164 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Paint/TextureAnim.java

429 lines changed: 429 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Paths/Append.java

89 lines changed: 89 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Paths/CurveQuadTo.java

76 lines changed: 76 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Paths/FillStroke.java

80 lines changed: 80 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Paths/WindingRule.java

96 lines changed: 96 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Transforms/Rotate.java

161 lines changed: 161 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Transforms/SelectTx.java

308 lines changed: 308 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/java2d/demos/Transforms/TransformAnim.java

482 lines changed: 482 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/modules/java2d.demos/module-info.java

33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos.arcs/META-INF/MANIFEST.MF

9 lines changed: 9 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos.clipping/META-INF/MANIFEST.MF

9 lines changed: 9 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/META-INF/MANIFEST.MF

11 lines changed: 11 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/fonts/A.ttf

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/fonts/A.ttf`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/Thumbs.db

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/Thumbs.db`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/bld.jpg

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/bld.jpg`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/boat.png

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/boat.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/box.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/box.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/boxwave.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/boxwave.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/clone.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/clone.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/clouds.jpg

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/clouds.jpg`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/cupanim.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/cupanim.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/duke.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/duke.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/duke.png

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/duke.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/duke.running.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/duke.running.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/dukeplug.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/dukeplug.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/fight.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/fight.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/globe.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/globe.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/java-logo.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/java-logo.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/java_logo.png

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/java_logo.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/jumptojavastrip.png

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/jumptojavastrip.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/loop.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/loop.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/looping.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/looping.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/magnify.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/magnify.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/painting.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/painting.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/print.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/print.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/remove.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/remove.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/snooze.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/snooze.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/star7.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/star7.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/start.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/start.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/start2.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/start2.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/stop.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/stop.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/stop2.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/stop2.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/surfing.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/surfing.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/thumbsup.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/thumbsup.gif`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw demo/java2d/src/resource/java2d.demos/images/tip.gif

Unexpected Error occurred reading `diff -e /dev/null new/demo/java2d/src/resource/java2d.demos/images/tip.gif`: $?=0, err= 1

This code review page was prepared using webrev.cmd (vers 23.18-hg).