Code Review for rt

Prepared by: ajit (ajit) on Fri Mar 23 20:57:47 IST 2018
Workspace:/home/ajit/jfx_workspace/jfx_dev_ws/rt
Summary of changes: 500 lines changed: 370 ins; 23 del; 107 mod; 57141 unchg
Patch of changes: rt.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw build.gradle

9 lines changed: 0 ins; 9 del; 0 mod; 4997 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildSrc/addExports

4 lines changed: 4 ins; 0 del; 0 mod; 15 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw dependencies/java.base/module-info.java.extra

5 lines changed: 0 ins; 5 del; 0 mod; 28 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/com/sun/javafx/binding/Logging.java

2 lines changed: 0 ins; 0 del; 2 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/com/sun/javafx/binding/SelectBinding.java

3 lines changed: 0 ins; 0 del; 3 mod; 549 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/com/sun/javafx/collections/ArrayListenerHelper.java

2 lines changed: 0 ins; 0 del; 2 mod; 345 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/com/sun/javafx/collections/ListListenerHelper.java

2 lines changed: 0 ins; 0 del; 2 mod; 338 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/com/sun/javafx/collections/MapListenerHelper.java

2 lines changed: 0 ins; 0 del; 2 mod; 336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/com/sun/javafx/collections/SetListenerHelper.java

2 lines changed: 0 ins; 0 del; 2 mod; 336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/main/java/module-info.java

5 lines changed: 3 ins; 0 del; 2 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/test/addExports

2 lines changed: 1 ins; 1 del; 0 mod; 11 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.base/src/test/java/test/com/sun/javafx/binding/SelectBindingTest.java

6 lines changed: 1 ins; 3 del; 2 mod; 651 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/Logging.java

2 lines changed: 0 ins; 0 del; 2 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/Control.java

3 lines changed: 0 ins; 0 del; 3 mod; 960 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/PopupControl.java

3 lines changed: 0 ins; 0 del; 3 mod; 1243 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/TableView.java

3 lines changed: 1 ins; 0 del; 2 mod; 3373 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/cell/PropertyValueFactory.java

3 lines changed: 0 ins; 0 del; 3 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/cell/TreeItemPropertyValueFactory.java

3 lines changed: 0 ins; 0 del; 3 mod; 205 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java

2 lines changed: 0 ins; 0 del; 2 mod; 2969 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/test/addExports

2 lines changed: 1 ins; 1 del; 0 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlTest.java

7 lines changed: 0 ins; 2 del; 5 mod; 1235 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkApplication.java

1 line changed: 0 ins; 0 del; 1 mod; 480 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/javafx/css/StyleManager.java

3 lines changed: 0 ins; 0 del; 3 mod; 2283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/javafx/scene/layout/region/Margins.java

3 lines changed: 0 ins; 0 del; 3 mod; 171 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/PrismImageLoader2.java

2 lines changed: 0 ins; 0 del; 2 mod; 304 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/javafx/util/Logging.java

2 lines changed: 0 ins; 0 del; 2 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/marlin/MarlinUtils.java

3 lines changed: 0 ins; 0 del; 3 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/prism/d3d/D3DPhongMaterial.java

2 lines changed: 0 ins; 0 del; 2 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/prism/es2/ES2PhongMaterial.java

2 lines changed: 0 ins; 0 del; 2 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/prism/impl/BaseMesh.java

2 lines changed: 0 ins; 0 del; 2 mod; 883 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/concurrent/Service.java

2 lines changed: 0 ins; 0 del; 2 mod; 919 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/css/CssParser.java

4 lines changed: 1 ins; 0 del; 3 mod; 4835 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/css/StyleConverter.java

3 lines changed: 0 ins; 0 del; 3 mod; 570 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/css/converter/EnumConverter.java

3 lines changed: 0 ins; 0 del; 3 mod; 210 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/css/converter/URLConverter.java

2 lines changed: 0 ins; 0 del; 2 mod; 273 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/Camera.java

2 lines changed: 0 ins; 0 del; 2 mod; 527 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java

3 lines changed: 0 ins; 0 del; 3 mod; 2230 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/LightBase.java

2 lines changed: 0 ins; 0 del; 2 mod; 333 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/Node.java

3 lines changed: 0 ins; 0 del; 3 mod; 10069 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/PerspectiveCamera.java

2 lines changed: 0 ins; 0 del; 2 mod; 341 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/Scene.java

3 lines changed: 0 ins; 0 del; 3 mod; 6476 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/SnapshotParameters.java

2 lines changed: 0 ins; 0 del; 2 mod; 213 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/SubScene.java

2 lines changed: 0 ins; 0 del; 2 mod; 918 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/layout/Region.java

3 lines changed: 0 ins; 0 del; 3 mod; 3633 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/paint/Material.java

2 lines changed: 0 ins; 0 del; 2 mod; 104 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/shape/Mesh.java

2 lines changed: 0 ins; 0 del; 2 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/shape/Shape3D.java

1 line changed: 0 ins; 0 del; 1 mod; 266 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/javafx/scene/shape/TriangleMesh.java

2 lines changed: 0 ins; 0 del; 2 mod; 946 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/test/addExports

2 lines changed: 1 ins; 1 del; 0 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/test/java/test/javafx/css/HonorDeveloperSettingsTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 391 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java

3 lines changed: 0 ins; 0 del; 3 mod; 1079 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw tests/system/src/test/addExports

1 line changed: 0 ins; 1 del; 0 mod; 25 unchg

------ ------ ------ ------ --- New Patch Raw modules/javafx.base/src/main/java/com/sun/javafx/logging/PlatformLogger.java

357 lines changed: 357 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/ajit/Downloads/webrev.ksh (vers 25.14-hg+openjdk.java.net).