--- old/src/windows/native/java/lang/ProcessImpl_md.c 2013-09-11 20:38:16.471736915 +0400 +++ new/src/windows/native/java/lang/ProcessImpl_md.c 2013-09-11 20:38:16.083741792 +0400 @@ -308,7 +308,11 @@ if (success) { PROCESS_INFORMATION pi; - DWORD processFlag = CREATE_NO_WINDOW | CREATE_UNICODE_ENVIRONMENT; + DWORD processFlag = CREATE_UNICODE_ENVIRONMENT; + + /* Suppress popping-up of a console window for non-console applications */ + if (GetConsoleWindow() == NULL) + processFlag |= CREATE_NO_WINDOW; si.dwFlags = STARTF_USESTDHANDLES; if (!CreateProcessW( --- old/test/java/lang/ProcessBuilder/Basic.java 2013-09-11 20:38:17.915718762 +0400 +++ new/test/java/lang/ProcessBuilder/Basic.java 2013-09-11 20:38:17.499723993 +0400 @@ -298,11 +298,18 @@ System.exit(5); System.err.print("standard error"); System.out.print("standard output"); - } else if (action.equals("testInheritIO")) { + } else if (action.equals("testInheritIO") + || action.equals("testRedirectInherit")) { List childArgs = new ArrayList(javaChildArgs); childArgs.add("testIO"); ProcessBuilder pb = new ProcessBuilder(childArgs); - pb.inheritIO(); + if (action.equals("testInheritIO")) { + pb.inheritIO(); + } else { + pb.redirectInput(Redirect.INHERIT) + .redirectOutput(Redirect.INHERIT) + .redirectError(Redirect.INHERIT); + } ProcessResults r = run(pb); if (! r.out().equals("")) System.exit(7); @@ -1019,10 +1026,10 @@ // Note that this requires __FOUR__ nested JVMs involved in one test, // if you count the harness JVM. //---------------------------------------------------------------- - { + for (String testName : new String[] { "testInheritIO", "testRedirectInherit" } ) { redirectIO(pb, PIPE, PIPE, PIPE); List command = pb.command(); - command.set(command.size() - 1, "testInheritIO"); + command.set(command.size() - 1, testName); Process p = pb.start(); new PrintStream(p.getOutputStream()).print("standard input"); p.getOutputStream().close(); --- /dev/null 2013-09-11 11:52:51.043491907 +0400 +++ new/test/java/lang/ProcessBuilder/InheritIO.sh 2013-09-11 20:38:18.835707197 +0400 @@ -0,0 +1,84 @@ +# +# Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. +# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. +# +# This code is free software; you can redistribute it and/or modify it +# under the terms of the GNU General Public License version 2 only, as +# published by the Free Software Foundation. +# +# This code is distributed in the hope that it will be useful, but WITHOUT +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or +# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License +# version 2 for more details (a copy is included in the LICENSE file that +# accompanied this code). +# +# You should have received a copy of the GNU General Public License version +# 2 along with this work; if not, write to the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. +# +# Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA +# or visit www.oracle.com if you need additional information or have any +# questions. +# + +# @test +# @bug 8023130 +# @summary (process) ProcessBuilder#inheritIO does not work on Windows +# @run build Basic +# @run shell InheritIO.sh + +if [ "${TESTJAVA}" = "" ] +then + echo "TESTJAVA not set. Test cannot execute. Failed." + exit 1 +fi + +if [ "${COMPILEJAVA}" = "" ] +then + COMPILEJAVA="${TESTJAVA}" +fi + +if [ "${TESTSRC}" = "" ] +then + echo "TESTSRC not set. Test cannot execute. Failed." + exit 1 +fi + +if [ "${TESTCLASSES}" = "" ] +then + echo "TESTCLASSES not set. Test cannot execute. Failed." + exit 1 +fi + +JAVA="${TESTJAVA}"/bin/java + +for TEST_NAME in testInheritIO testRedirectInherit +do + +printf "standard input" | \ + "${JAVA}" ${TESTVMOPTS} -classpath "${TESTCLASSES}" \ + 'Basic$JavaChild' $TEST_NAME > stdout.txt 2> stderr.txt +RES="$?" + +if [ "$RES" != 0 ]; then + echo 'FAIL: Basic$JavaChild '$TEST_NAME' failed' + exit "$RES" +fi + +OUT_EXPECTED='standard output' +OUT_RECEIVED=`cat stdout.txt` + +if [ "$OUT_RECEIVED" != "$OUT_EXPECTED" ]; then + echo "FAIL: unexpected '$OUT_RECEIVED' in stdout" + exit 1 +fi + +ERR_EXPECTED='standard error' +ERR_RECEIVED=`cat stderr.txt` + +if [ "$ERR_RECEIVED" != "$ERR_EXPECTED" ]; then + echo "FAIL: unexpected '$ERR_RECEIVED' in stderr" + exit 1 +fi + +done