Code Review for Initial stack allocation prototype

Prepared by: Charlie Gracie on Mon Jun 29 11:13:41 EDT 2020
Compare against: https://github.com/openjdk/jdk
Compare against version: c07ce7ee
Summary of changes: 2118 lines changed; 1978 ins; 19 del; 121 mod; 46488 unchg
Patch of changes: Initial stack allocation prototype.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/code/debugInfo.cpp

b5bcfd27: Initial stack allocation prototype  
58 lines changed; 49 ins; 5 del; 4 mod; 301 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/code/debugInfo.hpp

b5bcfd27: Initial stack allocation prototype  
23 lines changed; 21 ins; 0 del; 2 mod; 326 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/compiler/compilerDefinitions.cpp

b5bcfd27: Initial stack allocation prototype  
9 lines changed; 9 ins; 0 del; 0 mod; 565 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/compiler/compilerDirectives.hpp

b5bcfd27: Initial stack allocation prototype  
5 lines changed; 4 ins; 0 del; 1 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/compiler/oopMap.cpp

b5bcfd27: Initial stack allocation prototype  
100 lines changed; 99 ins; 0 del; 1 mod; 747 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/compiler/oopMap.hpp

b5bcfd27: Initial stack allocation prototype  
5 lines changed; 5 ins; 0 del; 0 mod; 448 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/c2/g1BarrierSetC2.cpp

b5bcfd27: Initial stack allocation prototype  
170 lines changed; 149 ins; 0 del; 21 mod; 851 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/c2/g1BarrierSetC2.hpp

b5bcfd27: Initial stack allocation prototype  
2 lines changed; 2 ins; 0 del; 0 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psParallelCompact.inline.hpp

b5bcfd27: Initial stack allocation prototype  
2 lines changed; 0 ins; 0 del; 2 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/c2/barrierSetC2.hpp

b5bcfd27: Initial stack allocation prototype  
1 lines changed; 1 ins; 0 del; 0 mod; 306 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/c2/cardTableBarrierSetC2.cpp

b5bcfd27: Initial stack allocation prototype  
226 lines changed; 198 ins; 2 del; 26 mod; 162 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/c2/cardTableBarrierSetC2.hpp

b5bcfd27: Initial stack allocation prototype  
27 lines changed; 27 ins; 0 del; 0 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/cardTable.hpp

b5bcfd27: Initial stack allocation prototype  
2 lines changed; 2 ins; 0 del; 0 mod; 267 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/iterator.cpp

b5bcfd27: Initial stack allocation prototype  
1 lines changed; 1 ins; 0 del; 0 mod; 65 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/block.cpp

b5bcfd27: Initial stack allocation prototype  
1 lines changed; 0 ins; 0 del; 1 mod; 1790 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/buildOopMap.cpp

b5bcfd27: Initial stack allocation prototype  
2 lines changed; 1 ins; 0 del; 1 mod; 684 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/c2_globals.hpp

b5bcfd27: Initial stack allocation prototype  
9 lines changed; 9 ins; 0 del; 0 mod; 779 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/callnode.cpp

b5bcfd27: Initial stack allocation prototype  
37 lines changed; 30 ins; 1 del; 6 mod; 2088 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/callnode.hpp

b5bcfd27: Initial stack allocation prototype  
10 lines changed; 10 ins; 0 del; 0 mod; 1133 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/compile.cpp

b5bcfd27: Initial stack allocation prototype  
2 lines changed; 2 ins; 0 del; 0 mod; 4664 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/compile.hpp

b5bcfd27: Initial stack allocation prototype  
11 lines changed; 9 ins; 0 del; 2 mod; 1180 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/escape.cpp

b5bcfd27: Initial stack allocation prototype  
322 lines changed; 316 ins; 0 del; 6 mod; 3573 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/escape.hpp

b5bcfd27: Initial stack allocation prototype  
32 lines changed; 32 ins; 0 del; 0 mod; 621 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/idealKit.cpp

b5bcfd27: Initial stack allocation prototype  
31 lines changed; 31 ins; 0 del; 0 mod; 587 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/idealKit.hpp

b5bcfd27: Initial stack allocation prototype  
10 lines changed; 10 ins; 0 del; 0 mod; 263 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/loopnode.cpp

b5bcfd27: Initial stack allocation prototype  
1 lines changed; 0 ins; 0 del; 1 mod; 4795 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/machnode.hpp

b5bcfd27: Initial stack allocation prototype  
5 lines changed; 4 ins; 0 del; 1 mod; 1122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/macro.cpp

b5bcfd27: Initial stack allocation prototype  
543 lines changed; 529 ins; 7 del; 7 mod; 2805 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/macro.hpp

b5bcfd27: Initial stack allocation prototype  
30 lines changed; 30 ins; 0 del; 0 mod; 230 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/memnode.cpp

b5bcfd27: Initial stack allocation prototype  
8 lines changed; 6 ins; 0 del; 2 mod; 4886 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/output.cpp

b5bcfd27: Initial stack allocation prototype  
66 lines changed; 51 ins; 1 del; 14 mod; 3499 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/deoptimization.cpp

b5bcfd27: Initial stack allocation prototype  
267 lines changed; 249 ins; 3 del; 15 mod; 2616 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/deoptimization.hpp

b5bcfd27: Initial stack allocation prototype  
9 lines changed; 7 ins; 0 del; 2 mod; 475 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vframe_hp.cpp

b5bcfd27: Initial stack allocation prototype  
77 lines changed; 75 ins; 0 del; 2 mod; 453 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vframe_hp.hpp

b5bcfd27: Initial stack allocation prototype  
4 lines changed; 4 ins; 0 del; 0 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/ArrayList.java

b5bcfd27: Initial stack allocation prototype  
5 lines changed; 3 ins; 0 del; 2 mod; 1728 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/regex/Matcher.java

b5bcfd27: Initial stack allocation prototype  
5 lines changed; 3 ins; 0 del; 2 mod; 1804 unchg

This code review page was prepared using webrev version 971c746c36ad5c768b72fe35d8df9d48132153f6