test/sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java

rev 14408 : 8256818: SSLSocket that is never bound or connected leaks socket resources
Reviewed-by: xuelei
rev 14409 : 8257670: sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java reports leaks
Reviewed-by: jnimeh
rev 14410 : 8257884: Re-enable sun/security/ssl/SSLSocketImpl/SSLSocketLeak.java as automatic test
Reviewed-by: xuelei

@@ -29,11 +29,11 @@
 
 import com.sun.management.UnixOperatingSystemMXBean;
 
 /*
  * @test
- * @bug 8256818 8257670
+ * @bug 8256818 8257670 8257884
  * @summary Test that creating and closing SSL Sockets without bind/connect
  *          will not leave leaking socket file descriptors
  * @run main/native/manual/othervm SSLSocketLeak
  * @comment native library is required only on Windows, use the following commands:
  *          "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\vcvars64.bat"

@@ -46,14 +46,18 @@
  *          jtreg <...> -nativepath:. <path/to/jdk8u>\jdk\test\sun\security\ssl\SSLSocketImpl\SSLSocketLeak.java
  */
 // Note: this test is not reliable, run it manually.
 public class SSLSocketLeak {
 
+    // number of sockets to open/close
     private static final int NUM_TEST_SOCK = 500;
     private static final boolean IS_WINDOWS = System.getProperty("os.name").toLowerCase().startsWith("windows");
     private static volatile boolean nativeLibLoaded;
 
+    // percentage of accepted growth of open handles
+    private static final int OPEN_HANDLE_GROWTH_THRESHOLD = IS_WINDOWS ? 25 : 10;
+
     public static void main(String[] args) throws IOException {
         long fds_start = getProcessHandleCount();
         System.out.println("FDs at the beginning: " + fds_start);
 
         SocketFactory f = SSLSocketFactory.getDefault();

@@ -62,11 +66,11 @@
         }
 
         long fds_end = getProcessHandleCount();
         System.out.println("FDs in the end: " + fds_end);
 
-        if ((fds_end - fds_start) > (NUM_TEST_SOCK / 10)) {
+        if ((fds_end - fds_start) > (NUM_TEST_SOCK / OPEN_HANDLE_GROWTH_THRESHOLD)) {
             throw new RuntimeException("Too many open file descriptors. Looks leaky.");
         }
     }
 
     // Return the current process handle count