Code Review for hotspot

Prepared by:andrew on Wed Nov 21 06:42:16 GMT 2018
Workspace:/home/andrew/projects/openjdk/upstream/jdk8u-dev/hotspot
Compare against: ssh://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot
Compare against version:8845
Summary of changes: 265 lines changed: 65 ins; 34 del; 166 mod; 20946 unchg
Changeset: hotspot.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw agent/src/os/linux/libproc_impl.c

rev 8846 : 7127191: SA JSDB does not display native symbols correctly for transported Linux cores
Summary: Better handle SA_ALTROOT
Reviewed-by: sla, sspitsyn
rev 8847 : 8140482: Various minor code improvements (runtime)
Reviewed-by: dholmes, coleenp, sspitsyn, dsamersoff
66 lines changed: 23 ins; 16 del; 27 mod; 400 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw agent/src/os/linux/ps_core.c

rev 8847 : 8140482: Various minor code improvements (runtime)
Reviewed-by: dholmes, coleenp, sspitsyn, dsamersoff
72 lines changed: 6 ins; 0 del; 66 mod; 1026 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxCDebugger.java

rev 8846 : 7127191: SA JSDB does not display native symbols correctly for transported Linux cores
Summary: Better handle SA_ALTROOT
Reviewed-by: sla, sspitsyn
26 lines changed: 4 ins; 14 del; 8 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js

rev 8846 : 7127191: SA JSDB does not display native symbols correctly for transported Linux cores
Summary: Better handle SA_ALTROOT
Reviewed-by: sla, sspitsyn
41 lines changed: 13 ins; 1 del; 27 mod; 876 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/cpu/x86/vm/templateTable_x86_64.cpp

rev 8847 : 8140482: Various minor code improvements (runtime)
Reviewed-by: dholmes, coleenp, sspitsyn, dsamersoff
3 lines changed: 1 ins; 0 del; 2 mod; 3834 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/os/linux/vm/attachListener_linux.cpp

rev 8847 : 8140482: Various minor code improvements (runtime)
Reviewed-by: dholmes, coleenp, sspitsyn, dsamersoff
2 lines changed: 2 ins; 0 del; 0 mod; 532 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/os/linux/vm/os_linux.cpp

rev 8847 : 8140482: Various minor code improvements (runtime)
Reviewed-by: dholmes, coleenp, sspitsyn, dsamersoff
3 lines changed: 2 ins; 0 del; 1 mod; 6636 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/os/windows/vm/attachListener_windows.cpp

rev 8847 : 8140482: Various minor code improvements (runtime)
Reviewed-by: dholmes, coleenp, sspitsyn, dsamersoff
2 lines changed: 1 ins; 0 del; 1 mod; 406 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/asm/codeBuffer.cpp

rev 8847 : 8140482: Various minor code improvements (runtime)
Reviewed-by: dholmes, coleenp, sspitsyn, dsamersoff
1 line changed: 1 ins; 0 del; 0 mod; 1207 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/libadt/dict.cpp

rev 8847 : 8140482: Various minor code improvements (runtime)
Reviewed-by: dholmes, coleenp, sspitsyn, dsamersoff
25 lines changed: 2 ins; 2 del; 21 mod; 368 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/deoptimization.cpp

rev 8847 : 8140482: Various minor code improvements (runtime)
Reviewed-by: dholmes, coleenp, sspitsyn, dsamersoff
1 line changed: 1 ins; 0 del; 0 mod; 2082 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/runtime/task.cpp

rev 8847 : 8140482: Various minor code improvements (runtime)
Reviewed-by: dholmes, coleenp, sspitsyn, dsamersoff
3 lines changed: 2 ins; 1 del; 0 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/services/attachListener.hpp

rev 8847 : 8140482: Various minor code improvements (runtime)
Reviewed-by: dholmes, coleenp, sspitsyn, dsamersoff
7 lines changed: 3 ins; 0 del; 4 mod; 154 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/services/heapDumper.cpp

rev 8847 : 8140482: Various minor code improvements (runtime)
Reviewed-by: dholmes, coleenp, sspitsyn, dsamersoff
1 line changed: 0 ins; 0 del; 1 mod; 2050 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/services/memoryService.cpp

rev 8847 : 8140482: Various minor code improvements (runtime)
Reviewed-by: dholmes, coleenp, sspitsyn, dsamersoff
6 lines changed: 1 ins; 0 del; 5 mod; 615 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/vm/utilities/xmlstream.cpp

rev 8847 : 8140482: Various minor code improvements (runtime)
Reviewed-by: dholmes, coleenp, sspitsyn, dsamersoff
6 lines changed: 3 ins; 0 del; 3 mod; 497 unchg

This code review page was prepared using /home/andrew/bin/webrev (vers 25.17-hg+openjdk.java.net).