Code Review for jdk

Prepared by:andrew on Thu Jul 11 17:59:44 BST 2019
Workspace:/home/andrew/projects/openjdk/upstream/jdk8u-dev/jdk
Compare against: ssh://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk
Compare against version:13617
Summary of changes: 1631 lines changed: 1262 ins; 44 del; 325 mod; 42724 unchg
Changeset: jdk.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/data/tzdata/VERSION

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
1 line changed: 0 ins; 0 del; 1 mod; 23 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/data/tzdata/africa

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
100 lines changed: 88 ins; 3 del; 9 mod; 1275 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/data/tzdata/asia

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
385 lines changed: 270 ins; 17 del; 98 mod; 3291 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/data/tzdata/australasia

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
251 lines changed: 221 ins; 0 del; 30 mod; 1818 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/data/tzdata/backward

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
2 lines changed: 1 ins; 0 del; 1 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/data/tzdata/etcetera

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
1 line changed: 0 ins; 1 del; 0 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/data/tzdata/europe

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
2 lines changed: 0 ins; 0 del; 2 mod; 4016 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/data/tzdata/iso3166.tab

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
4 lines changed: 0 ins; 0 del; 4 mod; 293 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/data/tzdata/leapseconds

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
7 lines changed: 3 ins; 0 del; 4 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/data/tzdata/northamerica

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
38 lines changed: 38 ins; 0 del; 0 mod; 3472 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/data/tzdata/zone.tab

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
3 lines changed: 2 ins; 1 del; 0 mod; 470 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/calendar/ZoneInfoFile.java

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
7 lines changed: 4 ins; 0 del; 3 mod; 1012 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/TimeZoneNames.java

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
5 lines changed: 3 ins; 0 del; 2 mod; 1041 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/de/TimeZoneNames_de.java

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
2 lines changed: 0 ins; 0 del; 2 mod; 1042 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/es/TimeZoneNames_es.java

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
2 lines changed: 0 ins; 0 del; 2 mod; 1042 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/fr/TimeZoneNames_fr.java

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
2 lines changed: 0 ins; 0 del; 2 mod; 1042 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/it/TimeZoneNames_it.java

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
2 lines changed: 0 ins; 0 del; 2 mod; 1042 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/ja/TimeZoneNames_ja.java

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
2 lines changed: 0 ins; 0 del; 2 mod; 1042 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/ko/TimeZoneNames_ko.java

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
2 lines changed: 0 ins; 0 del; 2 mod; 1042 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/pt/TimeZoneNames_pt_BR.java

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
2 lines changed: 0 ins; 0 del; 2 mod; 1042 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/sv/TimeZoneNames_sv.java

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
2 lines changed: 0 ins; 0 del; 2 mod; 1042 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_CN.java

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
2 lines changed: 0 ins; 0 del; 2 mod; 1042 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_TW.java

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
2 lines changed: 0 ins; 0 del; 2 mod; 1044 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/util/calendar/zi/TestZoneInfo310.java

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
11 lines changed: 9 ins; 0 del; 2 mod; 255 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/util/calendar/zi/tzdata/VERSION

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
1 line changed: 0 ins; 0 del; 1 mod; 23 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/util/calendar/zi/tzdata/africa

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
100 lines changed: 88 ins; 3 del; 9 mod; 1275 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/util/calendar/zi/tzdata/asia

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
385 lines changed: 270 ins; 17 del; 98 mod; 3291 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/util/calendar/zi/tzdata/australasia

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
251 lines changed: 221 ins; 0 del; 30 mod; 1818 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/util/calendar/zi/tzdata/backward

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
2 lines changed: 1 ins; 0 del; 1 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/util/calendar/zi/tzdata/etcetera

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
1 line changed: 0 ins; 1 del; 0 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/util/calendar/zi/tzdata/europe

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
2 lines changed: 0 ins; 0 del; 2 mod; 4016 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/util/calendar/zi/tzdata/iso3166.tab

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
4 lines changed: 0 ins; 0 del; 4 mod; 293 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/util/calendar/zi/tzdata/leapseconds

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
7 lines changed: 3 ins; 0 del; 4 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/util/calendar/zi/tzdata/northamerica

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
38 lines changed: 38 ins; 0 del; 0 mod; 3472 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/util/calendar/zi/tzdata/zone.tab

rev 13618 : 8224560: (tz) Upgrade time-zone data to tzdata2019a
8215982: (tz) Upgrade time-zone data to tzdata2018i
8225580: tzdata2018i integration causes test failures on jdk-13
Reviewed-by: andrew, naoto
3 lines changed: 2 ins; 1 del; 0 mod; 470 unchg

This code review page was prepared using /home/andrew/bin/webrev (vers 25.18-hg+openjdk.java.net).