Code Review for rt-JDK-8143596

Prepared by:anyssen on Sat Sep 10 11:35:51 CEST 2016
Workspace:/Users/nyssen/mercurial/openjfx/9-dev/rt-JDK-8143596
Compare against version:10031
Summary of changes: 556 lines changed: 527 ins; 3 del; 26 mod; 3129 unchg
Patch of changes: rt-JDK-8143596.patch
Bug id: JDK-8143596
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/javafx/embed/AbstractEvents.java

rev 10032 : 8143596: Ensure FXCanvas properly forwards SWT gesture events to its embedded scene.
Summary: Ensured SWT magnify, rotate, pan, and swipe events are properly forwarded to the embedded scene.
Reviewed-by: XXXX
79 lines changed: 77 ins; 2 del; 0 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/javafx/embed/EmbeddedSceneInterface.java

rev 10032 : 8143596: Ensure FXCanvas properly forwards SWT gesture events to its embedded scene.
Summary: Ensured SWT magnify, rotate, pan, and swipe events are properly forwarded to the embedded scene.
Reviewed-by: XXXX
23 lines changed: 22 ins; 0 del; 1 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/EmbeddedScene.java

rev 10032 : 8143596: Ensure FXCanvas properly forwards SWT gesture events to its embedded scene.
Summary: Ensured SWT magnify, rotate, pan, and swipe events are properly forwarded to the embedded scene.
Reviewed-by: XXXX
64 lines changed: 59 ins; 1 del; 4 mod; 381 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java

rev 10032 : 8143596: Ensure FXCanvas properly forwards SWT gesture events to its embedded scene.
Summary: Ensured SWT magnify, rotate, pan, and swipe events are properly forwarded to the embedded scene.
Reviewed-by: XXXX
5 lines changed: 3 ins; 0 del; 2 mod; 1032 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.swt/src/main/java/javafx/embed/swt/FXCanvas.java

rev 10032 : 8143596: Ensure FXCanvas properly forwards SWT gesture events to its embedded scene.
Summary: Ensured SWT magnify, rotate, pan, and swipe events are properly forwarded to the embedded scene.
Reviewed-by: XXXX
246 lines changed: 235 ins; 0 del; 11 mod; 1187 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/javafx.swt/src/main/java/javafx/embed/swt/SWTEvents.java

rev 10032 : 8143596: Ensure FXCanvas properly forwards SWT gesture events to its embedded scene.
Summary: Ensured SWT magnify, rotate, pan, and swipe events are properly forwarded to the embedded scene.
Reviewed-by: XXXX
9 lines changed: 1 ins; 0 del; 8 mod; 295 unchg

------ ------ ------ ------ --- New Patch Raw tests/manual/swt/FXCanvasGestureEventsTest.java

rev 10032 : 8143596: Ensure FXCanvas properly forwards SWT gesture events to its embedded scene.
Summary: Ensured SWT magnify, rotate, pan, and swipe events are properly forwarded to the embedded scene.
Reviewed-by: XXXX
130 lines changed: 130 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ../../../webrev.ksh (vers 25.16-hg+openjdk.java.net).