Code Review for open

Prepared by: U-ASEMENYU-LAPsemenyu (ASEMENYU-LAP+asemenyu) on Thu May 23 13:17:52 EDT 2019
Workspace:/cygdrive/c/ade/work/as/jds/work/10_sandbox/jdk10/open
Compare against: http://hg.openjdk.java.net/jdk/sandbox
Branch:JDK-8200758-branch
Summary of changes: 779 lines changed: 454 ins; 277 del; 48 mod; 2313 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/CompileJavaModules.gmk

1 line changed: 0 ins; 0 del; 1 mod; 692 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/main/CommandLine.java

3 lines changed: 0 ins; 0 del; 3 mod; 313 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinMsiBundler.java

364 lines changed: 148 ins; 175 del; 41 mod; 988 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties

2 lines changed: 0 ins; 1 del; 1 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_ja.properties

2 lines changed: 0 ins; 1 del; 1 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_zh_CN.properties

2 lines changed: 0 ins; 1 del; 1 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/exe/install.bat

1 line changed: 1 ins; 0 del; 0 mod; 16 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/exe/uninstall.bat

1 line changed: 1 ins; 0 del; 0 mod; 12 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/msi/install.bat

1 line changed: 1 ins; 0 del; 0 mod; 16 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/msi/uninstall.bat

1 line changed: 1 ins; 0 del; 0 mod; 12 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_en.wxl

4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_ja.wxl

4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_zh_CN.wxl

4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/main.wxs

112 lines changed: 112 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/base/JPackageCreateInstallerRuntimeBase.java

82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/exe/JPackageCreateInstallerRuntimeTest.java

48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/createinstaller/windows/msi/JPackageCreateInstallerRuntimeTest.java

48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/template.jre.wxs

46 lines changed: 0 ins; 46 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/template.wxs

53 lines changed: 0 ins; 53 del; 0 mod; 0 unchg

This code review page was prepared using /cygdrive/c/ade/work/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).