Code Review for open

Prepared by: U-ASEMENYU-LAPsemenyu (ASEMENYU-LAP+asemenyu) on Wed Sep 18 10:39:21 EDT 2019
Workspace:/cygdrive/c/ade/work/as/jds/work/10_sandbox/jdk10/open
Branch:JDK-8200758-branch
Summary of changes: 4485 lines changed: 2778 ins; 1225 del; 482 mod; 5814 unchg
Patch of changes: open.patch
Bug id: JDK-8225249 : LinuxDebBundler and LinuxRpmBundler should share more code
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/CompileJavaModules.gmk

2 lines changed: 0 ins; 0 del; 2 mod; 690 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxAppBundler.java

6 lines changed: 0 ins; 6 del; 0 mod; 176 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxAppImageBuilder.java

14 lines changed: 0 ins; 12 del; 2 mod; 211 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxDebBundler.java

668 lines changed: 9 ins; 566 del; 93 mod; 315 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxRpmBundler.java

514 lines changed: 9 ins; 464 del; 41 mod; 219 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/template.desktop

2 lines changed: 0 ins; 0 del; 2 mod; 7 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/template.postinst

7 lines changed: 0 ins; 5 del; 2 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/template.postrm

1 line changed: 0 ins; 0 del; 1 mod; 30 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/template.preinst

1 line changed: 0 ins; 0 del; 1 mod; 29 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/template.prerm

9 lines changed: 2 ins; 5 del; 2 mod; 33 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/template.spec

21 lines changed: 5 ins; 7 del; 9 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/Arguments.java

1 line changed: 0 ins; 0 del; 1 mod; 805 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/IOUtils.java

32 lines changed: 0 ins; 31 del; 1 mod; 242 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/apps/image/Hello.java

41 lines changed: 4 ins; 25 del; 12 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Executor.java

53 lines changed: 36 ins; 2 del; 15 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/HelloApp.java

61 lines changed: 43 ins; 12 del; 6 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JPackageCommand.java

178 lines changed: 157 ins; 9 del; 12 mod; 346 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/LinuxHelper.java

170 lines changed: 159 ins; 5 del; 6 mod; 150 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageTest.java

139 lines changed: 103 ins; 8 del; 28 mod; 311 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageType.java

17 lines changed: 1 ins; 5 del; 11 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Test.java

231 lines changed: 214 ins; 1 del; 16 mod; 274 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/WindowsHelper.java

7 lines changed: 1 ins; 2 del; 4 mod; 239 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/AppCategoryTest.java

15 lines changed: 3 ins; 0 del; 12 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/BundleNameTest.java

15 lines changed: 3 ins; 0 del; 12 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/LicenseTypeTest.java

10 lines changed: 3 ins; 0 del; 7 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/MaintainerTest.java

14 lines changed: 2 ins; 0 del; 12 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/PackageDepsTest.java

17 lines changed: 3 ins; 0 del; 14 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/ReleaseTest.java

20 lines changed: 3 ins; 1 del; 16 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/FileAssociationsTest.java

81 lines changed: 2 ins; 53 del; 26 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/InstallDirTest.java

18 lines changed: 3 ins; 2 del; 13 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/LicenseTest.java

68 lines changed: 35 ins; 3 del; 30 mod; 109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/RuntimePackageTest.java

19 lines changed: 8 ins; 0 del; 11 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/SimplePackageTest.java

8 lines changed: 6 ins; 0 del; 2 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinConsoleTest.java

15 lines changed: 2 ins; 0 del; 13 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinDirChooserTest.java

8 lines changed: 3 ins; 0 del; 5 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinMenuGroupTest.java

10 lines changed: 3 ins; 0 del; 7 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinMenuTest.java

8 lines changed: 3 ins; 0 del; 5 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinPerUserInstallTest.java

12 lines changed: 3 ins; 0 del; 9 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinShortcutTest.java

9 lines changed: 3 ins; 0 del; 6 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinUpgradeUUIDTest.java

18 lines changed: 4 ins; 1 del; 13 mod; 55 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxPackageBundler.java

712 lines changed: 712 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/utils.sh

104 lines changed: 104 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/ApplicationLayout.java

116 lines changed: 116 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/PathGroup.java

181 lines changed: 181 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/PlatformPackage.java

53 lines changed: 53 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/apps/dukeplug.png

Unexpected Error occurred reading `diff -e /dev/null new/test/jdk/tools/jpackage/apps/dukeplug.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/FileAssociations.java

68 lines changed: 68 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/linux/ShortcutHintTest.java

135 lines changed: 135 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/manage_packages.sh (was test/jdk/tools/jpackage/share/manage_packages.sh)

2 lines changed: 0 ins; 0 del; 2 mod; 183 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/run_tests.sh

278 lines changed: 278 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/share/AdditionalLaunchersTest.java

156 lines changed: 156 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/share/AppImagePackageTest.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/test_jpackage.sh

68 lines changed: 68 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /cygdrive/c/ade/work/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).