Code Review for open

Prepared by: U-ASEMENYU-LAPsemenyu (ASEMENYU-LAP+asemenyu) on Mon Sep 9 14:14:04 EDT 2019
Workspace:/cygdrive/c/ade/work/as/jds/work/10_sandbox/jdk10/open
Branch:JDK-8200758-branch
Summary of changes: 6224 lines changed: 1521 ins; 3644 del; 1059 mod; 853 unchg
Patch of changes: open.patch
Bug id: JDK-8230726 : Improve jpackage jtreg tests
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Executor.java

61 lines changed: 53 ins; 0 del; 8 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JPackageCommand.java

235 lines changed: 164 ins; 36 del; 35 mod; 167 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JavaTool.java

11 lines changed: 9 ins; 1 del; 1 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/LinuxHelper.java

161 lines changed: 13 ins; 0 del; 148 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageTest.java

347 lines changed: 34 ins; 0 del; 313 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageType.java

37 lines changed: 26 ins; 1 del; 10 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Test.java

291 lines changed: 121 ins; 0 del; 170 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/AppCategoryTest.java

75 lines changed: 0 ins; 8 del; 67 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/ReleaseTest.java

74 lines changed: 0 ins; 3 del; 71 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinConsoleTest.java

113 lines changed: 27 ins; 69 del; 17 mod; 50 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/HelloApp.java

104 lines changed: 104 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/MacHelper.java

46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/WindowsHelper.java

245 lines changed: 245 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/BundleNameTest.java (was test/jdk/tools/jpackage/linux/base/BundleNameBase.java)

64 lines changed: 0 ins; 21 del; 43 mod; 24 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/LicenseTypeTest.java (was test/jdk/tools/jpackage/linux/base/LicenseTypeBase.java)

84 lines changed: 0 ins; 52 del; 32 mod; 25 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/MaintainerTest.java (was test/jdk/tools/jpackage/linux/base/MaintainerBase.java)

92 lines changed: 0 ins; 53 del; 39 mod; 25 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/PackageDepsTest.java (was test/jdk/tools/jpackage/linux/base/PackageDepsBase.java)

138 lines changed: 29 ins; 87 del; 22 mod; 30 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/share/FileAssociationsTest.java

123 lines changed: 123 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/share/InstallDirTest.java

88 lines changed: 88 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/share/LicenseTest.java

142 lines changed: 142 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/RuntimePackageTest.java (was test/jdk/tools/jpackage/windows/exe/RuntimeTest.java)

31 lines changed: 9 ins; 8 del; 14 mod; 38 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/share/SimplePackageTest.java

51 lines changed: 51 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/share/manage_packages.sh

185 lines changed: 185 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinDirChooserTest.java (was test/jdk/tools/jpackage/windows/exe/WinDirChooserTest.java)

26 lines changed: 5 ins; 9 del; 12 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinMenuGroupTest.java (was test/jdk/tools/jpackage/windows/exe/WinMenuGroupTest.java)

26 lines changed: 8 ins; 9 del; 9 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinMenuTest.java (was test/jdk/tools/jpackage/windows/exe/WinMenuTest.java)

25 lines changed: 5 ins; 9 del; 11 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinPerUserInstallTest.java (was test/jdk/tools/jpackage/windows/exe/WinPerUserInstallTest.java)

30 lines changed: 9 ins; 9 del; 12 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinShortcutTest.java (was test/jdk/tools/jpackage/windows/exe/WinShortcutTest.java)

27 lines changed: 6 ins; 9 del; 12 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinUpgradeUUIDTest.java (was test/jdk/tools/jpackage/windows/exe/WinUpgradeUUIDTest.java)

41 lines changed: 19 ins; 9 del; 13 mod; 37 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/base/Base.java

114 lines changed: 0 ins; 114 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/base/FileAssociationsBase.java

151 lines changed: 0 ins; 151 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/base/InstallDirBase.java

92 lines changed: 0 ins; 92 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/base/LicenseBase.java

143 lines changed: 0 ins; 143 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/deb/BundleNameTest.java

47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/deb/FileAssociationsTest.java

47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/deb/InstallDirTest.java

47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/deb/LicenseTest.java

47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/deb/MaintainerTest.java

47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/deb/PackageDepsTest.java

47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/deb/Test.java

47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/deb/install.sh

9 lines changed: 0 ins; 9 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/deb/uninstall.sh

8 lines changed: 0 ins; 8 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/rpm/BundleNameTest.java

44 lines changed: 0 ins; 44 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/rpm/FileAssociationsTest.java

44 lines changed: 0 ins; 44 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/rpm/InstallDirTest.java

44 lines changed: 0 ins; 44 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/rpm/LicenseTest.java

44 lines changed: 0 ins; 44 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/rpm/LicenseTypeTest.java

44 lines changed: 0 ins; 44 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/rpm/PackageDepsTest.java

44 lines changed: 0 ins; 44 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/rpm/Test.java

44 lines changed: 0 ins; 44 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/rpm/install.sh

9 lines changed: 0 ins; 9 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/linux/rpm/uninstall.sh

8 lines changed: 0 ins; 8 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/base/Base.java

91 lines changed: 0 ins; 91 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/base/FileAssociationsBase.java

179 lines changed: 0 ins; 179 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/base/InstallDirBase.java

101 lines changed: 0 ins; 101 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/base/LicenseBase.java

92 lines changed: 0 ins; 92 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/base/RuntimeBase.java

81 lines changed: 0 ins; 81 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/base/WinDirChooserBase.java

92 lines changed: 0 ins; 92 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/base/WinMenuBase.java

93 lines changed: 0 ins; 93 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/base/WinMenuGroupBase.java

93 lines changed: 0 ins; 93 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/base/WinPerUserInstallBase.java

94 lines changed: 0 ins; 94 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/base/WinShortcutBase.java

99 lines changed: 0 ins; 99 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/base/WinUpgradeUUIDBase.java

139 lines changed: 0 ins; 139 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/exe/FileAssociationsInstallDirTest.java

59 lines changed: 0 ins; 59 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/exe/FileAssociationsTest.java

63 lines changed: 0 ins; 63 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/exe/InstallDirTest.java

56 lines changed: 0 ins; 56 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/exe/LicenseTest.java

56 lines changed: 0 ins; 56 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/exe/Test.java

57 lines changed: 0 ins; 57 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/exe/install.bat

17 lines changed: 0 ins; 17 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/exe/uninstall.bat

14 lines changed: 0 ins; 14 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/msi/FileAssociationsInstallDirTest.java

51 lines changed: 0 ins; 51 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/msi/FileAssociationsTest.java

49 lines changed: 0 ins; 49 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/msi/InstallDirTest.java

47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/msi/LicenseTest.java

47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/msi/RuntimeTest.java

50 lines changed: 0 ins; 50 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/msi/Test.java

47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/msi/WinDirChooserTest.java

47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/msi/WinMenuGroupTest.java

47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/msi/WinMenuTest.java

47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/msi/WinPerUserInstallTest.java

47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/msi/WinShortcutTest.java

47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/msi/WinUpgradeUUIDTest.java

47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/msi/install.bat

17 lines changed: 0 ins; 17 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/windows/msi/uninstall.bat

14 lines changed: 0 ins; 14 del; 0 mod; 0 unchg

This code review page was prepared using /cygdrive/c/ade/work/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).