Code Review for open

Prepared by: U-ASEMENYU-LAPsemenyu (ASEMENYU-LAP+asemenyu) on Mon Sep 30 10:42:42 EDT 2019
Workspace:/cygdrive/c/ade/work/as/jds/work/10_sandbox/jdk10/open
Branch:JDK-8200758-branch
Summary of changes: 4639 lines changed: 2357 ins; 1874 del; 408 mod; 5051 unchg
Patch of changes: open.patch
Bug id: JDK-8231605 : Improve test helpers
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxAppImageBuilder.java

3 lines changed: 0 ins; 0 del; 3 mod; 201 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxPackageBundler.java

1 line changed: 0 ins; 0 del; 1 mod; 711 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/ApplicationLayout.java

37 lines changed: 23 ins; 0 del; 14 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/Platform.java

12 lines changed: 12 ins; 0 del; 0 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/CommandArguments.java

8 lines changed: 6 ins; 1 del; 1 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Executor.java

197 lines changed: 130 ins; 15 del; 52 mod; 176 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/FileAssociations.java

2 lines changed: 0 ins; 0 del; 2 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Functional.java

14 lines changed: 13 ins; 1 del; 0 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/HelloApp.java

256 lines changed: 197 ins; 27 del; 32 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JPackageCommand.java

228 lines changed: 146 ins; 22 del; 60 mod; 439 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JarBuilder.java

20 lines changed: 5 ins; 9 del; 6 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JavaTool.java

20 lines changed: 8 ins; 3 del; 9 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/LinuxHelper.java

97 lines changed: 48 ins; 14 del; 35 mod; 266 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/MacHelper.java

6 lines changed: 5 ins; 0 del; 1 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageTest.java

77 lines changed: 19 ins; 30 del; 28 mod; 380 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageType.java

32 lines changed: 1 ins; 17 del; 14 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/WindowsHelper.java

27 lines changed: 11 ins; 2 del; 14 mod; 228 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/junit/jdk/jpackage/internal/ApplicationLayoutTest.java

1 line changed: 0 ins; 0 del; 1 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/AppCategoryTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/LicenseTypeTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/LinuxBundleNameTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/MaintainerTest.java

4 lines changed: 1 ins; 0 del; 3 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/PackageDepsTest.java

25 lines changed: 11 ins; 11 del; 3 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/ReleaseTest.java

4 lines changed: 1 ins; 0 del; 3 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/ShortcutHintTest.java

39 lines changed: 2 ins; 12 del; 25 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/AdditionalLaunchersTest.java

8 lines changed: 1 ins; 0 del; 7 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/AppImagePackageTest.java

4 lines changed: 1 ins; 0 del; 3 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/ArgumentsTest.java

65 lines changed: 46 ins; 11 del; 8 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/FileAssociationsTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/IconTest.java

92 lines changed: 11 ins; 60 del; 21 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/InstallDirTest.java

31 lines changed: 11 ins; 14 del; 6 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/LicenseTest.java

27 lines changed: 5 ins; 8 del; 14 mod; 257 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/RuntimePackageTest.java

4 lines changed: 1 ins; 0 del; 3 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/SimplePackageTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinConsoleTest.java

35 lines changed: 10 ins; 8 del; 17 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinDirChooserTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinMenuGroupTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinMenuTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinPerUserInstallTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinShortcutTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/WinUpgradeUUIDTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 70 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Annotations.java

52 lines changed: 52 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Main.java

97 lines changed: 97 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/MethodCall.java

62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TKit.java

652 lines changed: 652 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TestBuilder.java

344 lines changed: 344 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TestInstance.java

160 lines changed: 160 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/tools/jpackage/share/jdk/jpackage/tests/BasicTest.java

254 lines changed: 254 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Test.java

554 lines changed: 0 ins; 554 del; 0 mod; -1 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/share/ArgumentsBase.java

121 lines changed: 0 ins; 121 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/share/ArgumentsModuleTest.java

52 lines changed: 0 ins; 52 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/share/AtFilenameTest.java

64 lines changed: 0 ins; 64 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/share/JLinkModuleTest.java

68 lines changed: 0 ins; 68 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/share/ModularJarTest.java

67 lines changed: 0 ins; 67 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/share/ModuleTest.java

76 lines changed: 0 ins; 76 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/share/NoArgTest.java

78 lines changed: 0 ins; 78 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/share/NoNameTest.java

98 lines changed: 0 ins; 98 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/share/RuntimeBase.java

97 lines changed: 0 ins; 97 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/share/RuntimeModuleTest.java

52 lines changed: 0 ins; 52 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/share/RuntimeTest.java

54 lines changed: 0 ins; 54 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/share/TempRootTest.java

108 lines changed: 0 ins; 108 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/share/Test.java

53 lines changed: 0 ins; 53 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/tools/jpackage/share/VersionTest.java

67 lines changed: 0 ins; 67 del; 0 mod; 0 unchg

This code review page was prepared using /cygdrive/c/ade/work/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).