test/java/math/BigDecimal/CompareToTests.java

Print this page
rev 7751 : 8022094: BigDecimal/CompareToTests and BigInteger/CompareToTests are incorrect
Summary: Fail test if errors; fix test values; port BigDecimal version to BigInteger
Reviewed-by: smarks
Contributed-by: Brian Burkhalter <brian.burkhalter@oracle.com>


  37         final BigDecimal MINUS_ONE = BigDecimal.ONE.negate();
  38 
  39         // First operand, second operand, expected compareTo result
  40         BigDecimal [][] testCases = {
  41             // Basics
  42             {valueOf(0),        valueOf(0),     ZERO},
  43             {valueOf(0),        valueOf(1),     MINUS_ONE},
  44             {valueOf(1),        valueOf(2),     MINUS_ONE},
  45             {valueOf(2),        valueOf(1),     ONE},
  46             {valueOf(10),       valueOf(10),    ZERO},
  47 
  48             // Significands would compare differently than scaled value
  49             {valueOf(2,1),      valueOf(2),     MINUS_ONE},
  50             {valueOf(2,-1),     valueOf(2),     ONE},
  51             {valueOf(1,1),      valueOf(2),     MINUS_ONE},
  52             {valueOf(1,-1),     valueOf(2),     ONE},
  53             {valueOf(5,-1),     valueOf(2),     ONE},
  54 
  55             // Boundary and near boundary values
  56             {valueOf(Long.MAX_VALUE),   valueOf(Long.MAX_VALUE),        ZERO},


  57             {valueOf(Long.MAX_VALUE-1), valueOf(Long.MAX_VALUE),        MINUS_ONE},


  58             {valueOf(Long.MIN_VALUE),   valueOf(Long.MAX_VALUE),        MINUS_ONE},


  59             {valueOf(Long.MIN_VALUE+1), valueOf(Long.MAX_VALUE),        MINUS_ONE},








  60             {valueOf(Long.MIN_VALUE),   valueOf(Long.MIN_VALUE),        ZERO},
  61             {valueOf(Long.MIN_VALUE+1), valueOf(Long.MAX_VALUE),        ONE},



  62         };
  63 
  64         for (BigDecimal[] testCase : testCases) {
  65             BigDecimal a = testCase[0];
  66             BigDecimal a_negate = a.negate();
  67             BigDecimal b = testCase[1];
  68             BigDecimal b_negate = b.negate();
  69             int expected = testCase[2].intValue();
  70 
  71             failures += compareToTest(a,        b,         expected);
  72             failures += compareToTest(a_negate, b,        -1);
  73             failures += compareToTest(a,        b_negate,  1);
  74             failures += compareToTest(a_negate, b_negate, -expected);
  75         }
  76 
  77 
  78         return failures;
  79     }
  80 
  81     private static int compareToTest(BigDecimal a, BigDecimal b, int expected) {
  82         int result = a.compareTo(b);
  83         int failed = (result==expected) ? 0 : 1;
  84         if (result == 1) {
  85             System.err.println("(" + a + ").compareTo(" + b + ") => " + result +
  86                                "\n\tExpected " + expected);
  87         }
  88         return result;
  89     }
  90 
  91     public static void main(String argv[]) {
  92         int failures = 0;
  93 
  94         failures += compareToTests();
  95 
  96         if (failures > 0) {
  97             throw new RuntimeException("Incurred " + failures +
  98                                        " failures while testing exact compareTo.");
  99         }
 100     }
 101 }


  37         final BigDecimal MINUS_ONE = BigDecimal.ONE.negate();
  38 
  39         // First operand, second operand, expected compareTo result
  40         BigDecimal [][] testCases = {
  41             // Basics
  42             {valueOf(0),        valueOf(0),     ZERO},
  43             {valueOf(0),        valueOf(1),     MINUS_ONE},
  44             {valueOf(1),        valueOf(2),     MINUS_ONE},
  45             {valueOf(2),        valueOf(1),     ONE},
  46             {valueOf(10),       valueOf(10),    ZERO},
  47 
  48             // Significands would compare differently than scaled value
  49             {valueOf(2,1),      valueOf(2),     MINUS_ONE},
  50             {valueOf(2,-1),     valueOf(2),     ONE},
  51             {valueOf(1,1),      valueOf(2),     MINUS_ONE},
  52             {valueOf(1,-1),     valueOf(2),     ONE},
  53             {valueOf(5,-1),     valueOf(2),     ONE},
  54 
  55             // Boundary and near boundary values
  56             {valueOf(Long.MAX_VALUE),            valueOf(Long.MAX_VALUE), ZERO},
  57             {valueOf(Long.MAX_VALUE).negate(),   valueOf(Long.MAX_VALUE), MINUS_ONE},
  58 
  59             {valueOf(Long.MAX_VALUE-1),          valueOf(Long.MAX_VALUE), MINUS_ONE},
  60             {valueOf(Long.MAX_VALUE-1).negate(), valueOf(Long.MAX_VALUE), MINUS_ONE},
  61 
  62             {valueOf(Long.MIN_VALUE),            valueOf(Long.MAX_VALUE), MINUS_ONE},
  63             {valueOf(Long.MIN_VALUE).negate(),   valueOf(Long.MAX_VALUE), ONE},
  64 
  65             {valueOf(Long.MIN_VALUE+1),          valueOf(Long.MAX_VALUE), MINUS_ONE},
  66             {valueOf(Long.MIN_VALUE+1).negate(), valueOf(Long.MAX_VALUE), ZERO},
  67 
  68             {valueOf(Long.MAX_VALUE),            valueOf(Long.MIN_VALUE), ONE},
  69             {valueOf(Long.MAX_VALUE).negate(),   valueOf(Long.MIN_VALUE), ONE},
  70 
  71             {valueOf(Long.MAX_VALUE-1),          valueOf(Long.MIN_VALUE), ONE},
  72             {valueOf(Long.MAX_VALUE-1).negate(), valueOf(Long.MIN_VALUE), ONE},
  73 
  74             {valueOf(Long.MIN_VALUE),            valueOf(Long.MIN_VALUE), ZERO},
  75             {valueOf(Long.MIN_VALUE).negate(),   valueOf(Long.MIN_VALUE), ONE},
  76 
  77             {valueOf(Long.MIN_VALUE+1),          valueOf(Long.MIN_VALUE), ONE},
  78             {valueOf(Long.MIN_VALUE+1).negate(), valueOf(Long.MIN_VALUE), ONE},
  79         };
  80 
  81         for (BigDecimal[] testCase : testCases) {
  82             BigDecimal a = testCase[0];
  83             BigDecimal a_negate = a.negate();
  84             BigDecimal b = testCase[1];
  85             BigDecimal b_negate = b.negate();
  86             int expected = testCase[2].intValue();
  87 
  88             failures += compareToTest(a,        b,         expected);


  89             failures += compareToTest(a_negate, b_negate, -expected);
  90         }
  91 
  92 
  93         return failures;
  94     }
  95 
  96     private static int compareToTest(BigDecimal a, BigDecimal b, int expected) {
  97         int result = a.compareTo(b);
  98         int failed = (result==expected) ? 0 : 1;
  99         if (failed == 1) {
 100             System.err.println("(" + a + ").compareTo(" + b + ") => " + result +
 101                                "\n\tExpected " + expected);
 102         }
 103         return failed;
 104     }
 105 
 106     public static void main(String argv[]) {
 107         int failures = 0;
 108 
 109         failures += compareToTests();
 110 
 111         if (failures > 0) {
 112             throw new RuntimeException("Incurred " + failures +
 113                                        " failures while testing exact compareTo.");
 114         }
 115     }
 116 }