Code Review for jdk

Prepared by:bpb on Thu Oct 3 16:48:38 PDT 2013
Workspace:/Users/bpb/Work/JSL/jdk/jdk8/tl8/jdk
Compare against: http://hg.openjdk.java.net/jdk8/tl/jdk
Compare against version:8142
Summary of changes: 867 lines changed: 815 ins; 10 del; 42 mod; 6546 unchg
Changeset: jdk.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/math/BigInteger.java

rev 8143 : 8021203: BigInteger.doubleValue/floatValue returns 0.0 instead of Infinity
8021204: Constructor BigInteger(String val, int radix) doesn't detect overflow
8022780: Incorrect BigInteger division because of MutableBigInteger.bitLength() overflow
6910473: java.math.BigInteger.bitLength() may return negative "int" on large numbers
Summary: Prevent construction of overflowed BigIntegers.
Reviewed-by: bpb
Contributed-by: Dmitry Nadezhin <dmitry.nadezhin@oracle.com>
178 lines changed: 135 ins; 10 del; 33 mod; 4270 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/java/math/MutableBigInteger.java

rev 8143 : 8021203: BigInteger.doubleValue/floatValue returns 0.0 instead of Infinity
8021204: Constructor BigInteger(String val, int radix) doesn't detect overflow
8022780: Incorrect BigInteger division because of MutableBigInteger.bitLength() overflow
6910473: java.math.BigInteger.bitLength() may return negative "int" on large numbers
Summary: Prevent construction of overflowed BigIntegers.
Reviewed-by: bpb
Contributed-by: Dmitry Nadezhin <dmitry.nadezhin@oracle.com>
5 lines changed: 0 ins; 0 del; 5 mod; 2232 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/math/BigInteger/ExtremeShiftingTests.java

rev 8143 : 8021203: BigInteger.doubleValue/floatValue returns 0.0 instead of Infinity
8021204: Constructor BigInteger(String val, int radix) doesn't detect overflow
8022780: Incorrect BigInteger division because of MutableBigInteger.bitLength() overflow
6910473: java.math.BigInteger.bitLength() may return negative "int" on large numbers
Summary: Prevent construction of overflowed BigIntegers.
Reviewed-by: bpb
Contributed-by: Dmitry Nadezhin <dmitry.nadezhin@oracle.com>
23 lines changed: 19 ins; 0 del; 4 mod; 44 unchg

------ ------ ------ ------ --- New ----- Raw test/java/math/BigInteger/SymmetricRangeTests.java

rev 8143 : 8021203: BigInteger.doubleValue/floatValue returns 0.0 instead of Infinity
8021204: Constructor BigInteger(String val, int radix) doesn't detect overflow
8022780: Incorrect BigInteger division because of MutableBigInteger.bitLength() overflow
6910473: java.math.BigInteger.bitLength() may return negative "int" on large numbers
Summary: Prevent construction of overflowed BigIntegers.
Reviewed-by: bpb
Contributed-by: Dmitry Nadezhin <dmitry.nadezhin@oracle.com>
661 lines changed: 661 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ../make/scripts/webrev.ksh (vers 24.1-hg+openjdk.java.net).