Code Review for langtools

Prepared by:briangoetz on Mon Dec 16 17:21:17 EST 2013
Workspace:/home2/brian/jdk9/langtools
Compare against: http://hg.openjdk.java.net/jdk9/dev/langtools
Compare against version:2221
Summary of changes: 953 lines changed: 34 ins; 226 del; 693 mod; 51792 unchg
Changeset: langtools.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/classfile/Attributes.java

2 lines changed: 0 ins; 1 del; 1 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/classfile/ClassWriter.java

rev 2222 : [mq]: twr+multicatch
4 lines changed: 0 ins; 3 del; 1 mod; 807 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java

6 lines changed: 0 ins; 0 del; 6 mod; 304 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java

5 lines changed: 0 ins; 1 del; 4 mod; 272 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java

8 lines changed: 0 ins; 1 del; 7 mod; 177 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java

4 lines changed: 0 ins; 0 del; 4 mod; 167 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java

16 lines changed: 0 ins; 5 del; 11 mod; 502 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java

7 lines changed: 0 ins; 1 del; 6 mod; 709 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java

9 lines changed: 0 ins; 1 del; 8 mod; 588 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java

3 lines changed: 0 ins; 1 del; 2 mod; 321 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java

19 lines changed: 0 ins; 1 del; 18 mod; 2127 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java

2 lines changed: 0 ins; 1 del; 1 mod; 427 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java

10 lines changed: 1 ins; 2 del; 7 mod; 186 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java

4 lines changed: 0 ins; 0 del; 4 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java

5 lines changed: 0 ins; 1 del; 4 mod; 262 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java

14 lines changed: 0 ins; 5 del; 9 mod; 305 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageFrameWriter.java

9 lines changed: 1 ins; 0 del; 8 mod; 178 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/formats/html/ProfilePackageIndexFrameWriter.java

3 lines changed: 0 ins; 0 del; 3 mod; 197 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java

20 lines changed: 0 ins; 9 del; 11 mod; 279 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java

2 lines changed: 0 ins; 0 del; 2 mod; 313 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 351 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java

3 lines changed: 0 ins; 2 del; 1 mod; 866 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java

5 lines changed: 0 ins; 1 del; 4 mod; 204 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java

45 lines changed: 2 ins; 5 del; 38 mod; 945 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstantsSummaryBuilder.java

27 lines changed: 0 ins; 5 del; 22 mod; 359 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstructorBuilder.java

3 lines changed: 0 ins; 1 del; 2 mod; 229 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java

8 lines changed: 0 ins; 2 del; 6 mod; 524 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ProfileSummaryBuilder.java

2 lines changed: 0 ins; 0 del; 2 mod; 326 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java

16 lines changed: 0 ins; 2 del; 14 mod; 578 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java

18 lines changed: 0 ins; 1 del; 17 mod; 306 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SimpleTaglet.java

7 lines changed: 0 ins; 0 del; 7 mod; 224 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java

14 lines changed: 0 ins; 1 del; 13 mod; 746 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java

14 lines changed: 0 ins; 0 del; 14 mod; 296 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ThrowsTaglet.java

28 lines changed: 0 ins; 2 del; 26 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ValueTaglet.java

4 lines changed: 0 ins; 1 del; 3 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassDocCatalog.java

2 lines changed: 0 ins; 0 del; 2 mod; 282 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassTree.java

24 lines changed: 0 ins; 1 del; 23 mod; 363 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassUseMapper.java

64 lines changed: 0 ins; 11 del; 53 mod; 430 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DeprecatedAPIListBuilder.java

10 lines changed: 0 ins; 4 del; 6 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFile.java

rev 2222 : [mq]: twr+multicatch
25 lines changed: 1 ins; 14 del; 10 mod; 235 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFinder.java

2 lines changed: 0 ins; 0 del; 2 mod; 242 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Extern.java

rev 2222 : [mq]: twr+multicatch
4 lines changed: 0 ins; 1 del; 3 mod; 312 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Group.java

4 lines changed: 0 ins; 2 del; 2 mod; 243 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ImplementedMethods.java

4 lines changed: 0 ins; 2 del; 2 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/util/IndexBuilder.java

16 lines changed: 0 ins; 1 del; 15 mod; 246 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MetaKeywords.java

4 lines changed: 0 ins; 1 del; 3 mod; 155 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MethodFinder.java

3 lines changed: 0 ins; 0 del; 3 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/util/PackageListWriter.java

6 lines changed: 0 ins; 1 del; 5 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java

61 lines changed: 2 ins; 11 del; 48 mod; 732 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclets/internal/toolkit/util/VisibleMemberMap.java

36 lines changed: 1 ins; 9 del; 26 mod; 740 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/doclint/DocLint.java

2 lines changed: 0 ins; 1 del; 1 mod; 377 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/api/ClientCodeWrapper.java

rev 2222 : [mq]: twr+multicatch
87 lines changed: 0 ins; 58 del; 29 mod; 611 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/code/Type.java

rev 2222 : [mq]: twr+multicatch
3 lines changed: 0 ins; 0 del; 3 mod; 2026 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/comp/Lower.java

rev 2222 : [mq]: twr+multicatch
1 line changed: 0 ins; 0 del; 1 mod; 3954 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/file/FSInfo.java

rev 2222 : [mq]: twr+multicatch
6 lines changed: 1 ins; 3 del; 2 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/file/RegularFileObject.java

rev 2222 : [mq]: twr+multicatch
4 lines changed: 0 ins; 3 del; 1 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/file/ZipArchive.java

rev 2222 : [mq]: twr+multicatch
4 lines changed: 0 ins; 3 del; 1 mod; 284 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java

rev 2222 : [mq]: twr+multicatch
2 lines changed: 0 ins; 0 del; 2 mod; 1167 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/file/ZipFileIndexArchive.java

rev 2222 : [mq]: twr+multicatch
4 lines changed: 0 ins; 3 del; 1 mod; 250 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/file/ZipFileIndexCache.java

rev 2222 : [mq]: twr+multicatch
4 lines changed: 0 ins; 2 del; 2 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/jvm/ClassReader.java

rev 2222 : [mq]: twr+multicatch
3 lines changed: 0 ins; 0 del; 3 mod; 2944 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/jvm/Gen.java

rev 2222 : [mq]: twr+multicatch
2 lines changed: 0 ins; 0 del; 2 mod; 2916 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/jvm/JNIWriter.java

30 lines changed: 3 ins; 0 del; 27 mod; 829 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/main/CommandLine.java

14 lines changed: 1 ins; 2 del; 11 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/main/JavaCompiler.java

rev 2222 : [mq]: twr+multicatch
4 lines changed: 0 ins; 3 del; 1 mod; 1758 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/main/Main.java

rev 2222 : [mq]: twr+multicatch
8 lines changed: 0 ins; 5 del; 3 mod; 691 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/nio/PathFileObject.java

rev 2222 : [mq]: twr+multicatch
4 lines changed: 0 ins; 3 del; 1 mod; 314 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/parser/JavacParser.java

rev 2222 : [mq]: twr+multicatch
4 lines changed: 0 ins; 0 del; 4 mod; 4157 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/sym/CreateSymbols.java

rev 2222 : [mq]: twr+multicatch
3 lines changed: 0 ins; 2 del; 1 mod; 516 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/sym/Profiles.java

rev 2222 : [mq]: twr+multicatch
9 lines changed: 0 ins; 6 del; 3 mod; 288 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java

1 line changed: 0 ins; 0 del; 1 mod; 411 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/util/Convert.java

4 lines changed: 0 ins; 0 del; 4 mod; 334 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/util/ListBuffer.java

2 lines changed: 0 ins; 0 del; 2 mod; 271 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javac/util/ServiceLoader.java

rev 2222 : [mq]: twr+multicatch
6 lines changed: 1 ins; 2 del; 3 mod; 432 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javadoc/AnnotationValueImpl.java

rev 2222 : [mq]: twr+multicatch
2 lines changed: 0 ins; 1 del; 1 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java

6 lines changed: 0 ins; 2 del; 4 mod; 1336 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javadoc/Comment.java

rev 2223 : imported patch stringswitch+indexOf
33 lines changed: 10 ins; 0 del; 23 mod; 427 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javadoc/DocLocale.java

9 lines changed: 0 ins; 2 del; 7 mod; 234 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javadoc/DocletInvoker.java

rev 2222 : [mq]: twr+multicatch
7 lines changed: 0 ins; 3 del; 4 mod; 332 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java

rev 2222 : [mq]: twr+multicatch
1 line changed: 0 ins; 0 del; 1 mod; 278 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javadoc/SeeTagImpl.java

3 lines changed: 0 ins; 1 del; 2 mod; 538 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javadoc/SerializedForm.java

9 lines changed: 1 ins; 2 del; 6 mod; 282 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javah/JavahTool.java

4 lines changed: 0 ins; 1 del; 3 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javah/LLNI.java

rev 2222 : [mq]: twr+multicatch
1 line changed: 0 ins; 0 del; 1 mod; 679 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javah/TypeSignature.java

28 lines changed: 3 ins; 0 del; 25 mod; 253 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javap/AnnotationWriter.java

rev 2222 : [mq]: twr+multicatch
2 lines changed: 0 ins; 1 del; 1 mod; 290 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javap/JavapTask.java

rev 2222 : [mq]: twr+multicatch
2 lines changed: 0 ins; 1 del; 1 mod; 1053 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/javap/StackMapWriter.java

rev 2222 : [mq]: twr+multicatch
3 lines changed: 0 ins; 2 del; 1 mod; 288 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/sjavac/Log.java

rev 2223 : imported patch stringswitch+indexOf
8 lines changed: 3 ins; 0 del; 5 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/com/sun/tools/sjavac/Main.java

3 lines changed: 1 ins; 0 del; 2 mod; 967 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/share/classes/javax/lang/model/SourceVersion.java

rev 2223 : imported patch stringswitch+indexOf
8 lines changed: 2 ins; 0 del; 6 mod; 269 unchg

This code review page was prepared using /home/brian/bin/webrev (vers 23.18-hg+jbs).