Code Review for hsx24-atomic

Prepared by:brutisso on Tue Feb 19 11:00:19 CET 2013
Workspace:/Users/brutisso/repos/hsx24-atomic
Compare against: http://hg.openjdk.java.net/hsx/hsx24/hotspot
Compare against version:4212
Summary of changes: 7 lines changed: 1 ins; 4 del; 2 mod; 9841 unchg
Patch of changes: hsx24-atomic.patch
Bug id: Bug Database
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp

rev 4213 : 8008382: Remove redundant use of Atomic::add(jlong, jlong *) in create_new_gc_id()
Summary: There is no need to use atomics in create_new_gc_id() since it is not called by multiple threads in parallel. Also, Atomic::add(jlong, jlong *) is broken for ARM.
Reviewed-by:
3 lines changed: 0 ins; 3 del; 0 mod; 9392 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp

rev 4213 : 8008382: Remove redundant use of Atomic::add(jlong, jlong *) in create_new_gc_id()
Summary: There is no need to use atomics in create_new_gc_id() since it is not called by multiple threads in parallel. Also, Atomic::add(jlong, jlong *) is broken for ARM.
Reviewed-by:
1 line changed: 1 ins; 0 del; 0 mod; 309 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/shared/gcTrace.cpp

rev 4213 : 8008382: Remove redundant use of Atomic::add(jlong, jlong *) in create_new_gc_id()
Summary: There is no need to use atomics in create_new_gc_id() since it is not called by multiple threads in parallel. Also, Atomic::add(jlong, jlong *) is broken for ARM.
Reviewed-by:
3 lines changed: 0 ins; 1 del; 2 mod; 140 unchg

This code review page was prepared using /Users/brutisso/tools/tom-webrev (vers 23.18-hg-never-dev).