Code Review for rt

Prepared by:cbensen on Mon Apr 11 15:30:10 PDT 2016
Workspace:/Users/cbensen/source/pull/jdk9/fx9udev/rt
Compare against: ssh://hg.openjdk.java.net/openjfx/9-dev/rt
Summary of changes: 7348 lines changed: 7164 ins; 79 del; 105 mod; 11981 unchg
Patch of changes: rt.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/javafx/main/Main.java

3 lines changed: 1 ins; 1 del; 1 mod; 1019 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/Bundlers.java

1 line changed: 1 ins; 0 del; 0 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/IOUtils.java

1 line changed: 0 ins; 0 del; 1 mod; 208 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/JDepHelper.java

17 lines changed: 1 ins; 14 del; 2 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/JLinkBundlerHelper.java

156 lines changed: 116 ins; 15 del; 25 mod; 288 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/jnlp/JNLPBundler.java

4 lines changed: 0 ins; 3 del; 1 mod; 1361 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/linux/LinuxAppBundler.java

2 lines changed: 1 ins; 0 del; 1 mod; 249 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/mac/MacAppBundler.java

2 lines changed: 1 ins; 0 del; 1 mod; 440 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/mac/MacAppStoreBundler.java

2 lines changed: 1 ins; 0 del; 1 mod; 342 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/mac/MacBaseInstallerBundler.java

2 lines changed: 1 ins; 0 del; 1 mod; 281 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/mac/MacDaemonBundler.java

2 lines changed: 1 ins; 0 del; 1 mod; 272 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/windows/WinAppBundler.java

2 lines changed: 1 ins; 0 del; 1 mod; 268 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/windows/WinServiceBundler.java

2 lines changed: 1 ins; 0 del; 1 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/ant/Application.java

32 lines changed: 32 ins; 0 del; 0 mod; 292 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/ant/DeployFXTask.java

4 lines changed: 2 ins; 0 del; 2 mod; 659 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/ant/FileAssociation.java

4 lines changed: 0 ins; 3 del; 1 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/ant/SecondaryLauncher.java

4 lines changed: 0 ins; 3 del; 1 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/CreateJarParams.java

1 line changed: 0 ins; 1 del; 0 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/DeployParams.java

8 lines changed: 6 ins; 0 del; 2 mod; 773 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/Main.java

2 lines changed: 2 ins; 0 del; 0 mod; 609 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/PackagerLib.java

3 lines changed: 1 ins; 1 del; 1 mod; 955 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/com/sun/javafx/tools/packager/bundlers/BundleParams.java

12 lines changed: 6 ins; 3 del; 3 mod; 590 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/jdk/packager/builders/linux/LinuxAppImageBuilder.java

2 lines changed: 1 ins; 1 del; 0 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/jdk/packager/builders/mac/MacAppImageBuilder.java

1 line changed: 1 ins; 0 del; 0 mod; 873 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/java/jdk/packager/builders/windows/WindowsAppImageBuilder.java

1 line changed: 1 ins; 0 del; 0 mod; 458 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/module-info/module-info.java

1 line changed: 1 ins; 0 del; 0 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/javapackager/shell/javapackager

78 lines changed: 46 ins; 20 del; 12 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/javapackager/win/javapackager.cpp

110 lines changed: 65 ins; 13 del; 32 mod; 443 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/native/library/common/IniFile.cpp

14 lines changed: 1 ins; 1 del; 12 mod; 245 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/fxpackager/src/main/resources/com/oracle/tools/packager/JLinkBundlerHelper.properties

5 lines changed: 3 ins; 0 del; 2 mod; 21 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/main/java/com/oracle/tools/packager/Platform.java

77 lines changed: 77 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/build.xml

53 lines changed: 53 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/lib/nblibraries.properties

0 lines changed: 0 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/manifest.mf

3 lines changed: 3 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/nbproject/build-impl.xml

1474 lines changed: 1474 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/nbproject/configs/Run_as_WebStart.properties

2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/nbproject/configs/Run_in_Browser.properties

2 lines changed: 2 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/nbproject/genfiles.properties

8 lines changed: 8 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/nbproject/jfx-impl.xml

4007 lines changed: 4007 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/nbproject/project.properties

113 lines changed: 113 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/nbproject/project.xml

29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/minesweeperfx/Board.java

297 lines changed: 297 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/minesweeperfx/Game.java

205 lines changed: 205 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/minesweeperfx/Globals.java

37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/minesweeperfx/Location.java

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/minesweeperfx/MinesweeperFX.java

134 lines changed: 134 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/minesweeperfx/Point.java

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/minesweeperfx/Rectangle.java

60 lines changed: 60 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/minesweeperfx/Resources.java

103 lines changed: 103 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/minesweeperfx/Tile.java

180 lines changed: 180 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/MinesweeperFX.png

Unexpected Error occurred reading `diff -e /dev/null new/modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/MinesweeperFX.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/blank.png

Unexpected Error occurred reading `diff -e /dev/null new/modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/blank.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/blankover.png

Unexpected Error occurred reading `diff -e /dev/null new/modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/blankover.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/exposed.png

Unexpected Error occurred reading `diff -e /dev/null new/modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/exposed.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/flag.png

Unexpected Error occurred reading `diff -e /dev/null new/modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/flag.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/hitmine.png

Unexpected Error occurred reading `diff -e /dev/null new/modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/hitmine.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/mine.png

Unexpected Error occurred reading `diff -e /dev/null new/modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/mine.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/number1.png

Unexpected Error occurred reading `diff -e /dev/null new/modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/number1.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/number2.png

Unexpected Error occurred reading `diff -e /dev/null new/modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/number2.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/number3.png

Unexpected Error occurred reading `diff -e /dev/null new/modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/number3.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/number4.png

Unexpected Error occurred reading `diff -e /dev/null new/modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/number4.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/number5.png

Unexpected Error occurred reading `diff -e /dev/null new/modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/number5.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/number6.png

Unexpected Error occurred reading `diff -e /dev/null new/modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/number6.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/number7.png

Unexpected Error occurred reading `diff -e /dev/null new/modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/number7.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/number8.png

Unexpected Error occurred reading `diff -e /dev/null new/modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/number8.png`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/wrongmine.png

Unexpected Error occurred reading `diff -e /dev/null new/modules/fxpackager/src/test/apps/MinesweeperFX/src/resources/wrongmine.png`: $?=0, err= 1

This code review page was prepared using /Users/cbensen/bin/webrev.ksh (vers 25.6-hg+openjdk.java.net).