Code Review for rt

Prepared by:cbensen on Tue Aug 15 12:39:19 PDT 2017
Workspace:/Users/cbensen/source/pull/jdk10/fx10dev/rt
Compare against: ssh://hg.openjdk.java.net/openjfx/10-dev/rt
Summary of changes: 7238 lines changed: 3608 ins; 3608 del; 22 mod; 7177 unchg
Patch of changes: rt.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/jdk.packager/src/main/java/com/oracle/tools/packager/AbstractImageBundler.java

1 line changed: 0 ins; 0 del; 1 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/jdk.packager/src/main/java/com/oracle/tools/packager/StandardBundlerParam.java

3 lines changed: 0 ins; 0 del; 3 mod; 962 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/jdk.packager/src/main/java/com/oracle/tools/packager/jnlp/JNLPBundler.java

1 line changed: 0 ins; 0 del; 1 mod; 1363 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/jdk.packager/src/main/java/com/oracle/tools/packager/linux/LinuxAppBundler.java

3 lines changed: 0 ins; 0 del; 3 mod; 253 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/jdk.packager/src/main/java/com/oracle/tools/packager/mac/MacAppBundler.java

4 lines changed: 0 ins; 0 del; 4 mod; 453 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/jdk.packager/src/main/java/com/oracle/tools/packager/mac/MacAppStoreBundler.java

2 lines changed: 0 ins; 0 del; 2 mod; 369 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/jdk.packager/src/main/java/com/oracle/tools/packager/mac/MacPkgBundler.java

1 line changed: 0 ins; 0 del; 1 mod; 577 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/jdk.packager/src/main/java/com/oracle/tools/packager/windows/WinAppBundler.java

3 lines changed: 0 ins; 0 del; 3 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/jdk.packager/src/main/java/com/oracle/tools/packager/windows/WinExeBundler.java

1 line changed: 0 ins; 0 del; 1 mod; 722 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/jdk.packager/src/main/java/com/sun/javafx/tools/packager/DeployParams.java

1 line changed: 0 ins; 0 del; 1 mod; 860 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/jdk.packager/src/main/java/com/sun/javafx/tools/packager/Main.java

1 line changed: 0 ins; 0 del; 1 mod; 615 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/jdk.packager/src/main/java/com/sun/javafx/tools/packager/bundlers/BundleParams.java

1 line changed: 0 ins; 0 del; 1 mod; 603 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/java/jdk/packager/internal/legacy/JDepHelper.java

113 lines changed: 113 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/java/jdk/packager/internal/legacy/JLinkBundlerHelper.java

498 lines changed: 498 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/java/jdk/packager/internal/legacy/Module.java

123 lines changed: 123 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/java/jdk/packager/internal/legacy/ModuleManager.java

121 lines changed: 121 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/java/jdk/packager/internal/legacy/RedistributableModules.java

146 lines changed: 146 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/java/jdk/packager/internal/legacy/builders/AbstractAppImageBuilder.java

324 lines changed: 324 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/java/jdk/packager/internal/legacy/builders/linux/LinuxAppImageBuilder.java

241 lines changed: 241 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/java/jdk/packager/internal/legacy/builders/mac/MacAppImageBuilder.java

874 lines changed: 874 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/java/jdk/packager/internal/legacy/builders/windows/WindowsAppImageBuilder.java

446 lines changed: 446 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/java/jdk/packager/internal/legacy/mac/MacCertificate.java

159 lines changed: 159 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/java/jdk/packager/internal/legacy/windows/WindowsDefender.java

73 lines changed: 73 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/java/jdk/packager/internal/legacy/windows/WindowsRegistry.java

145 lines changed: 145 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/resources/jdk/packager/internal/legacy/JLinkBundlerHelper.properties

17 lines changed: 17 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/resources/jdk/packager/internal/legacy/JLinkBundlerHelper_ja.properties

17 lines changed: 17 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/resources/jdk/packager/internal/legacy/JLinkBundlerHelper_zh_CN.properties

17 lines changed: 17 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/resources/jdk/packager/internal/legacy/builders/AbstractAppImageBuilder.properties

5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/resources/jdk/packager/internal/legacy/builders/AbstractAppImageBuilder_ja.properties

5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/resources/jdk/packager/internal/legacy/builders/AbstractAppImageBuilder_zh_CN.properties

5 lines changed: 5 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/resources/jdk/packager/internal/legacy/builders/linux/LinuxAppImageBuilder.properties

4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/resources/jdk/packager/internal/legacy/builders/linux/LinuxAppImageBuilder_ja.properties

4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/resources/jdk/packager/internal/legacy/builders/linux/LinuxAppImageBuilder_zh_CN.properties

4 lines changed: 4 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/resources/jdk/packager/internal/legacy/builders/mac/MacAppImageBuilder.properties

73 lines changed: 73 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/resources/jdk/packager/internal/legacy/builders/mac/MacAppImageBuilder_ja.properties

73 lines changed: 73 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/resources/jdk/packager/internal/legacy/builders/mac/MacAppImageBuilder_zh_CN.properties

73 lines changed: 73 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/resources/jdk/packager/internal/legacy/builders/windows/WindowsAppImageBuilder.properties

16 lines changed: 16 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/resources/jdk/packager/internal/legacy/builders/windows/WindowsAppImageBuilder_ja.properties

16 lines changed: 16 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/jdk.packager/src/main/resources/jdk/packager/internal/legacy/builders/windows/WindowsAppImageBuilder_zh_CN.properties

16 lines changed: 16 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/java/jdk/packager/builders/AbstractAppImageBuilder.java

324 lines changed: 0 ins; 324 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/java/jdk/packager/builders/linux/LinuxAppImageBuilder.java

241 lines changed: 0 ins; 241 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/java/jdk/packager/builders/mac/MacAppImageBuilder.java

874 lines changed: 0 ins; 874 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/java/jdk/packager/builders/windows/WindowsAppImageBuilder.java

446 lines changed: 0 ins; 446 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/java/jdk/packager/internal/JDepHelper.java

113 lines changed: 0 ins; 113 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/java/jdk/packager/internal/JLinkBundlerHelper.java

498 lines changed: 0 ins; 498 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/java/jdk/packager/internal/Module.java

123 lines changed: 0 ins; 123 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/java/jdk/packager/internal/ModuleManager.java

121 lines changed: 0 ins; 121 del; 0 mod; -1 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/java/jdk/packager/internal/RedistributableModules.java

146 lines changed: 0 ins; 146 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/java/jdk/packager/internal/mac/MacCertificate.java

159 lines changed: 0 ins; 159 del; 0 mod; -1 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/java/jdk/packager/internal/windows/WindowsDefender.java

73 lines changed: 0 ins; 73 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/java/jdk/packager/internal/windows/WindowsRegistry.java

145 lines changed: 0 ins; 145 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/resources/jdk/packager/builders/AbstractAppImageBuilder.properties

5 lines changed: 0 ins; 5 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/resources/jdk/packager/builders/AbstractAppImageBuilder_ja.properties

5 lines changed: 0 ins; 5 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/resources/jdk/packager/builders/AbstractAppImageBuilder_zh_CN.properties

5 lines changed: 0 ins; 5 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/resources/jdk/packager/builders/linux/LinuxAppImageBuilder.properties

4 lines changed: 0 ins; 4 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/resources/jdk/packager/builders/linux/LinuxAppImageBuilder_ja.properties

4 lines changed: 0 ins; 4 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/resources/jdk/packager/builders/linux/LinuxAppImageBuilder_zh_CN.properties

4 lines changed: 0 ins; 4 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/resources/jdk/packager/builders/mac/MacAppImageBuilder.properties

73 lines changed: 0 ins; 73 del; 0 mod; -1 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/resources/jdk/packager/builders/mac/MacAppImageBuilder_ja.properties

73 lines changed: 0 ins; 73 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/resources/jdk/packager/builders/mac/MacAppImageBuilder_zh_CN.properties

73 lines changed: 0 ins; 73 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/resources/jdk/packager/builders/windows/WindowsAppImageBuilder.properties

16 lines changed: 0 ins; 16 del; 0 mod; -1 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/resources/jdk/packager/builders/windows/WindowsAppImageBuilder_ja.properties

16 lines changed: 0 ins; 16 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/resources/jdk/packager/builders/windows/WindowsAppImageBuilder_zh_CN.properties

16 lines changed: 0 ins; 16 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/resources/jdk/packager/internal/JLinkBundlerHelper.properties

17 lines changed: 0 ins; 17 del; 0 mod; -1 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/resources/jdk/packager/internal/JLinkBundlerHelper_ja.properties

17 lines changed: 0 ins; 17 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- modules/jdk.packager/src/main/resources/jdk/packager/internal/JLinkBundlerHelper_zh_CN.properties

17 lines changed: 0 ins; 17 del; 0 mod; 0 unchg

This code review page was prepared using webrev.ksh (vers 25.16-hg+openjdk.java.net).