Code Review for open

Prepared by:ccheung on Mon Apr 9 12:07:28 PDT 2018
Workspace:/scratch/ccheung/jdk10-hs-consol/open
Compare against version:qparent
Summary of changes: 2118 lines changed: 1772 ins; 109 del; 237 mod; 26008 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoader.cpp

rev 49528 : [mq]: module_path
121 lines changed: 95 ins; 4 del; 22 mod; 2065 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoader.hpp

rev 49528 : [mq]: module_path
26 lines changed: 23 ins; 0 del; 3 mod; 519 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderExt.cpp

rev 49528 : [mq]: module_path
35 lines changed: 33 ins; 0 del; 2 mod; 327 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoaderExt.hpp

rev 49528 : [mq]: module_path
23 lines changed: 14 ins; 0 del; 9 mod; 160 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/klassFactory.cpp

rev 49528 : [mq]: module_path
1 line changed: 0 ins; 0 del; 1 mod; 257 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/modules.cpp

rev 49528 : [mq]: module_path
1 line changed: 0 ins; 0 del; 1 mod; 727 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/modules.hpp

rev 49528 : [mq]: module_path
3 lines changed: 2 ins; 0 del; 1 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/sharedClassUtil.cpp

rev 49528 : [mq]: module_path
9 lines changed: 5 ins; 0 del; 4 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/sharedClassUtil.hpp

rev 49528 : [mq]: module_path
9 lines changed: 3 ins; 0 del; 6 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionary.cpp

rev 49528 : [mq]: module_path
1 line changed: 0 ins; 0 del; 1 mod; 3106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionaryShared.cpp

rev 49528 : [mq]: module_path
41 lines changed: 18 ins; 4 del; 19 mod; 1065 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/filemap.cpp

rev 49528 : [mq]: module_path
68 lines changed: 32 ins; 1 del; 35 mod; 1055 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/filemap.hpp

rev 49528 : [mq]: module_path
20 lines changed: 1 ins; 0 del; 19 mod; 282 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspaceShared.cpp

rev 49528 : [mq]: module_path
2 lines changed: 0 ins; 1 del; 1 mod; 2127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/klass.hpp

rev 49528 : [mq]: module_path
1 line changed: 0 ins; 0 del; 1 mod; 760 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/arguments.cpp

rev 49528 : [mq]: module_path
46 lines changed: 24 ins; 19 del; 3 mod; 4497 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/arguments.hpp

rev 49528 : [mq]: module_path
2 lines changed: 2 ins; 0 del; 0 mod; 715 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/thread.cpp

rev 49528 : [mq]: module_path
5 lines changed: 5 ins; 0 del; 0 mod; 5001 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/JarBuilder.java

rev 49528 : [mq]: module_path
35 lines changed: 34 ins; 0 del; 1 mod; 234 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/TestCommon.java

rev 49528 : [mq]: module_path
19 lines changed: 15 ins; 4 del; 0 mod; 343 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/CheckUnsupportedDumpingOptions.java

rev 49528 : [mq]: module_path
31 lines changed: 0 ins; 25 del; 6 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/JigsawOptionsCombo.java

rev 49528 : [mq]: module_path
28 lines changed: 9 ins; 2 del; 17 mod; 196 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/AppClassInCP.java

rev 49528 : [mq]: module_path
6 lines changed: 1 ins; 3 del; 2 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/CustomPackage.java

rev 49528 : [mq]: module_path
3 lines changed: 1 ins; 0 del; 2 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/MismatchedPatchModule.java

rev 49528 : [mq]: module_path
47 lines changed: 1 ins; 41 del; 5 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/PatchDir.java

rev 49528 : [mq]: module_path
3 lines changed: 0 ins; 0 del; 3 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/PatchJavaBase.java

rev 49528 : [mq]: module_path
2 lines changed: 1 ins; 0 del; 1 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/Simple.java

rev 49528 : [mq]: module_path
4 lines changed: 1 ins; 0 del; 3 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/SubClassOfPatchedClass.java

rev 49528 : [mq]: module_path
5 lines changed: 1 ins; 2 del; 2 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/PatchModule/TwoJars.java

rev 49528 : [mq]: module_path
3 lines changed: 1 ins; 0 del; 2 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/classpathtests/BootAppendTests.java

rev 49528 : [mq]: module_path
40 lines changed: 6 ins; 3 del; 31 mod; 222 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/classpathtests/EmptyClassInBootClassPath.java

rev 49528 : [mq]: module_path
4 lines changed: 2 ins; 0 del; 2 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/limitmods/LimitModsHelper.java

rev 49528 : [mq]: module_path
17 lines changed: 11 ins; 0 del; 6 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/limitmods/LimitModsTests.java

rev 49528 : [mq]: module_path
5 lines changed: 0 ins; 0 del; 5 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/appcds/test-classes/JvmtiApp.java

rev 49528 : [mq]: module_path
23 lines changed: 7 ins; 0 del; 16 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/modules/PatchModule/PatchModuleCDS.java

rev 49528 : [mq]: module_path
7 lines changed: 3 ins; 0 del; 4 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/cds/CDSTestUtils.java

rev 49528 : [mq]: module_path
24 lines changed: 23 ins; 0 del; 1 mod; 559 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/AddModules.java

137 lines changed: 137 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/AddOpens.java

110 lines changed: 110 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/AddReads.java

143 lines changed: 143 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/ExportModule.java

164 lines changed: 164 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/JvmtiAddPath.java

rev 49528 : [mq]: module_path
156 lines changed: 156 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/MainModuleOnly.java

177 lines changed: 177 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/ModulePathAndCP.java

186 lines changed: 186 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.greetings/com/greetings/Main.java

rev 49528 : [mq]: module_path
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.greetings/module-info.java

rev 49528 : [mq]: module_path
27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.hello/com/hello/Main.java

rev 49528 : [mq]: module_path
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.hello/module-info.java

rev 49528 : [mq]: module_path
27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.nomodule/com/nomodule/Main.java

rev 49528 : [mq]: module_path
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.norequires/com/norequires/Main.java

rev 49528 : [mq]: module_path
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.norequires/module-info.java

rev 49528 : [mq]: module_path
25 lines changed: 25 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.simple/com/simple/Main.java

rev 49528 : [mq]: module_path
39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/com.simple/module-info.java

rev 49528 : [mq]: module_path
26 lines changed: 26 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/org.astro/module-info.java

rev 49528 : [mq]: module_path
27 lines changed: 27 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/appcds/jigsaw/modulepath/src/org.astro/org/astro/World.java

rev 49528 : [mq]: module_path
30 lines changed: 30 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ../../bldenv/hg_webrev (vers 23.18-hg-never).