Code Review for jdk

Prepared by:chegar on Wed Apr 27 19:13:36 IST 2016
Workspace:/home/chhegar/repos/jdk9/dev/ssMove/jdk
Compare against: ssh://hg.openjdk.java.net/jdk9/dev/jdk
Compare against version:14281
Summary of changes: 1476 lines changed: 779 ins; 498 del; 199 mod; 6101 unchg
Changeset: jdk.changeset
Bug id: <title>[JDK-8044773] Refactor jdk.net API so that it can be moved out of the base module - Java Bug System</title>
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/mapfiles/libnet/mapfile-vers

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
4 lines changed: 0 ins; 4 del; 0 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw make/src/classes/build/tools/module/GenModuleInfoSource.java

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/module-info.java

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
4 lines changed: 2 ins; 2 del; 0 mod; 302 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/nio/ch/AsynchronousSocketChannelImpl.java

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
4 lines changed: 0 ins; 0 del; 4 mod; 604 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
4 lines changed: 0 ins; 0 del; 4 mod; 1151 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/nio/ch/Net.java

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
20 lines changed: 3 ins; 12 del; 5 mod; 644 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
5 lines changed: 0 ins; 1 del; 4 mod; 1037 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/unix/classes/java/net/PlainDatagramSocketImpl.java

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
37 lines changed: 9 ins; 21 del; 7 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/unix/classes/java/net/PlainSocketImpl.java

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
38 lines changed: 12 ins; 17 del; 9 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/java.base/unix/native/libnet/net_util_md.h

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
41 lines changed: 0 ins; 41 del; 0 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.policytool/share/classes/module-info.java

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
1 line changed: 1 ins; 0 del; 0 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/net/SocketOption/OptionsTest.java

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
22 lines changed: 18 ins; 1 del; 3 mod; 280 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/net/SocketOption/UnsupportedOptionsTest.java

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
36 lines changed: 17 ins; 3 del; 16 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/nio/channels/DatagramChannel/SocketOptionTests.java

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
3 lines changed: 2 ins; 0 del; 1 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/nio/channels/ServerSocketChannel/SocketOptionTests.java

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
3 lines changed: 2 ins; 0 del; 1 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/nio/channels/SocketChannel/SocketOptionTests.java

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
3 lines changed: 2 ins; 0 del; 1 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/jdk/net/Sockets/Test.java

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
130 lines changed: 54 ins; 43 del; 33 mod; 70 unchg

------ ------ ------ ------ --- New ----- Raw make/lib/Lib-jdk.net.gmk

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
51 lines changed: 51 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw make/mapfiles/libextnet/mapfile-vers

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/java.base/share/classes/sun/net/ext/ExtendedSocketOptions.java

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
108 lines changed: 108 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.net/share/classes/jdk/net/ExtendedSocketOptions.java (was src/java.base/share/classes/jdk/net/ExtendedSocketOptions.java)

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
152 lines changed: 151 ins; 0 del; 1 mod; 60 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.net/share/classes/jdk/net/NetworkPermission.java (was src/java.base/share/classes/jdk/net/NetworkPermission.java)

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
0 lines changed: 0 ins; 0 del; 0 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.net/share/classes/jdk/net/SocketFlow.java (was src/java.base/share/classes/jdk/net/SocketFlow.java)

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
60 lines changed: 36 ins; 3 del; 21 mod; 143 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.net/share/classes/jdk/net/Sockets.java (was src/java.base/share/classes/jdk/net/Sockets.java)

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
26 lines changed: 7 ins; 12 del; 7 mod; 320 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.net/share/classes/jdk/net/package-info.java (was src/java.base/share/classes/jdk/net/package-info.java)

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
0 lines changed: 0 ins; 0 del; 0 mod; 33 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.net/share/classes/module-info.java

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
29 lines changed: 29 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.net/solaris/classes/jdk/net/SolarisSocketOptions.java

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
56 lines changed: 56 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw src/jdk.net/solaris/native/libextnet/SolarisSocketOptions.c (was src/java.base/unix/native/libnet/ExtendedOptionsImpl.c)

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
275 lines changed: 13 ins; 181 del; 81 mod; 82 unchg

------ ------ ------ ------ --- New ----- Raw src/jdk.net/solaris/native/libextnet/SolarisSocketOptions.h

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New ----- Raw test/jdk/net/SocketFlow/SocketFlowBasic.java

rev 14282 : 8044773: Refactor jdk.net API so that it can be moved out of the base module
Reviewed-by:
93 lines changed: 93 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/java.base/share/classes/sun/net/ExtendedOptionsImpl.java

92 lines changed: 0 ins; 92 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- ----- --- src/java.base/windows/native/libnet/ExtendedOptionsImpl.c

65 lines changed: 0 ins; 65 del; 0 mod; 0 unchg

This code review page was prepared using /home/chhegar/tools/webrev (vers 25.0-hg+openjdk.java.net).