Code Review for jdk

Prepared by:chegar on Mon Oct 3 15:48:38 IST 2016
Workspace:/home/chhegar/repos/jdk9/dev/ssMove/jdk
Compare against: ssh://hg.openjdk.java.net/jdk9/dev/jdk
Summary of changes: 304 lines changed: 267 ins; 0 del; 37 mod; 9219 unchg
Patch of changes: jdk.patch
Bug id: <title>[JDK-8085192] java/rmi/activation/Activatable tests fail intermittently due to "Port already in use" - Java Bug System</title>
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.rmi/share/classes/sun/rmi/server/Activation.java

5 lines changed: 5 ins; 0 del; 0 mod; 2553 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/checkActivateRef/CheckActivateRef.java

2 lines changed: 1 ins; 0 del; 1 mod; 273 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/checkActivateRef/rmid.security.policy

2 lines changed: 2 ins; 0 del; 0 mod; 5 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/checkActivateRef/security.policy

2 lines changed: 2 ins; 0 del; 0 mod; 41 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/checkAnnotations/CheckAnnotations.java

9 lines changed: 8 ins; 0 del; 1 mod; 278 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/checkAnnotations/rmid.security.policy

2 lines changed: 2 ins; 0 del; 0 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/checkAnnotations/security.policy

3 lines changed: 3 ins; 0 del; 0 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/checkImplClassLoader/CheckImplClassLoader.java

2 lines changed: 1 ins; 0 del; 1 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/checkImplClassLoader/rmid.security.policy

2 lines changed: 2 ins; 0 del; 0 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/checkImplClassLoader/security.policy

3 lines changed: 3 ins; 0 del; 0 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java

2 lines changed: 1 ins; 0 del; 1 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/checkRegisterInLog/rmid.security.policy

2 lines changed: 2 ins; 0 del; 0 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/checkRegisterInLog/security.policy

3 lines changed: 3 ins; 0 del; 0 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/createPrivateActivable/CreatePrivateActivatable.java

2 lines changed: 1 ins; 0 del; 1 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/createPrivateActivable/rmid.security.policy

2 lines changed: 2 ins; 0 del; 0 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/createPrivateActivable/security.policy

3 lines changed: 3 ins; 0 del; 0 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/downloadParameterClass/DownloadParameterClass.java

2 lines changed: 1 ins; 0 del; 1 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/downloadParameterClass/manual.security.policy

3 lines changed: 3 ins; 0 del; 0 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/downloadParameterClass/rmid.security.policy

2 lines changed: 2 ins; 0 del; 0 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/downloadParameterClass/security.policy

3 lines changed: 3 ins; 0 del; 0 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/elucidateNoSuchMethod/ElucidateNoSuchMethod.java

2 lines changed: 1 ins; 0 del; 1 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/elucidateNoSuchMethod/rmid.security.policy

3 lines changed: 3 ins; 0 del; 0 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/elucidateNoSuchMethod/security.policy

3 lines changed: 3 ins; 0 del; 0 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/extLoadedImpl/ExtLoadedImplTest.java

1 line changed: 0 ins; 0 del; 1 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/forceLogSnapshot/ForceLogSnapshot.java

2 lines changed: 1 ins; 0 del; 1 mod; 288 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/forceLogSnapshot/rmid.security.policy

2 lines changed: 2 ins; 0 del; 0 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/forceLogSnapshot/security.policy

3 lines changed: 3 ins; 0 del; 0 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/inactiveGroup/InactiveGroup.java

2 lines changed: 1 ins; 0 del; 1 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/inactiveGroup/rmid.security.policy

2 lines changed: 2 ins; 0 del; 0 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/inactiveGroup/security.policy

3 lines changed: 3 ins; 0 del; 0 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/lookupActivationSystem/LookupActivationSystem.java

2 lines changed: 1 ins; 0 del; 1 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/nestedActivate/NestedActivate.java

2 lines changed: 1 ins; 0 del; 1 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/nestedActivate/rmid.security.policy

2 lines changed: 2 ins; 0 del; 0 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/nestedActivate/security.policy

3 lines changed: 3 ins; 0 del; 0 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/nonExistentActivatable/NonExistentActivatable.java

2 lines changed: 1 ins; 0 del; 1 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/nonExistentActivatable/rmid.security.policy

2 lines changed: 2 ins; 0 del; 0 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/nonExistentActivatable/security.policy

2 lines changed: 2 ins; 0 del; 0 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/restartCrashedService/RestartCrashedService.java

2 lines changed: 1 ins; 0 del; 1 mod; 241 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/restartCrashedService/rmid.security.policy

2 lines changed: 2 ins; 0 del; 0 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/restartCrashedService/security.policy

3 lines changed: 3 ins; 0 del; 0 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/restartLatecomer/RestartLatecomer.java

2 lines changed: 1 ins; 0 del; 1 mod; 266 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/restartLatecomer/rmid.security.policy

2 lines changed: 2 ins; 0 del; 0 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/restartLatecomer/security.policy

3 lines changed: 3 ins; 0 del; 0 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/restartService/RestartService.java

2 lines changed: 1 ins; 0 del; 1 mod; 232 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/restartService/rmid.security.policy

2 lines changed: 2 ins; 0 del; 0 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/restartService/security.policy

3 lines changed: 3 ins; 0 del; 0 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/shutdownGracefully/ShutdownGracefully.java

2 lines changed: 1 ins; 0 del; 1 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/shutdownGracefully/rmid.security.policy

2 lines changed: 2 ins; 0 del; 0 mod; 5 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/shutdownGracefully/security.policy

3 lines changed: 3 ins; 0 del; 0 mod; 28 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/unregisterInactive/UnregisterInactive.java

2 lines changed: 1 ins; 0 del; 1 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/unregisterInactive/rmid.security.policy

2 lines changed: 2 ins; 0 del; 0 mod; 4 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/Activatable/unregisterInactive/security.policy

3 lines changed: 3 ins; 0 del; 0 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/ActivateFailedException/activateFails/ActivateFails.java

1 line changed: 0 ins; 0 del; 1 mod; 172 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/ActivationGroup/downloadActivationGroup/DownloadActivationGroup.java

1 line changed: 0 ins; 0 del; 1 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/ActivationSystem/activeGroup/IdempotentActiveGroup.java

1 line changed: 0 ins; 0 del; 1 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/ActivationSystem/modifyDescriptor/ModifyDescriptor.java

1 line changed: 0 ins; 0 del; 1 mod; 259 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/ActivationSystem/stubClassesPermitted/StubClassesPermitted.java

1 line changed: 0 ins; 0 del; 1 mod; 262 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup.java

1 line changed: 0 ins; 0 del; 1 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/CommandEnvironment/SetChildEnv.java

1 line changed: 0 ins; 0 del; 1 mod; 345 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/rmidViaInheritedChannel/InheritedChannelNotServerSocket.java

1 line changed: 0 ins; 0 del; 1 mod; 196 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/activation/rmidViaInheritedChannel/RmidViaInheritedChannel.java

1 line changed: 0 ins; 0 del; 1 mod; 214 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/testlibrary/JavaVM.java

45 lines changed: 41 ins; 0 del; 4 mod; 236 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/testlibrary/RMID.java

119 lines changed: 113 ins; 0 del; 6 mod; 398 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/rmi/testlibrary/TestParams.java

2 lines changed: 2 ins; 0 del; 0 mod; 80 unchg

This code review page was prepared using /home/chhegar/tools/webrev (vers 25.0-hg+openjdk.java.net).