Code Review for jdk

Prepared by:chegar on Thu Sep 24 14:41:44 IST 2015
Workspace:/home/chhegar/repos/jdk9/dev/ssMove/jdk
Compare against: http://hg.openjdk.java.net/jdk9/dev/jdk
Compare against version:jdk9-b82
Summary of changes: 304 lines changed: 117 ins; 21 del; 166 mod; 60144 unchg
Patch of changes: jdk.patch
Bug id: <title>[JDK-8137056] Move SharedSecrets and friends to jdk.internal.misc - Java Bug System</title>
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/io/Console.java

4 lines changed: 2 ins; 0 del; 2 mod; 579 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/io/DeleteOnExitHook.java

2 lines changed: 1 ins; 0 del; 1 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/io/FileOutputStream.java

2 lines changed: 0 ins; 0 del; 2 mod; 444 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/System.java

4 lines changed: 2 ins; 0 del; 2 mod; 1272 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Thread.java

2 lines changed: 1 ins; 0 del; 1 mod; 2047 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/ref/Finalizer.java

3 lines changed: 1 ins; 1 del; 1 mod; 235 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/ref/Reference.java

6 lines changed: 3 ins; 3 del; 0 mod; 311 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Constructor.java

2 lines changed: 1 ins; 0 del; 1 mod; 591 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Executable.java

8 lines changed: 2 ins; 0 del; 6 mod; 725 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Field.java

3 lines changed: 1 ins; 0 del; 2 mod; 1183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/reflect/Method.java

2 lines changed: 1 ins; 0 del; 1 mod; 675 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/HttpCookie.java

4 lines changed: 2 ins; 0 del; 2 mod; 1144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/InetAddress.java

5 lines changed: 2 ins; 0 del; 3 mod; 1555 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/URLClassLoader.java

6 lines changed: 3 ins; 0 del; 3 mod; 809 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/Bits.java

4 lines changed: 0 ins; 0 del; 4 mod; 833 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/nio/channels/spi/AbstractInterruptibleChannel.java

4 lines changed: 1 ins; 1 del; 2 mod; 211 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/security/ProtectionDomain.java

4 lines changed: 0 ins; 0 del; 4 mod; 567 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/EnumMap.java

1 line changed: 0 ins; 0 del; 1 mod; 812 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/EnumSet.java

1 line changed: 0 ins; 0 del; 1 mod; 465 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/StringJoiner.java

2 lines changed: 0 ins; 0 del; 2 mod; 271 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/UUID.java

2 lines changed: 0 ins; 0 del; 2 mod; 461 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/jar/JarFile.java

2 lines changed: 1 ins; 1 del; 0 mod; 761 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/jar/JavaUtilJarAccessImpl.java

1 line changed: 0 ins; 0 del; 1 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/zip/ZipFile.java

5 lines changed: 2 ins; 0 del; 3 mod; 820 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ImageNativeSubstrate.java

60 lines changed: 56 ins; 2 del; 2 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/misc/URLClassPath.java

4 lines changed: 2 ins; 0 del; 2 mod; 1241 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/net/sdp/SdpSupport.java

2 lines changed: 0 ins; 0 del; 2 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/net/www/protocol/http/HttpURLConnection.java

4 lines changed: 2 ins; 0 del; 2 mod; 3678 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/nio/ch/FileChannelImpl.java

7 lines changed: 3 ins; 2 del; 2 mod; 1223 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/reflect/annotation/AnnotationSupport.java

3 lines changed: 0 ins; 0 del; 3 mod; 280 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/reflect/annotation/AnnotationType.java

6 lines changed: 2 ins; 2 del; 2 mod; 228 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/reflect/annotation/TypeAnnotationParser.java

3 lines changed: 1 ins; 0 del; 2 mod; 501 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/provider/PolicyFile.java

3 lines changed: 0 ins; 0 del; 3 mod; 2273 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java

3 lines changed: 0 ins; 0 del; 3 mod; 2617 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/util/Password.java

2 lines changed: 1 ins; 0 del; 1 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/text/bidi/BidiBase.java

2 lines changed: 0 ins; 0 del; 2 mod; 4778 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/util/logging/PlatformLogger.java

2 lines changed: 0 ins; 0 del; 2 mod; 658 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/classes/java/io/FileDescriptor.java

4 lines changed: 2 ins; 0 del; 2 mod; 243 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/classes/java/lang/ProcessImpl.java

4 lines changed: 2 ins; 0 del; 2 mod; 933 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/unix/classes/sun/nio/fs/UnixChannelFactory.java

4 lines changed: 2 ins; 2 del; 0 mod; 292 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/classes/java/io/FileDescriptor.java

4 lines changed: 2 ins; 0 del; 2 mod; 241 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/classes/java/lang/ProcessImpl.java

4 lines changed: 2 ins; 0 del; 2 mod; 574 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/classes/java/net/DualStackPlainDatagramSocketImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 295 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/classes/java/net/DualStackPlainSocketImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 298 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/classes/sun/nio/ch/FileDispatcherImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 180 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 755 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/windows/classes/sun/nio/fs/WindowsChannelFactory.java

2 lines changed: 0 ins; 0 del; 2 mod; 343 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/com/sun/beans/decoder/DocumentHandler.java

1 line changed: 0 ins; 0 del; 1 mod; 410 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/EventQueue.java

2 lines changed: 0 ins; 0 del; 2 mod; 1364 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/font/JavaAWTFontAccessImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/font/NumericShaper.java

1 line changed: 0 ins; 0 del; 1 mod; 1898 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/awt/font/TextAttribute.java

1 line changed: 0 ins; 0 del; 1 mod; 1122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/java/beans/Introspector.java

3 lines changed: 1 ins; 1 del; 1 mod; 1409 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/RepaintManager.java

4 lines changed: 2 ins; 2 del; 0 mod; 1770 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/javax/swing/TransferHandler.java

2 lines changed: 0 ins; 0 del; 2 mod; 1794 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/awt/AppContext.java

12 lines changed: 2 ins; 0 del; 10 mod; 927 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.logging/share/classes/java/util/logging/LogManager.java

3 lines changed: 1 ins; 1 del; 1 mod; 1912 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.logging/share/classes/java/util/logging/LogRecord.java

2 lines changed: 0 ins; 0 del; 2 mod; 679 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.management/share/classes/com/sun/jmx/mbeanserver/Introspector.java

2 lines changed: 0 ins; 2 del; 0 mod; 698 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.management/share/classes/com/sun/jmx/mbeanserver/JavaBeansAccessor.java

2 lines changed: 0 ins; 0 del; 2 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.management/share/classes/javax/management/modelmbean/RequiredModelMBean.java

2 lines changed: 0 ins; 0 del; 2 mod; 3000 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.management/share/classes/sun/management/ManagementFactoryHelper.java

5 lines changed: 3 ins; 0 del; 2 mod; 451 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.naming/share/classes/com/sun/jndi/ldap/VersionHelper.java

1 line changed: 0 ins; 0 del; 1 mod; 100 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.sql/share/classes/java/sql/Date.java

2 lines changed: 0 ins; 0 del; 2 mod; 318 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.sql/share/classes/java/sql/Time.java

2 lines changed: 0 ins; 0 del; 2 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.sql/share/classes/java/sql/Timestamp.java

2 lines changed: 0 ins; 0 del; 2 mod; 566 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/security/ProtectionDomain/PreserveCombinerTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/logging/LogManagerAppContextDeadlock.java

5 lines changed: 2 ins; 0 del; 3 mod; 368 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/logging/RootLogger/RootLevelInConfigFile.java

4 lines changed: 0 ins; 0 del; 4 mod; 204 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/logging/TestAppletLoggerContext.java

3 lines changed: 0 ins; 0 del; 3 mod; 576 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/logging/TestGetLoggerNPE.java

3 lines changed: 0 ins; 0 del; 3 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaAWTAccess.java (was src/java.base/share/classes/sun/misc/JavaAWTAccess.java)

1 line changed: 0 ins; 0 del; 1 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaAWTFontAccess.java (was src/java.base/share/classes/sun/misc/JavaAWTFontAccess.java)

1 line changed: 0 ins; 0 del; 1 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaBeansAccess.java (was src/java.base/share/classes/sun/misc/JavaBeansAccess.java)

1 line changed: 0 ins; 0 del; 1 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaIOAccess.java (was src/java.base/share/classes/sun/misc/JavaIOAccess.java)

2 lines changed: 1 ins; 0 del; 1 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaIOFileDescriptorAccess.java (was src/java.base/share/classes/sun/misc/JavaIOFileDescriptorAccess.java)

1 line changed: 0 ins; 0 del; 1 mod; 41 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaLangAccess.java (was src/java.base/share/classes/sun/misc/JavaLangAccess.java)

1 line changed: 0 ins; 0 del; 1 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaLangRefAccess.java (was src/java.base/share/classes/sun/misc/JavaLangRefAccess.java)

1 line changed: 0 ins; 0 del; 1 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaNetAccess.java (was src/java.base/share/classes/sun/misc/JavaNetAccess.java)

2 lines changed: 1 ins; 0 del; 1 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaNetHttpCookieAccess.java (was src/java.base/share/classes/sun/misc/JavaNetHttpCookieAccess.java)

1 line changed: 0 ins; 0 del; 1 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaNetInetAddressAccess.java (was src/java.base/share/classes/sun/misc/JavaNetInetAddressAccess.java)

1 line changed: 0 ins; 0 del; 1 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaNioAccess.java (was src/java.base/share/classes/sun/misc/JavaNioAccess.java)

1 line changed: 0 ins; 0 del; 1 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaSecurityAccess.java (was src/java.base/share/classes/sun/misc/JavaSecurityAccess.java)

1 line changed: 0 ins; 0 del; 1 mod; 39 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaSecurityProtectionDomainAccess.java (was src/java.base/share/classes/sun/misc/JavaSecurityProtectionDomainAccess.java)

1 line changed: 0 ins; 0 del; 1 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaUtilJarAccess.java (was src/java.base/share/classes/sun/misc/JavaUtilJarAccess.java)

1 line changed: 0 ins; 0 del; 1 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/JavaUtilZipFileAccess.java (was src/java.base/share/classes/sun/misc/JavaUtilZipFileAccess.java)

1 line changed: 0 ins; 0 del; 1 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/misc/SharedSecrets.java (was src/java.base/share/classes/sun/misc/SharedSecrets.java)

3 lines changed: 1 ins; 1 del; 1 mod; 213 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/internal/misc/JavaLangAccess/FormatUnsigned.java (was test/sun/misc/JavaLangAccess/FormatUnsigned.java)

3 lines changed: 0 ins; 0 del; 3 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/internal/misc/JavaLangAccess/NewUnsafeString.java (was test/sun/misc/JavaLangAccess/NewUnsafeString.java)

3 lines changed: 0 ins; 0 del; 3 mod; 84 unchg

This code review page was prepared using /home/chhegar/tools/webrev (vers 25.0-hg+openjdk.java.net).