Code Review for rt

Prepared by:ckyang on Fri Apr 29 10:56:33 PDT 2016
Workspace:/cygdrive/c/java/javafx/900/jfx/rt
Compare against: ssh://hg.openjdk.java.net/openjfx/9-dev/rt
Summary of changes: 1442 lines changed: 443 ins; 97 del; 902 mod; 52521 unchg
Patch of changes: rt.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/util/Deprecation.java

8 lines changed: 0 ins; 8 del; 0 mod; 224 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/com/sun/javafx/scene/control/skin/Utils.java

5 lines changed: 1 ins; 0 del; 4 mod; 792 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/font/PrismFontLoader.java

13 lines changed: 1 ins; 0 del; 12 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/input/DragboardHelper.java

12 lines changed: 11 ins; 0 del; 1 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/sg/prism/NGCanvas.java

2 lines changed: 1 ins; 0 del; 1 mod; 1694 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/sg/prism/NGRegion.java

3 lines changed: 0 ins; 0 del; 3 mod; 2026 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/Toolkit.java

3 lines changed: 2 ins; 0 del; 1 mod; 965 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/quantum/GlassSystemMenu.java

2 lines changed: 1 ins; 0 del; 1 mod; 376 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/quantum/QuantumClipboard.java

2 lines changed: 0 ins; 0 del; 2 mod; 704 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/quantum/QuantumToolkit.java

5 lines changed: 2 ins; 0 del; 3 mod; 1585 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/scenario/effect/EffectHelper.java

8 lines changed: 8 ins; 0 del; 0 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/animation/Animation.java

30 lines changed: 0 ins; 0 del; 30 mod; 1108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/animation/AnimationAccessorImpl.java

6 lines changed: 0 ins; 0 del; 6 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/animation/FadeTransition.java

4 lines changed: 0 ins; 0 del; 4 mod; 336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/animation/FillTransition.java

4 lines changed: 0 ins; 0 del; 4 mod; 340 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/animation/ParallelTransition.java

47 lines changed: 0 ins; 9 del; 38 mod; 550 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/animation/PathTransition.java

4 lines changed: 0 ins; 0 del; 4 mod; 517 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/animation/RotateTransition.java

4 lines changed: 0 ins; 0 del; 4 mod; 368 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/animation/ScaleTransition.java

4 lines changed: 0 ins; 0 del; 4 mod; 552 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/animation/SequentialTransition.java

43 lines changed: 0 ins; 0 del; 43 mod; 715 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/animation/StrokeTransition.java

4 lines changed: 0 ins; 0 del; 4 mod; 342 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/animation/Timeline.java

9 lines changed: 0 ins; 0 del; 9 mod; 202 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/animation/Transition.java

10 lines changed: 0 ins; 0 del; 10 mod; 211 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/animation/TranslateTransition.java

4 lines changed: 0 ins; 0 del; 4 mod; 553 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/ImageCursor.java

1 line changed: 0 ins; 0 del; 1 mod; 682 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/Node.java

1 line changed: 0 ins; 0 del; 1 mod; 9801 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/Scene.java

8 lines changed: 2 ins; 0 del; 6 mod; 6503 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/canvas/GraphicsContext.java

5 lines changed: 1 ins; 0 del; 4 mod; 2977 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/effect/Blend.java

4 lines changed: 0 ins; 3 del; 1 mod; 365 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/effect/Effect.java

5 lines changed: 5 ins; 0 del; 0 mod; 342 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/effect/ImageInput.java

2 lines changed: 0 ins; 0 del; 2 mod; 280 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/image/Image.java

29 lines changed: 10 ins; 15 del; 4 mod; 1229 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/image/ImageView.java

5 lines changed: 2 ins; 0 del; 3 mod; 884 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/input/Clipboard.java

20 lines changed: 13 ins; 5 del; 2 mod; 420 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/input/Dragboard.java

28 lines changed: 14 ins; 10 del; 4 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/input/TouchPoint.java

20 lines changed: 13 ins; 5 del; 2 mod; 380 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/layout/ConstraintsBase.java

14 lines changed: 0 ins; 1 del; 13 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/paint/Material.java

43 lines changed: 24 ins; 15 del; 4 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/paint/PhongMaterial.java

18 lines changed: 1 ins; 10 del; 7 mod; 496 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/Shape3D.java

5 lines changed: 1 ins; 0 del; 4 mod; 243 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/text/Font.java

44 lines changed: 24 ins; 15 del; 5 mod; 513 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/text/Text.java

2 lines changed: 1 ins; 0 del; 1 mod; 1926 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/stage/Stage.java

2 lines changed: 0 ins; 0 del; 2 mod; 1307 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/javafx/animation/AnimationShim.java

27 lines changed: 0 ins; 0 del; 27 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/javafx/animation/TransitionShim.java

14 lines changed: 0 ins; 0 del; 14 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/com/sun/javafx/pgstub/StubFontLoader.java

15 lines changed: 1 ins; 0 del; 14 mod; 225 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/com/sun/javafx/pgstub/StubToolkit.java

2 lines changed: 1 ins; 0 del; 1 mod; 925 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/com/sun/javafx/text/TextLayoutTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 226 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/animation/AnimationDummy.java

2 lines changed: 0 ins; 0 del; 2 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/animation/AnimationImpl.java

4 lines changed: 0 ins; 0 del; 4 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/animation/AnimationMock.java

4 lines changed: 0 ins; 0 del; 4 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/animation/AnimationPulseReceiverTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/animation/AnimationSetRateTest.java

4 lines changed: 0 ins; 0 del; 4 mod; 370 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/animation/AnimationTest.java

25 lines changed: 0 ins; 0 del; 25 mod; 593 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/animation/FadeTransitionTest.java

72 lines changed: 0 ins; 0 del; 72 mod; 367 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/animation/FillTransitionTest.java

72 lines changed: 0 ins; 0 del; 72 mod; 289 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/animation/ParallelTransitionPlayTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 972 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/animation/RotateTransitionTest.java

66 lines changed: 0 ins; 0 del; 66 mod; 342 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/animation/ScaleTransitionTest.java

108 lines changed: 0 ins; 0 del; 108 mod; 576 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/animation/SequentialTransitionPlayTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 1015 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/animation/StrokeTransitionTest.java

48 lines changed: 0 ins; 0 del; 48 mod; 267 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/animation/TransitionTest.java

45 lines changed: 0 ins; 0 del; 45 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/animation/TranslateTransitionTest.java

108 lines changed: 0 ins; 0 del; 108 mod; 576 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/scene/image/ImageTest.java

8 lines changed: 0 ins; 0 del; 8 mod; 552 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/scene/image/ImageViewTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 228 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/scene/text/FontTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 205 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/swing/src/main/java/javafx/embed/swing/SwingCursors.java

2 lines changed: 0 ins; 1 del; 1 mod; 143 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/web/src/main/java/com/sun/javafx/webkit/CursorManagerImpl.java

3 lines changed: 1 ins; 0 del; 2 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/web/src/main/java/com/sun/javafx/webkit/PasteboardImpl.java

3 lines changed: 1 ins; 0 del; 2 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/web/src/main/java/com/sun/javafx/webkit/UIClientImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 329 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/web/src/main/java/com/sun/javafx/webkit/prism/PrismImage.java

2 lines changed: 1 ins; 0 del; 1 mod; 90 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/input/ClipboardHelper.java

68 lines changed: 68 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/input/TouchPointHelper.java

69 lines changed: 69 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/paint/MaterialHelper.java

81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/text/FontHelper.java

80 lines changed: 80 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using ools/webrev (vers 25.16-hg+openjdk.java.net).