Code Review for rt

Prepared by:ckyang on Fri May 20 13:52:34 PDT 2016
Workspace:/Users/ckyang/java/javafx/900/jfx/rt
Compare against: ssh://hg.openjdk.java.net/openjfx/9-dev/rt
Summary of changes: 2938 lines changed: 2534 ins; 191 del; 213 mod; 20240 unchg
Patch of changes: rt.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/PathUtils.java

2 lines changed: 0 ins; 0 del; 2 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/stage/StageHelper.java

2 lines changed: 0 ins; 0 del; 2 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/stage/WindowHelper.java

2 lines changed: 0 ins; 0 del; 2 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/animation/PathTransition.java

2 lines changed: 1 ins; 0 del; 1 mod; 520 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/layout/Region.java

5 lines changed: 1 ins; 0 del; 4 mod; 3591 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/Arc.java

17 lines changed: 11 ins; 2 del; 4 mod; 460 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/ArcTo.java

17 lines changed: 10 ins; 2 del; 5 mod; 563 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/Box.java

3 lines changed: 0 ins; 0 del; 3 mod; 447 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/Circle.java

25 lines changed: 15 ins; 2 del; 8 mod; 361 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/ClosePath.java

22 lines changed: 16 ins; 2 del; 4 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/CubicCurve.java

17 lines changed: 11 ins; 2 del; 4 mod; 501 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/CubicCurveTo.java

17 lines changed: 11 ins; 2 del; 4 mod; 390 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/Cylinder.java

5 lines changed: 1 ins; 0 del; 4 mod; 546 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/Ellipse.java

23 lines changed: 13 ins; 3 del; 7 mod; 362 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/HLineTo.java

18 lines changed: 11 ins; 3 del; 4 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/Line.java

38 lines changed: 21 ins; 5 del; 12 mod; 420 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/LineTo.java

19 lines changed: 12 ins; 3 del; 4 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/Mesh.java

45 lines changed: 22 ins; 20 del; 3 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/MeshView.java

4 lines changed: 1 ins; 0 del; 3 mod; 171 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/MoveTo.java

18 lines changed: 11 ins; 3 del; 4 mod; 180 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/Path.java

42 lines changed: 24 ins; 5 del; 13 mod; 356 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/PathElement.java

28 lines changed: 22 ins; 6 del; 0 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/Polygon.java

22 lines changed: 12 ins; 3 del; 7 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/Polyline.java

42 lines changed: 22 ins; 5 del; 15 mod; 215 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/QuadCurve.java

18 lines changed: 11 ins; 3 del; 4 mod; 400 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/QuadCurveTo.java

18 lines changed: 11 ins; 3 del; 4 mod; 294 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/Rectangle.java

23 lines changed: 14 ins; 3 del; 6 mod; 571 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/SVGPath.java

27 lines changed: 18 ins; 3 del; 6 mod; 237 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/Shape.java

106 lines changed: 58 ins; 14 del; 34 mod; 1713 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/Sphere.java

4 lines changed: 1 ins; 0 del; 3 mod; 427 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/TriangleMesh.java

37 lines changed: 15 ins; 14 del; 8 mod; 922 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/shape/VLineTo.java

19 lines changed: 11 ins; 3 del; 5 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/text/Text.java

38 lines changed: 13 ins; 15 del; 10 mod; 1902 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/stage/Stage.java

6 lines changed: 3 ins; 0 del; 3 mod; 1301 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/stage/Window.java

6 lines changed: 3 ins; 0 del; 3 mod; 1566 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/addExports

1 line changed: 1 ins; 0 del; 0 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/scene/shape/HLineToTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/scene/shape/PolygonTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 172 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/scene/shape/ShapeTest.java

68 lines changed: 1 ins; 65 del; 2 mod; 239 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/javafx/scene/shape/VLineToTest.java

3 lines changed: 1 ins; 0 del; 2 mod; 81 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/ArcHelper.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/ArcToHelper.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/CircleHelper.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/ClosePathHelper.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/CubicCurveHelper.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/CubicCurveToHelper.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/EllipseHelper.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/HLineToHelper.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/LineHelper.java

83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/LineToHelper.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/MeshHelper.java

106 lines changed: 106 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/MoveToHelper.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/PathElementHelper.java

87 lines changed: 87 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/PathHelper.java

84 lines changed: 84 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/PolygonHelper.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/PolylineHelper.java

83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/QuadCurveHelper.java

71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/QuadCurveToHelper.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/RectangleHelper.java

71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/SVGPathHelper.java

71 lines changed: 71 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/ShapeHelper.java

124 lines changed: 124 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/TextHelper.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/TriangleMeshHelper.java

82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/main/java/com/sun/javafx/scene/shape/VLineToHelper.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/test/java/test/javafx/scene/shape/StubNGShape.java

128 lines changed: 128 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/test/java/test/javafx/scene/shape/StubShape.java

55 lines changed: 55 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw modules/graphics/src/test/java/test/javafx/scene/shape/StubShapeHelper.java

70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /Users/ckyang/bin/webrev (vers 25.16-hg+openjdk.java.net).