Code Review for jdk

Prepared by:darcy on Thu Jul 5 18:56:15 PDT 2018
Workspace:/home/darcy/JDK/Scm/hg/jdk
Compare against: http://hg.openjdk.java.net/jdk/jdk
Summary of changes: 235 lines changed: 2 ins; 170 del; 63 mod; 1957 unchg
Patch of changes: jdk.patch
Bug id: JDK-8206439 : Remove javac -source/-target 6 from langtools regression tests
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/6558548/T6558548.java

1 line changed: 0 ins; 1 del; 0 mod; 308 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/6558548/T6558548_latest.out

7 lines changed: 0 ins; 0 del; 7 mod; 2 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/8074306/TestSyntheticNullChecks.java

4 lines changed: 0 ins; 3 del; 1 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/StringConcat/TestIndyStringConcat.java

4 lines changed: 0 ins; 4 del; 0 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/StringsInSwitch/BadlyTypedLabel1.java

1 line changed: 0 ins; 1 del; 0 mod; 16 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/StringsInSwitch/BadlyTypedLabel1.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/StringsInSwitch/BadlyTypedLabel2.java

1 line changed: 0 ins; 1 del; 0 mod; 18 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/StringsInSwitch/BadlyTypedLabel2.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/StringsInSwitch/NonConstantLabel.java

1 line changed: 0 ins; 1 del; 0 mod; 17 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/StringsInSwitch/NonConstantLabel.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/StringsInSwitch/OneCaseSwitches.java

1 line changed: 0 ins; 1 del; 0 mod; 279 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/StringsInSwitch/RSCL1.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/StringsInSwitch/RSCL2.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/StringsInSwitch/RepeatedStringCaseLabels1.java

1 line changed: 0 ins; 1 del; 0 mod; 16 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/StringsInSwitch/RepeatedStringCaseLabels2.java

1 line changed: 0 ins; 1 del; 0 mod; 17 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/TryWithResources/BadTwr.java

1 line changed: 0 ins; 1 del; 0 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/TryWithResources/BadTwr.out

4 lines changed: 0 ins; 0 del; 4 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/TryWithResources/BadTwrSyntax.java

1 line changed: 0 ins; 1 del; 0 mod; 26 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/TryWithResources/BadTwrSyntax.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/TryWithResources/PlainTry.java

1 line changed: 0 ins; 1 del; 0 mod; 14 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/TryWithResources/PlainTry.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/TryWithResources/TwrOnNonResource.java

1 line changed: 0 ins; 1 del; 0 mod; 29 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/TryWithResources/TwrOnNonResource.out

3 lines changed: 0 ins; 0 del; 3 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/TryWithResources/WeirdTwr.java

1 line changed: 0 ins; 1 del; 0 mod; 24 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/annotations/repeatingAnnotations/WrongVersion.java

1 line changed: 0 ins; 1 del; 0 mod; 22 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/annotations/repeatingAnnotations/WrongVersion7.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion.java

1 line changed: 0 ins; 1 del; 0 mod; 14 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion7.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/classfiles/ClassVersionChecker.java

1 line changed: 0 ins; 1 del; 0 mod; 170 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/defaultMethods/static/StaticInvokeQualified.java

2 lines changed: 0 ins; 1 del; 1 mod; 11 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/defaultMethods/static/StaticInvokeQualified7.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/defaultMethods/static/StaticInvokeSimple.java

2 lines changed: 0 ins; 1 del; 1 mod; 12 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/defaultMethods/static/StaticInvokeSimple7.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/literals/BadBinaryLiterals.7.out

6 lines changed: 1 ins; 1 del; 4 mod; 2 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/literals/BadBinaryLiterals.java

1 line changed: 0 ins; 1 del; 0 mod; 17 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/literals/BadUnderscoreLiterals.7.out

18 lines changed: 1 ins; 1 del; 16 mod; 2 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/literals/BadUnderscoreLiterals.java

2 lines changed: 0 ins; 1 del; 1 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/mixedTarget/ExtendCovariant2.java

2 lines changed: 0 ins; 1 del; 1 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/multicatch/Neg01.java

2 lines changed: 0 ins; 2 del; 0 mod; 26 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/multicatch/Neg01.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/multicatch/Neg01eff_final.java

2 lines changed: 0 ins; 2 del; 0 mod; 26 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/multicatch/Neg01eff_final.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/warnings/TestSourceVersionWarnings.java

8 lines changed: 0 ins; 1 del; 7 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/warnings/gold_sv_warn_5_6.out

1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/types/CastObjectToPrimitiveTest.java

2 lines changed: 0 ins; 1 del; 1 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/versions/Versions.java

14 lines changed: 0 ins; 12 del; 2 mod; 475 unchg

------ ------ ------ ------ Old --- Patch --- test/langtools/tools/javac/6558548/T6558548_6.out

7 lines changed: 0 ins; 7 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/langtools/tools/javac/8013179/T8013179.java

15 lines changed: 0 ins; 15 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/langtools/tools/javac/8013179/T8013179.out

2 lines changed: 0 ins; 2 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/langtools/tools/javac/StringsInSwitch/BadlyTypedLabel1_6.out

7 lines changed: 0 ins; 7 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/langtools/tools/javac/StringsInSwitch/BadlyTypedLabel2_6.out

7 lines changed: 0 ins; 7 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/langtools/tools/javac/StringsInSwitch/NonConstantLabel6.out

7 lines changed: 0 ins; 7 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/langtools/tools/javac/StringsInSwitch/OneCaseSwitches.out

6 lines changed: 0 ins; 6 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/langtools/tools/javac/StringsInSwitch/RSCL1_6.out

7 lines changed: 0 ins; 7 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/langtools/tools/javac/StringsInSwitch/RSCL2_6.out

7 lines changed: 0 ins; 7 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/langtools/tools/javac/TryWithResources/BadTwr6.out

6 lines changed: 0 ins; 6 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/langtools/tools/javac/TryWithResources/BadTwrSyntax6.out

7 lines changed: 0 ins; 7 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/langtools/tools/javac/TryWithResources/PlainTry6.out

2 lines changed: 0 ins; 2 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/langtools/tools/javac/TryWithResources/TwrOnNonResource6.out

6 lines changed: 0 ins; 6 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/langtools/tools/javac/annotations/repeatingAnnotations/WrongVersion6.out

2 lines changed: 0 ins; 2 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/langtools/tools/javac/annotations/typeAnnotations/failures/AnnotationVersion.out

2 lines changed: 0 ins; 2 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/langtools/tools/javac/defaultMethods/static/StaticInvokeQualified6.out

2 lines changed: 0 ins; 2 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/langtools/tools/javac/defaultMethods/static/StaticInvokeSimple6.out

2 lines changed: 0 ins; 2 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/langtools/tools/javac/literals/BadBinaryLiterals.6.out

6 lines changed: 0 ins; 6 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/langtools/tools/javac/literals/BadUnderscoreLiterals.6.out

21 lines changed: 0 ins; 21 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/langtools/tools/javac/types/CastObjectToPrimitiveTest.out

2 lines changed: 0 ins; 2 del; 0 mod; 0 unchg

This code review page was prepared using /home/darcy/JDK/bin/webrev.ksh (vers 25.17-hg+openjdk.java.net).