Code Review for 8049737_for_jdk9_hs_rt

Prepared by:dcubed on Wed Jul 23 17:21:10 PDT 2014
Workspace:/u/ddaugher/8049737_for_jdk9_hs_rt
Compare against: /u/ddaugher/8049737_for_jdk9_hs_rt.base
Summary of changes: 480 lines changed: 228 ins; 173 del; 79 mod; 11345 unchg
Patch of changes: 8049737_for_jdk9_hs_rt.patch
OpenJDK Bug id: JDK-8049737 Contended Locking reorder and cache line bucket
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw agent/src/share/classes/sun/jvm/hotspot/runtime/ObjectMonitor.java

20 lines changed: 0 ins; 9 del; 11 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw agent/src/share/classes/sun/jvm/hotspot/runtime/ObjectSynchronizer.java

10 lines changed: 9 ins; 0 del; 1 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/sparc/vm/globalDefinitions_sparc.hpp

23 lines changed: 22 ins; 0 del; 1 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/globalDefinitions_x86.hpp

24 lines changed: 23 ins; 0 del; 1 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/memory/padded.hpp

7 lines changed: 6 ins; 0 del; 1 mod; 111 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/prims/jvmtiEnvBase.cpp

1 line changed: 0 ins; 0 del; 1 mod; 1475 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/objectMonitor.cpp

34 lines changed: 2 ins; 23 del; 9 mod; 2558 unchg

Here is the normal webrev for objectMonitor.hpp:

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/objectMonitor.hpp

277 lines changed: 135 ins; 125 del; 17 mod; 197 unchg

Here is a special webrev for objectMonitor.hpp with code motion factored out:

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/objectMonitor.hpp

136 lines changed: 59 ins; 49 del; 28 mod; 262 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/objectMonitor.inline.hpp

10 lines changed: 0 ins; 5 del; 5 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/synchronizer.cpp

61 lines changed: 21 ins; 11 del; 29 mod; 1652 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/synchronizer.hpp

2 lines changed: 2 ins; 0 del; 0 mod; 171 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/vmStructs.cpp

8 lines changed: 6 ins; 0 del; 2 mod; 3361 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/utilities/globalDefinitions.hpp

3 lines changed: 2 ins; 0 del; 1 mod; 1404 unchg

This code review page was prepared using /java/devtools/share/bin/webrev (vers 23.18-hg+jbs).