< prev index next >

src/hotspot/share/runtime/objectMonitor.hpp

Print this page
rev 59077 : 8153224.v2.09b.patch combined with 8153224.v2.10.patch; merge with jdk-15+21.
rev 59078 : eosterlund v2.10 CR: reorganize deflate_monitor_using_JT() to use "early exit" style; dcubed - clarify/fix/rearrange a few comments in deflate_monitor_using_JT(); eosterlund v2.10 CR: simplify install_displaced_markword_in_object() and save_om_ptr(); save_om_ptr()'s call to install_displaced_markword_in_object() can race with the deflater thread's clearing of the object field so handle that; fold 8153224.OMHandle_experiment into 8153224.v2.11.patch; merge with jdk-15+21.

*** 134,150 **** // The sync code expects the header field to be at offset zero (0). // Enforced by the assert() in header_addr(). volatile markWord _header; // displaced object header word - mark void* volatile _object; // backward object pointer - strong root ! private: // Separate _header and _owner on different cache lines since both can ! // have busy multi-threaded access. _header and _object are set at ! // initial inflation and _object doesn't change until deflation so ! // _object is a good choice to share the cache line with _header. ! DEFINE_PAD_MINUS_SIZE(0, OM_CACHE_LINE_SIZE, ! sizeof(volatile markWord) + sizeof(void* volatile)); void* volatile _owner; // pointer to owning thread OR BasicLock volatile jlong _previous_owner_tid; // thread id of the previous owner of the monitor // Separate _owner and _next_om on different cache lines since // both can have busy multi-threaded access. _previous_owner_tid is only // changed by ObjectMonitor::exit() so it is a good choice to share the --- 134,158 ---- // The sync code expects the header field to be at offset zero (0). // Enforced by the assert() in header_addr(). volatile markWord _header; // displaced object header word - mark void* volatile _object; // backward object pointer - strong root ! typedef enum { ! Free = 0, // Free must be 0 for monitor to be free after memset(..,0,..). ! New, ! Old ! } AllocationState; ! AllocationState _allocation_state; // Separate _header and _owner on different cache lines since both can ! // have busy multi-threaded access. _header, _object and _allocation_state ! // are set at initial inflation. _object and _allocation_state don't ! // change until deflation so _object and _allocation_state are good ! // choices to share the cache line with _header. ! DEFINE_PAD_MINUS_SIZE(0, OM_CACHE_LINE_SIZE, sizeof(volatile markWord) + ! sizeof(void* volatile) + sizeof(AllocationState)); ! // Used by async deflation as a marker in the _owner field: ! #define DEFLATER_MARKER reinterpret_cast<void*>(-1) void* volatile _owner; // pointer to owning thread OR BasicLock volatile jlong _previous_owner_tid; // thread id of the previous owner of the monitor // Separate _owner and _next_om on different cache lines since // both can have busy multi-threaded access. _previous_owner_tid is only // changed by ObjectMonitor::exit() so it is a good choice to share the
*** 162,174 **** Thread* volatile _Responsible; volatile int _Spinner; // for exit->spinner handoff optimization volatile int _SpinDuration; ! volatile jint _contentions; // Number of active contentions in enter(). It is used by is_busy() // along with other fields to determine if an ObjectMonitor can be ! // deflated. See ObjectSynchronizer::deflate_monitor(). protected: ObjectWaiter* volatile _WaitSet; // LL of threads wait()ing on the monitor volatile jint _waiters; // number of waiting threads private: volatile int _WaitSetLock; // protects Wait Queue - simple spinlock --- 170,183 ---- Thread* volatile _Responsible; volatile int _Spinner; // for exit->spinner handoff optimization volatile int _SpinDuration; ! jint _contentions; // Number of active contentions in enter(). It is used by is_busy() // along with other fields to determine if an ObjectMonitor can be ! // deflated. It is also used by the async deflation protocol. See ! // ObjectSynchronizer::deflate_monitor() and deflate_monitor_using_JT(). protected: ObjectWaiter* volatile _WaitSet; // LL of threads wait()ing on the monitor volatile jint _waiters; // number of waiting threads private: volatile int _WaitSetLock; // protects Wait Queue - simple spinlock
*** 231,251 **** volatile markWord* header_addr(); void set_header(markWord hdr); intptr_t is_busy() const { // TODO-FIXME: assert _owner == null implies _recursions = 0 ! return _contentions|_waiters|intptr_t(_owner)|intptr_t(_cxq)|intptr_t(_EntryList); } const char* is_busy_to_string(stringStream* ss); intptr_t is_entered(Thread* current) const; ! void* owner() const; // Clear _owner field; current value must match old_value. void release_clear_owner(void* old_value); // Simply set _owner field to new_value; current value must match old_value. void set_owner_from(void* old_value, void* new_value); // Simply set _owner field to self; current value must match basic_lock_p. void set_owner_from_BasicLock(void* basic_lock_p, Thread* self); // Try to set _owner field to new_value if the current value matches // old_value, using Atomic::cmpxchg(). Otherwise, does not change the // _owner field. Returns the prior value of the _owner field. --- 240,277 ---- volatile markWord* header_addr(); void set_header(markWord hdr); intptr_t is_busy() const { // TODO-FIXME: assert _owner == null implies _recursions = 0 ! intptr_t ret_code = _waiters | intptr_t(_cxq) | intptr_t(_EntryList); ! if (!AsyncDeflateIdleMonitors) { ! ret_code |= contentions() | intptr_t(_owner); ! } else { ! if (contentions() > 0) { ! ret_code |= contentions(); ! } ! if (_owner != DEFLATER_MARKER) { ! ret_code |= intptr_t(_owner); ! } ! } ! return ret_code; } const char* is_busy_to_string(stringStream* ss); intptr_t is_entered(Thread* current) const; ! void* owner() const; // Returns NULL if DEFLATER_MARKER is observed. ! // Returns true if owner field == DEFLATER_MARKER and false otherwise. ! bool owner_is_DEFLATER_MARKER(); ! // Returns true if 'this' is being async deflated and false otherwise. ! bool is_being_async_deflated(); // Clear _owner field; current value must match old_value. void release_clear_owner(void* old_value); // Simply set _owner field to new_value; current value must match old_value. void set_owner_from(void* old_value, void* new_value); + // Simply set _owner field to new_value; current value must match old_value1 or old_value2. + void set_owner_from(void* old_value1, void* old_value2, void* new_value); // Simply set _owner field to self; current value must match basic_lock_p. void set_owner_from_BasicLock(void* basic_lock_p, Thread* self); // Try to set _owner field to new_value if the current value matches // old_value, using Atomic::cmpxchg(). Otherwise, does not change the // _owner field. Returns the prior value of the _owner field.
*** 284,294 **** void Recycle() { // TODO: add stronger asserts ... // _cxq == 0 _succ == NULL _owner == NULL _waiters == 0 // _contentions == 0 EntryList == NULL // _recursions == 0 _WaitSet == NULL ! DEBUG_ONLY(stringStream ss;) assert((is_busy() | _recursions) == 0, "freeing in-use monitor: %s, " "recursions=" INTX_FORMAT, is_busy_to_string(&ss), _recursions); _succ = NULL; _EntryList = NULL; _cxq = NULL; --- 310,322 ---- void Recycle() { // TODO: add stronger asserts ... // _cxq == 0 _succ == NULL _owner == NULL _waiters == 0 // _contentions == 0 EntryList == NULL // _recursions == 0 _WaitSet == NULL ! #ifdef ASSERT ! stringStream ss; ! #endif assert((is_busy() | _recursions) == 0, "freeing in-use monitor: %s, " "recursions=" INTX_FORMAT, is_busy_to_string(&ss), _recursions); _succ = NULL; _EntryList = NULL; _cxq = NULL;
*** 299,315 **** public: void* object() const; void* object_addr(); void set_object(void* obj); // Returns true if the specified thread owns the ObjectMonitor. Otherwise // returns false and throws IllegalMonitorStateException (IMSE). bool check_owner(Thread* THREAD); void clear(); ! void enter(TRAPS); void exit(bool not_suspended, TRAPS); void wait(jlong millis, bool interruptable, TRAPS); void notify(TRAPS); void notifyAll(TRAPS); --- 327,349 ---- public: void* object() const; void* object_addr(); void set_object(void* obj); + void set_allocation_state(AllocationState s); + AllocationState allocation_state() const; + bool is_free() const; + bool is_old() const; + bool is_new() const; // Returns true if the specified thread owns the ObjectMonitor. Otherwise // returns false and throws IllegalMonitorStateException (IMSE). bool check_owner(Thread* THREAD); void clear(); + void clear_using_JT(); ! bool enter(TRAPS); void exit(bool not_suspended, TRAPS); void wait(jlong millis, bool interruptable, TRAPS); void notify(TRAPS); void notifyAll(TRAPS);
*** 319,341 **** #endif void print_on(outputStream* st) const; // Use the following at your own risk intx complete_exit(TRAPS); ! void reenter(intx recursions, TRAPS); private: void AddWaiter(ObjectWaiter* waiter); void INotify(Thread* self); ObjectWaiter* DequeueWaiter(); void DequeueSpecificWaiter(ObjectWaiter* waiter); void EnterI(TRAPS); void ReenterI(Thread* self, ObjectWaiter* self_node); void UnlinkAfterAcquire(Thread* self, ObjectWaiter* self_node); int TryLock(Thread* self); ! int NotRunnable(Thread* self, Thread * Owner); int TrySpin(Thread* self); void ExitEpilog(Thread* self, ObjectWaiter* Wakee); bool ExitSuspendEquivalent(JavaThread* self); }; #endif // SHARE_RUNTIME_OBJECTMONITOR_HPP --- 353,387 ---- #endif void print_on(outputStream* st) const; // Use the following at your own risk intx complete_exit(TRAPS); ! bool reenter(intx recursions, TRAPS); private: void AddWaiter(ObjectWaiter* waiter); void INotify(Thread* self); ObjectWaiter* DequeueWaiter(); void DequeueSpecificWaiter(ObjectWaiter* waiter); void EnterI(TRAPS); void ReenterI(Thread* self, ObjectWaiter* self_node); void UnlinkAfterAcquire(Thread* self, ObjectWaiter* self_node); int TryLock(Thread* self); ! int NotRunnable(Thread* self, Thread* Owner); int TrySpin(Thread* self); void ExitEpilog(Thread* self, ObjectWaiter* Wakee); bool ExitSuspendEquivalent(JavaThread* self); + void install_displaced_markword_in_object(const oop obj); }; + // Macro to use guarantee() for more strict AsyncDeflateIdleMonitors + // checks and assert() otherwise. + #define ADIM_guarantee(p, ...) \ + do { \ + if (AsyncDeflateIdleMonitors) { \ + guarantee(p, __VA_ARGS__); \ + } else { \ + assert(p, __VA_ARGS__); \ + } \ + } while (0) + #endif // SHARE_RUNTIME_OBJECTMONITOR_HPP
< prev index next >