src/hotspot/share/runtime/threadSMR.cpp

rev 47862 : imported patch 10.07.open.rebase_20171110.dcubed
rev 47865 : dholmes CR: Fix indents, trailing spaces and various typos. Add descriptions for the '_cnt', '_max' and '_times" fields, add impl notes to document the type choices.
rev 47867 : coleenp CR: Change ThreadsList::_threads from 'mtGC' -> 'mtThread', add header comment to threadSMR.hpp file, cleanup JavaThreadIteratorWithHandle ctr, make ErrorHandling more efficient.

*** 27,37 ****
  #include "runtime/thread.inline.hpp"
  #include "runtime/threadSMR.hpp"
  #include "services/threadService.hpp"
  
  // 'entries + 1' so we always have at least one entry.
! ThreadsList::ThreadsList(int entries) : _length(entries), _threads(NEW_C_HEAP_ARRAY(JavaThread*, entries + 1, mtGC)), _next_list(NULL) {
    *(JavaThread**)(_threads + entries) = NULL;  // Make sure the extra entry is NULL.
  }
  
  ThreadsList::~ThreadsList() {
    FREE_C_HEAP_ARRAY(JavaThread*, _threads);
--- 27,37 ----
  #include "runtime/thread.inline.hpp"
  #include "runtime/threadSMR.hpp"
  #include "services/threadService.hpp"
  
  // 'entries + 1' so we always have at least one entry.
! ThreadsList::ThreadsList(int entries) : _length(entries), _threads(NEW_C_HEAP_ARRAY(JavaThread*, entries + 1, mtThread)), _next_list(NULL) {
    *(JavaThread**)(_threads + entries) = NULL;  // Make sure the extra entry is NULL.
  }
  
  ThreadsList::~ThreadsList() {
    FREE_C_HEAP_ARRAY(JavaThread*, _threads);
*** 59,69 ****
  
  ThreadsListHandle::~ThreadsListHandle() {
    Threads::release_stable_list(_self);
    if (EnableThreadSMRStatistics) {
      _timer.stop();
!     jint millis = (jint)_timer.milliseconds();
      Threads::inc_smr_tlh_cnt();
      Threads::add_smr_tlh_times(millis);
      Threads::update_smr_tlh_time_max(millis);
    }
  }
--- 59,69 ----
  
  ThreadsListHandle::~ThreadsListHandle() {
    Threads::release_stable_list(_self);
    if (EnableThreadSMRStatistics) {
      _timer.stop();
!     uint millis = (uint)_timer.milliseconds();
      Threads::inc_smr_tlh_cnt();
      Threads::add_smr_tlh_times(millis);
      Threads::update_smr_tlh_time_max(millis);
    }
  }