Prepared by: | dcubed on Wed Apr 11 10:52:57 EDT 2018 |
---|---|
Workspace: | /work/shared/bug_hunt/8200374/8200374_for_jdk_hs/open |
Compare against: | /work/shared/bug_hunt/8200374/8200374_base/open |
Compare against version: | qparent |
Summary of changes: | 203 lines changed: 181 ins; 15 del; 7 mod; 8629 unchg |
Patch of changes: | open.patch |
Legend: |
Modified file Deleted file New file |
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/thread.cpp
rev 49672 : 8200374: Add ThreadsSMRSupport::verify_hazard_pointer_scanned() to verify threads_do(). rev 49673 : Add missing NULL check; use proper lock-free get/set with TracingExport::_sampler_thread. rev 49674 : Rename TracingExport::get_sampler_thread() to TracingExport::sampler_thread_acquire() and TracingExport::set_sampler_thread() to TracingExport::set_sampler_thread_with_lock(); set_sampler_thread_with_lock() uses Threads_lock toavoid conflicts with Thread-SMR scans.28 lines changed: 20 ins; 5 del; 3 mod; 5001 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/thread.hpp
rev 49672 : 8200374: Add ThreadsSMRSupport::verify_hazard_pointer_scanned() to verify threads_do().1 line changed: 1 ins; 0 del; 0 mod; 2229 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/threadSMR.cpp
rev 49672 : 8200374: Add ThreadsSMRSupport::verify_hazard_pointer_scanned() to verify threads_do(). rev 49673 : Add missing NULL check; use proper lock-free get/set with TracingExport::_sampler_thread.87 lines changed: 74 ins; 10 del; 3 mod; 1076 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/hotspot/share/runtime/threadSMR.hpp
rev 49672 : 8200374: Add ThreadsSMRSupport::verify_hazard_pointer_scanned() to verify threads_do().6 lines changed: 5 ins; 0 del; 1 mod; 323 unchg
------ ------ ------
------
---
New
Patch
Raw
src/hotspot/share/trace/tracingExport.cpp
rev 49672 : 8200374: Add ThreadsSMRSupport::verify_hazard_pointer_scanned() to verify threads_do(). rev 49673 : Add missing NULL check; use proper lock-free get/set with TracingExport::_sampler_thread. rev 49674 : Rename TracingExport::get_sampler_thread() to TracingExport::sampler_thread_acquire() and TracingExport::set_sampler_thread() to TracingExport::set_sampler_thread_with_lock(); set_sampler_thread_with_lock() uses Threads_lock toavoid conflicts with Thread-SMR scans. rev 49675 : TracingExport::set_sampler_thread_with_lock() needs to verify assumptions and to use release_store().42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg
------ ------ ------
------
---
New
Patch
Raw
src/hotspot/share/trace/tracingExport.hpp
rev 49672 : 8200374: Add ThreadsSMRSupport::verify_hazard_pointer_scanned() to verify threads_do(). rev 49673 : Add missing NULL check; use proper lock-free get/set with TracingExport::_sampler_thread. rev 49674 : Rename TracingExport::get_sampler_thread() to TracingExport::sampler_thread_acquire() and TracingExport::set_sampler_thread() to TracingExport::set_sampler_thread_with_lock(); set_sampler_thread_with_lock() uses Threads_lock toavoid conflicts with Thread-SMR scans.39 lines changed: 39 ins; 0 del; 0 mod; 0 unchg
This code review page was prepared using /Users/ddaugher/Bin/webrev.latest (vers 25.16-hg+openjdk.java.net).