< prev index next >

src/hotspot/share/utilities/vmError.cpp

Print this page
rev 50688 : 8205195: NestedThreadsListHandleInErrorHandlingTest fails because hs_err doesn't contain _nested_thread_list_max
Summary: Grab Threads_lock in VMError::controlled_crash() so ErrorHandling tests are more stable.
Reviewed-by:

*** 1696,1705 **** --- 1696,1712 ---- // which tests cases 1 thru 13. // Case 14 is tested by test/hotspot/jtreg/runtime/ErrorHandling/SafeFetchInErrorHandlingTest.java. // Case 15 is tested by test/hotspot/jtreg/runtime/ErrorHandling/SecondaryErrorTest.java. // Case 16 is tested by test/hotspot/jtreg/runtime/ErrorHandling/ThreadsListHandleInErrorHandlingTest.java. // Case 17 is tested by test/hotspot/jtreg/runtime/ErrorHandling/NestedThreadsListHandleInErrorHandlingTest.java. + + // We grab Threads_lock to keep ThreadsSMRSupport::print_info_on() + // from racing with Threads::add() or Threads::remove() as we + // generate the hs_err_pid file. This makes our ErrorHandling tests + // more stable. + MutexLockerEx ml(Threads_lock, Mutex::_no_safepoint_check_flag); + switch (how) { case 1: vmassert(str == NULL, "expected null"); break; case 2: vmassert(num == 1023 && *str == 'X', "num=" SIZE_FORMAT " str=\"%s\"", num, str); break; case 3: guarantee(str == NULL, "expected null"); break;
< prev index next >