# HG changeset patch # User ddehaven # Date 1476287273 25200 # Wed Oct 12 08:47:53 2016 -0700 # Node ID 0b9750cd2b796fceb2b00b01c7feaa12e17a3616 # Parent 557da3953b0ba44d907eb3b6aa03cde58b967b8a 8165271: Fix use of reflection to gain access to private fields Reviewed-by: diff --git a/src/java.base/share/classes/java/net/InetAddress.java b/src/java.base/share/classes/java/net/InetAddress.java --- a/src/java.base/share/classes/java/net/InetAddress.java +++ b/src/java.base/share/classes/java/net/InetAddress.java @@ -321,6 +321,13 @@ public String getOriginalHostName(InetAddress ia) { return ia.holder.getOriginalHostName(); } + + public InetAddress getByName(String hostName, + InetAddress hostAddress) + throws UnknownHostException + { + return InetAddress.getByName(hostName, hostAddress); + } } ); init(); diff --git a/src/java.base/share/classes/java/net/URLClassLoader.java b/src/java.base/share/classes/java/net/URLClassLoader.java --- a/src/java.base/share/classes/java/net/URLClassLoader.java +++ b/src/java.base/share/classes/java/net/URLClassLoader.java @@ -769,9 +769,15 @@ static { SharedSecrets.setJavaNetAccess( new JavaNetAccess() { + @Override public URLClassPath getURLClassPath(URLClassLoader u) { return u.ucp; } + + @Override + public AccessControlContext getAccessControlContext(URLClassLoader u) { + return u.acc; + } } ); ClassLoader.registerAsParallelCapable(); diff --git a/src/java.base/share/classes/java/security/ProtectionDomain.java b/src/java.base/share/classes/java/security/ProtectionDomain.java --- a/src/java.base/share/classes/java/security/ProtectionDomain.java +++ b/src/java.base/share/classes/java/security/ProtectionDomain.java @@ -89,6 +89,11 @@ AccessController.getContext(), context); } + @Override + public ProtectionDomain[] getProtectDomains(AccessControlContext context) { + return context.getContext(); + } + private static AccessControlContext getCombinedACC( AccessControlContext context, AccessControlContext stack) { AccessControlContext acc = diff --git a/src/java.base/share/classes/jdk/internal/misc/JavaNetAccess.java b/src/java.base/share/classes/jdk/internal/misc/JavaNetAccess.java --- a/src/java.base/share/classes/jdk/internal/misc/JavaNetAccess.java +++ b/src/java.base/share/classes/jdk/internal/misc/JavaNetAccess.java @@ -26,6 +26,8 @@ package jdk.internal.misc; import java.net.URLClassLoader; +import java.security.AccessControlContext; + import jdk.internal.loader.URLClassPath; public interface JavaNetAccess { @@ -33,4 +35,6 @@ * return the URLClassPath belonging to the given loader */ URLClassPath getURLClassPath (URLClassLoader u); + + AccessControlContext getAccessControlContext(URLClassLoader u); } diff --git a/src/java.base/share/classes/jdk/internal/misc/JavaNetInetAddressAccess.java b/src/java.base/share/classes/jdk/internal/misc/JavaNetInetAddressAccess.java --- a/src/java.base/share/classes/jdk/internal/misc/JavaNetInetAddressAccess.java +++ b/src/java.base/share/classes/jdk/internal/misc/JavaNetInetAddressAccess.java @@ -26,6 +26,7 @@ package jdk.internal.misc; import java.net.InetAddress; +import java.net.UnknownHostException; public interface JavaNetInetAddressAccess { /** @@ -33,4 +34,13 @@ * the given InetAddress object. */ String getOriginalHostName(InetAddress ia); + + /** + * Get the InetAddress of the provided host. If an InetAddress is provided + * then it will be the default address returned for all calls to either + * form of getByName. This is required to maintain consistency when + * caching addresses and hostnames. + */ + InetAddress getByName(String hostName, InetAddress hostAddress) + throws UnknownHostException; } diff --git a/src/java.base/share/classes/jdk/internal/misc/JavaSecurityAccess.java b/src/java.base/share/classes/jdk/internal/misc/JavaSecurityAccess.java --- a/src/java.base/share/classes/jdk/internal/misc/JavaSecurityAccess.java +++ b/src/java.base/share/classes/jdk/internal/misc/JavaSecurityAccess.java @@ -27,6 +27,7 @@ import java.security.AccessControlContext; import java.security.PrivilegedAction; +import java.security.ProtectionDomain; public interface JavaSecurityAccess { @@ -37,4 +38,5 @@ T doIntersectionPrivilege(PrivilegedAction action, AccessControlContext context); + ProtectionDomain[] getProtectDomains(AccessControlContext context); } diff --git a/src/java.desktop/share/classes/sun/applet/AppletSecurity.java b/src/java.desktop/share/classes/sun/applet/AppletSecurity.java --- a/src/java.desktop/share/classes/sun/applet/AppletSecurity.java +++ b/src/java.desktop/share/classes/sun/applet/AppletSecurity.java @@ -40,36 +40,24 @@ import java.util.StringTokenizer; import java.security.*; import java.lang.reflect.*; +import jdk.internal.misc.JavaNetAccess; +import jdk.internal.misc.JavaSecurityAccess; +import jdk.internal.misc.SharedSecrets; import sun.awt.AWTSecurityManager; import sun.awt.AppContext; import sun.awt.AWTPermissions; import sun.security.util.SecurityConstants; + /** * This class defines an applet security policy * */ public class AppletSecurity extends AWTSecurityManager { - - //URLClassLoader.acc - private static Field facc = null; - - //AccessControlContext.context; - private static Field fcontext = null; - - static { - try { - facc = URLClassLoader.class.getDeclaredField("acc"); - facc.setAccessible(true); - fcontext = AccessControlContext.class.getDeclaredField("context"); - fcontext.setAccessible(true); - } catch (NoSuchFieldException e) { - throw new UnsupportedOperationException(e); - } - } - + private static final JavaNetAccess JNA = SharedSecrets.getJavaNetAccess(); + private static final JavaSecurityAccess JSA = SharedSecrets.getJavaSecurityAccess(); /** * Construct and initialize. @@ -148,6 +136,7 @@ final ClassLoader currentLoader = context[i].getClassLoader(); if (currentLoader instanceof URLClassLoader) { + URLClassLoader ld = (URLClassLoader)currentLoader; loader = AccessController.doPrivileged( new PrivilegedAction() { public ClassLoader run() { @@ -156,12 +145,12 @@ ProtectionDomain[] pds = null; try { - acc = (AccessControlContext) facc.get(currentLoader); + acc = JNA.getAccessControlContext(ld); if (acc == null) { return null; } - pds = (ProtectionDomain[]) fcontext.get(acc); + pds = JSA.getProtectDomains(acc); if (pds == null) { return null; }