Code Review for jdk9-dev-5

Prepared by:dfuchs on Wed Feb 1 16:12:58 GMT 2017
Workspace:/Users/danielfuchs/workspaces/jdk/jdk9-dev-5
Summary of changes: 568 lines changed: 373 ins; 53 del; 142 mod; 32231 unchg
Patch of changes: jdk9-dev-5.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw common/bin/unshuffle_list.txt

5 lines changed: 5 ins; 0 del; 0 mod; 1494 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/CompileJavaModules.gmk

4 lines changed: 4 ins; 0 del; 0 mod; 653 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/Images.gmk

1 line changed: 1 ins; 0 del; 0 mod; 492 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/common/Modules.gmk

1 line changed: 1 ins; 0 del; 0 mod; 354 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.base/share/classes/module-info.java

2 lines changed: 2 ins; 0 del; 0 mod; 323 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management/share/classes/com/sun/jmx/remote/internal/ClientNotifForwarder.java

3 lines changed: 0 ins; 1 del; 2 mod; 949 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management/share/classes/javax/management/remote/JMXConnectorFactory.java

281 lines changed: 237 ins; 12 del; 32 mod; 530 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management/share/classes/javax/management/remote/JMXConnectorServerFactory.java

54 lines changed: 8 ins; 29 del; 17 mod; 311 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management/share/classes/module-info.java

10 lines changed: 5 ins; 3 del; 2 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.rmi/share/classes/module-info.java

3 lines changed: 0 ins; 1 del; 2 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.se/share/classes/module-info.java

2 lines changed: 1 ins; 1 del; 0 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.jconsole/share/classes/module-info.java

2 lines changed: 0 ins; 1 del; 1 mod; 36 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management.agent/share/classes/module-info.java

2 lines changed: 1 ins; 1 del; 0 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/jdk.management.agent/share/classes/sun/management/jmxremote/ConnectorBootstrap.java

1 line changed: 0 ins; 0 del; 1 mod; 1026 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/MBeanInfo/NotificationInfoTest.java

1 line changed: 0 ins; 0 del; 1 mod; 282 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/MBeanServer/ExceptionTest.java

3 lines changed: 0 ins; 2 del; 1 mod; 369 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/MBeanServer/OldMBeanServerTest.java

1 line changed: 0 ins; 0 del; 1 mod; 1410 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/modelmbean/UnserializableTargetObjectTest.java

1 line changed: 0 ins; 0 del; 1 mod; 159 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/mxbean/GenericArrayTypeTest.java

1 line changed: 0 ins; 0 del; 1 mod; 417 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/mxbean/MXBeanExceptionHandlingTest.java

1 line changed: 0 ins; 0 del; 1 mod; 244 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/mxbean/MXBeanInteropTest1.java

1 line changed: 0 ins; 0 del; 1 mod; 637 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/mxbean/MXBeanInteropTest2.java

1 line changed: 0 ins; 0 del; 1 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/mxbean/MXBeanNotifTest.java

1 line changed: 0 ins; 0 del; 1 mod; 384 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/mxbean/MXBeanTest.java

1 line changed: 0 ins; 0 del; 1 mod; 772 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/mxbean/MXBeanWeirdParamTest.java

1 line changed: 0 ins; 0 del; 1 mod; 276 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/query/SupportedQueryTypesTest.java

1 line changed: 0 ins; 0 del; 1 mod; 470 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connection/AddressableTest.java

1 line changed: 0 ins; 0 del; 1 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connection/BrokenConnectionTest.java

1 line changed: 0 ins; 0 del; 1 mod; 807 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connection/CloseableTest.java

1 line changed: 0 ins; 0 del; 1 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connection/ConnectionListenerNullTest.java

1 line changed: 0 ins; 0 del; 1 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connection/ConnectionTest.java

1 line changed: 0 ins; 0 del; 1 mod; 382 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connection/DaemonRMIExporterTest.java

1 line changed: 0 ins; 0 del; 1 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connection/GetConnectionTest.java

1 line changed: 0 ins; 0 del; 1 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connection/IIOPURLTest.java

1 line changed: 0 ins; 0 del; 1 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connection/IdleTimeoutTest.java

2 lines changed: 1 ins; 0 del; 1 mod; 311 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connection/MultiThreadDeadLockTest.java

1 line changed: 0 ins; 0 del; 1 mod; 274 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connection/ObjectInputStreamWithLoaderNullCheckTest.java

1 line changed: 0 ins; 0 del; 1 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connection/RMIConnectorInternalMapTest.java

1 line changed: 0 ins; 0 del; 1 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connection/RMIConnectorNullSubjectConnTest.java

1 line changed: 0 ins; 0 del; 1 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connection/RMIConnector_NPETest.java

2 lines changed: 0 ins; 1 del; 1 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connection/RMIExitTest.java

1 line changed: 0 ins; 0 del; 1 mod; 145 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connection/RMISerializeTest.java

1 line changed: 0 ins; 0 del; 1 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connectorServer/ConnectorStopDeadlockTest.java

1 line changed: 0 ins; 0 del; 1 mod; 164 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connectorServer/JNDIFailureTest.java

1 line changed: 0 ins; 0 del; 1 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connectorServer/MBSFPreStartPostStartTest.java

1 line changed: 0 ins; 0 del; 1 mod; 233 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connectorServer/RMIExporterTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/connectorServer/SetMBeanServerForwarder.java

2 lines changed: 1 ins; 0 del; 1 mod; 249 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/loading/DeserializeEncodedURLTest.java

1 line changed: 0 ins; 0 del; 1 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/loading/MissingClassTest.java

1 line changed: 0 ins; 0 del; 1 mod; 680 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/loading/RMIDownloadTest.java

1 line changed: 0 ins; 0 del; 1 mod; 254 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/loading/TargetMBeanTest.java

1 line changed: 0 ins; 0 del; 1 mod; 167 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/notif/ConcurrentModificationTest.java

1 line changed: 0 ins; 0 del; 1 mod; 167 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/notif/DeadListenerTest.java

1 line changed: 0 ins; 0 del; 1 mod; 221 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/notif/EmptyDomainNotificationTest.java

1 line changed: 0 ins; 0 del; 1 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/notif/ListenerScaleTest.java

1 line changed: 0 ins; 0 del; 1 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/notif/NotSerializableNotifTest.java

1 line changed: 0 ins; 0 del; 1 mod; 202 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java

1 line changed: 0 ins; 0 del; 1 mod; 177 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/notif/NotificationAccessControllerTest.java

2 lines changed: 1 ins; 0 del; 1 mod; 404 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/notif/NotificationBufferCreationTest.java

1 line changed: 0 ins; 0 del; 1 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/notif/NotificationEmissionTest.java

1 line changed: 0 ins; 0 del; 1 mod; 362 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/notif/RMINotifTest.java

1 line changed: 0 ins; 0 del; 1 mod; 236 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/notif/ServerNotifs.java

1 line changed: 0 ins; 0 del; 1 mod; 171 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/notif/UnexpectedNotifTest.java

1 line changed: 0 ins; 0 del; 1 mod; 239 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/passwordAccessFile/NonJMXPrincipalsTest.java

1 line changed: 0 ins; 0 del; 1 mod; 344 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/passwordAccessFile/PasswordAccessFileTest.java

1 line changed: 0 ins; 0 del; 1 mod; 313 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/passwordAuthenticator/RMIAltAuthTest.java

2 lines changed: 1 ins; 0 del; 1 mod; 195 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/passwordAuthenticator/RMIPasswdAuthTest.java

2 lines changed: 1 ins; 0 del; 1 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/provider/ProviderTest.java

1 line changed: 0 ins; 0 del; 1 mod; 155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/serverError/JMXServerErrorTest.java

2 lines changed: 1 ins; 0 del; 1 mod; 213 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/socketFactories/RMISocketFactoriesTest.java

1 line changed: 0 ins; 0 del; 1 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/subjectDelegation/SubjectDelegation1Test.java

2 lines changed: 1 ins; 0 del; 1 mod; 235 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/subjectDelegation/SubjectDelegation2Test.java

2 lines changed: 1 ins; 0 del; 1 mod; 231 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/subjectDelegation/SubjectDelegation3Test.java

2 lines changed: 1 ins; 0 del; 1 mod; 238 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/remote/mandatory/util/MapNullValuesTest.java

2 lines changed: 1 ins; 0 del; 1 mod; 398 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/security/AuthorizationTest.java

1 line changed: 0 ins; 0 del; 1 mod; 612 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/javax/management/security/SecurityTest.java

1 line changed: 0 ins; 0 del; 1 mod; 799 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/sun/management/jmxremote/bootstrap/TestManager.java

1 line changed: 0 ins; 0 del; 1 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/test/tools/launcher/modules/listmods/ListModsTest.java

1 line changed: 0 ins; 0 del; 1 mod; 202 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/make/rmic/Rmic-java.management.rmi.gmk (was jdk/make/rmic/Rmic-java.management.gmk)

2 lines changed: 0 ins; 0 del; 2 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management.rmi/share/classes/com/sun/jmx/remote/internal/rmi/ProxyRef.java (was jdk/src/java.management/share/classes/com/sun/jmx/remote/internal/ProxyRef.java)

1 line changed: 0 ins; 0 del; 1 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management.rmi/share/classes/com/sun/jmx/remote/internal/rmi/RMIExporter.java (was jdk/src/java.management/share/classes/com/sun/jmx/remote/internal/RMIExporter.java)

1 line changed: 0 ins; 0 del; 1 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management.rmi/share/classes/com/sun/jmx/remote/internal/rmi/Unmarshal.java (was jdk/src/java.management/share/classes/com/sun/jmx/remote/internal/Unmarshal.java)

1 line changed: 0 ins; 0 del; 1 mod; 33 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.management.rmi/share/classes/com/sun/jmx/remote/protocol/rmi/ClientProvider.java (was jdk/src/java.management/share/classes/com/sun/jmx/remote/protocol/rmi/ClientProvider.java)

0 lines changed: 0 ins; 0 del; 0 mod; 48 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.management.rmi/share/classes/com/sun/jmx/remote/protocol/rmi/ServerProvider.java (was jdk/src/java.management/share/classes/com/sun/jmx/remote/protocol/rmi/ServerProvider.java)

0 lines changed: 0 ins; 0 del; 0 mod; 51 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.management.rmi/share/classes/javax/management/remote/rmi/NoCallStackClassLoader.java (was jdk/src/java.management/share/classes/javax/management/remote/rmi/NoCallStackClassLoader.java)

0 lines changed: 0 ins; 0 del; 0 mod; 296 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnection.java (was jdk/src/java.management/share/classes/javax/management/remote/rmi/RMIConnection.java)

0 lines changed: 0 ins; 0 del; 0 mod; 1092 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java (was jdk/src/java.management/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java)

1 line changed: 0 ins; 0 del; 1 mod; 1833 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnector.java (was jdk/src/java.management/share/classes/javax/management/remote/rmi/RMIConnector.java)

35 lines changed: 21 ins; 1 del; 13 mod; 2275 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectorServer.java (was jdk/src/java.management/share/classes/javax/management/remote/rmi/RMIConnectorServer.java)

0 lines changed: 0 ins; 0 del; 0 mod; 819 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIIIOPServerImpl.java (was jdk/src/java.management/share/classes/javax/management/remote/rmi/RMIIIOPServerImpl.java)

0 lines changed: 0 ins; 0 del; 0 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw jdk/src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIJRMPServerImpl.java (was jdk/src/java.management/share/classes/javax/management/remote/rmi/RMIJRMPServerImpl.java)

1 line changed: 0 ins; 0 del; 1 mod; 278 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIServer.java (was jdk/src/java.management/share/classes/javax/management/remote/rmi/RMIServer.java)

0 lines changed: 0 ins; 0 del; 0 mod; 91 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIServerImpl.java (was jdk/src/java.management/share/classes/javax/management/remote/rmi/RMIServerImpl.java)

0 lines changed: 0 ins; 0 del; 0 mod; 550 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.management.rmi/share/classes/javax/management/remote/rmi/package.html (was jdk/src/java.management/share/classes/javax/management/remote/rmi/package.html)

0 lines changed: 0 ins; 0 del; 0 mod; 340 unchg

------ ------ ------ ------ --- New Patch Raw jdk/src/java.management.rmi/share/classes/module-info.java

77 lines changed: 77 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /Users/danielfuchs/bin/webrev (vers 25.12-hg+openjdk.java.net).