Code Review for open

Prepared by:dholmes on Mon May 14 23:08:19 EDT 2018
Workspace:/export/users/dh198349/valhalla/repos/jdk-jep181/open
Compare against: http://hg.openjdk.java.net/jdk/jdk
Summary of changes: 592 lines changed: 511 ins; 10 del; 71 mod; 14810 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java

6 lines changed: 6 ins; 0 del; 0 mod; 3676 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java

58 lines changed: 58 ins; 0 del; 0 mod; 1882 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java

12 lines changed: 9 ins; 0 del; 3 mod; 2277 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Target.java

13 lines changed: 13 ins; 0 del; 0 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java

5 lines changed: 4 ins; 0 del; 1 mod; 395 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdeps/share/classes/com/sun/tools/classfile/Attribute.java

7 lines changed: 6 ins; 0 del; 1 mod; 209 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdeps/share/classes/com/sun/tools/classfile/ClassWriter.java

16 lines changed: 15 ins; 0 del; 1 mod; 973 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jdeps/share/classes/com/sun/tools/javap/AttributeWriter.java

28 lines changed: 27 ins; 0 del; 1 mod; 1017 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/jshell/ClassesTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 348 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/jshell/ForwardReferenceTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 318 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/jshell/GetResourceTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 161 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/lib/annotations/annotations/classfile/ClassfileInspector.java

11 lines changed: 10 ins; 0 del; 1 mod; 1446 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/6917288/GraphicalInstallerTest.java

2 lines changed: 0 ins; 1 del; 1 mod; 104 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/6917288/T6917288.java

9 lines changed: 7 ins; 0 del; 2 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/7199823/InnerClassCannotBeVerified.java

53 lines changed: 30 ins; 3 del; 20 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/MethodParameters/AttributeVisitor.java

3 lines changed: 2 ins; 0 del; 1 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/classfiles/attributes/SourceFile/SyntheticClassTest.java

19 lines changed: 16 ins; 0 del; 3 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/classfiles/attributes/Synthetic/AccessToPrivateInnerClassMembersTest.java

5 lines changed: 0 ins; 2 del; 3 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/classfiles/attributes/Synthetic/AccessToPrivateSiblingsTest.java

7 lines changed: 0 ins; 3 del; 4 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/classfiles/attributes/Synthetic/BridgeMethodsForLambdaTest.java

4 lines changed: 0 ins; 1 del; 3 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/classfiles/attributes/innerclasses/InnerClassesInInnerClassTest.java

20 lines changed: 16 ins; 0 del; 4 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/classfiles/attributes/innerclasses/InnerClassesInInnerEnumTest.java

22 lines changed: 18 ins; 0 del; 4 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/classfiles/attributes/innerclasses/InnerClassesTest.java

20 lines changed: 16 ins; 0 del; 4 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/classfiles/attributes/innerclasses/InnerClassesTestBase.java

6 lines changed: 4 ins; 0 del; 2 mod; 451 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/nativeHeaders/NativeHeaderTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 277 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/tools/javac/processing/model/completionfailure/NoAbortForBadClassFile.java

2 lines changed: 1 ins; 0 del; 1 mod; 252 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jdeps/share/classes/com/sun/tools/classfile/NestHost_attribute.java

63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jdeps/share/classes/com/sun/tools/classfile/NestMembers_attribute.java

70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/tools/javac/nestmates/CheckNestmateAttrs.java

120 lines changed: 120 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /scratch/dh198349/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).