1 /*
   2  * Copyright (c) 1999, 2018, Oracle and/or its affiliates. All rights reserved.
   3  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   4  *
   5  * This code is free software; you can redistribute it and/or modify it
   6  * under the terms of the GNU General Public License version 2 only, as
   7  * published by the Free Software Foundation.
   8  *
   9  * This code is distributed in the hope that it will be useful, but WITHOUT
  10  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
  11  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
  12  * version 2 for more details (a copy is included in the LICENSE file that
  13  * accompanied this code).
  14  *
  15  * You should have received a copy of the GNU General Public License version
  16  * 2 along with this work; if not, write to the Free Software Foundation,
  17  * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
  18  *
  19  * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
  20  * or visit www.oracle.com if you need additional information or have any
  21  * questions.
  22  *
  23  */
  24 
  25 #include "precompiled.hpp"
  26 #include "jvmci/jvmciEnv.hpp"
  27 #include "classfile/javaAssertions.hpp"
  28 #include "classfile/systemDictionary.hpp"
  29 #include "classfile/vmSymbols.hpp"
  30 #include "code/codeCache.hpp"
  31 #include "code/scopeDesc.hpp"
  32 #include "compiler/compileBroker.hpp"
  33 #include "compiler/compileLog.hpp"
  34 #include "compiler/compilerOracle.hpp"
  35 #include "interpreter/linkResolver.hpp"
  36 #include "memory/allocation.inline.hpp"
  37 #include "memory/oopFactory.hpp"
  38 #include "memory/resourceArea.hpp"
  39 #include "memory/universe.hpp"
  40 #include "oops/constantPool.inline.hpp"
  41 #include "oops/cpCache.inline.hpp"
  42 #include "oops/method.inline.hpp"
  43 #include "oops/methodData.hpp"
  44 #include "oops/objArrayKlass.hpp"
  45 #include "oops/oop.inline.hpp"
  46 #include "prims/jvmtiExport.hpp"
  47 #include "runtime/fieldDescriptor.inline.hpp"
  48 #include "runtime/handles.inline.hpp"
  49 #include "runtime/init.hpp"
  50 #include "runtime/reflection.hpp"
  51 #include "runtime/sharedRuntime.hpp"
  52 #include "runtime/sweeper.hpp"
  53 #include "utilities/dtrace.hpp"
  54 #include "jvmci/jvmciRuntime.hpp"
  55 #include "jvmci/jvmciJavaClasses.hpp"
  56 
  57 JVMCIEnv::JVMCIEnv(CompileTask* task, int system_dictionary_modification_counter):
  58   _task(task),
  59   _system_dictionary_modification_counter(system_dictionary_modification_counter),
  60   _failure_reason(NULL),
  61   _retryable(true)
  62 {
  63   // Get Jvmti capabilities under lock to get consistent values.
  64   MutexLocker mu(JvmtiThreadState_lock);
  65   _jvmti_can_hotswap_or_post_breakpoint = JvmtiExport::can_hotswap_or_post_breakpoint();
  66   _jvmti_can_access_local_variables     = JvmtiExport::can_access_local_variables();
  67   _jvmti_can_post_on_exceptions         = JvmtiExport::can_post_on_exceptions();
  68 }
  69 
  70 // ------------------------------------------------------------------
  71 // Note: the logic of this method should mirror the logic of
  72 // constantPoolOopDesc::verify_constant_pool_resolve.
  73 bool JVMCIEnv::check_klass_accessibility(Klass* accessing_klass, Klass* resolved_klass) {
  74   if (accessing_klass->is_objArray_klass()) {
  75     accessing_klass = ObjArrayKlass::cast(accessing_klass)->bottom_klass();
  76   }
  77   if (!accessing_klass->is_instance_klass()) {
  78     return true;
  79   }
  80 
  81   if (resolved_klass->is_objArray_klass()) {
  82     // Find the element klass, if this is an array.
  83     resolved_klass = ObjArrayKlass::cast(resolved_klass)->bottom_klass();
  84   }
  85   if (resolved_klass->is_instance_klass()) {
  86     Reflection::VerifyClassAccessResults result =
  87       Reflection::verify_class_access(accessing_klass, InstanceKlass::cast(resolved_klass), true);
  88     return result == Reflection::ACCESS_OK;
  89   }
  90   return true;
  91 }
  92 
  93 // ------------------------------------------------------------------
  94 Klass* JVMCIEnv::get_klass_by_name_impl(Klass* accessing_klass,
  95                                         const constantPoolHandle& cpool,
  96                                         Symbol* sym,
  97                                         bool require_local) {
  98   JVMCI_EXCEPTION_CONTEXT;
  99 
 100   // Now we need to check the SystemDictionary
 101   if (sym->char_at(0) == 'L' &&
 102     sym->char_at(sym->utf8_length()-1) == ';') {
 103     // This is a name from a signature.  Strip off the trimmings.
 104     // Call recursive to keep scope of strippedsym.
 105     TempNewSymbol strippedsym = SymbolTable::new_symbol(sym->as_utf8()+1,
 106                     sym->utf8_length()-2,
 107                     CHECK_NULL);
 108     return get_klass_by_name_impl(accessing_klass, cpool, strippedsym, require_local);
 109   }
 110 
 111   Handle loader(THREAD, (oop)NULL);
 112   Handle domain(THREAD, (oop)NULL);
 113   if (accessing_klass != NULL) {
 114     loader = Handle(THREAD, accessing_klass->class_loader());
 115     domain = Handle(THREAD, accessing_klass->protection_domain());
 116   }
 117 
 118   Klass* found_klass = NULL;
 119   {
 120     ttyUnlocker ttyul;  // release tty lock to avoid ordering problems
 121     MutexLocker ml(Compile_lock);
 122     if (!require_local) {
 123       found_klass = SystemDictionary::find_constrained_instance_or_array_klass(sym, loader, CHECK_NULL);
 124     } else {
 125       found_klass = SystemDictionary::find_instance_or_array_klass(sym, loader, domain, CHECK_NULL);
 126     }
 127   }
 128 
 129   // If we fail to find an array klass, look again for its element type.
 130   // The element type may be available either locally or via constraints.
 131   // In either case, if we can find the element type in the system dictionary,
 132   // we must build an array type around it.  The CI requires array klasses
 133   // to be loaded if their element klasses are loaded, except when memory
 134   // is exhausted.
 135   if (sym->char_at(0) == '[' &&
 136       (sym->char_at(1) == '[' || sym->char_at(1) == 'L')) {
 137     // We have an unloaded array.
 138     // Build it on the fly if the element class exists.
 139     TempNewSymbol elem_sym = SymbolTable::new_symbol(sym->as_utf8()+1,
 140                                                  sym->utf8_length()-1,
 141                                                  CHECK_NULL);
 142 
 143     // Get element Klass recursively.
 144     Klass* elem_klass =
 145       get_klass_by_name_impl(accessing_klass,
 146                              cpool,
 147                              elem_sym,
 148                              require_local);
 149     if (elem_klass != NULL) {
 150       // Now make an array for it
 151       Klass* arr = elem_klass->array_klass(CHECK_NULL);
 152       return arr;
 153     }
 154   }
 155 
 156   if (found_klass == NULL && !cpool.is_null() && cpool->has_preresolution()) {
 157     // Look inside the constant pool for pre-resolved class entries.
 158     for (int i = cpool->length() - 1; i >= 1; i--) {
 159       if (cpool->tag_at(i).is_klass()) {
 160         Klass*  kls = cpool->resolved_klass_at(i);
 161         if (kls->name() == sym) {
 162           return kls;
 163         }
 164       }
 165     }
 166   }
 167 
 168   return found_klass;
 169 }
 170 
 171 // ------------------------------------------------------------------
 172 Klass* JVMCIEnv::get_klass_by_name(Klass* accessing_klass,
 173                                   Symbol* klass_name,
 174                                   bool require_local) {
 175   ResourceMark rm;
 176   constantPoolHandle cpool;
 177   return get_klass_by_name_impl(accessing_klass,
 178                                 cpool,
 179                                 klass_name,
 180                                 require_local);
 181 }
 182 
 183 // ------------------------------------------------------------------
 184 // Implementation of get_klass_by_index.
 185 Klass* JVMCIEnv::get_klass_by_index_impl(const constantPoolHandle& cpool,
 186                                         int index,
 187                                         bool& is_accessible,
 188                                         Klass* accessor) {
 189   JVMCI_EXCEPTION_CONTEXT;
 190   Klass* klass = ConstantPool::klass_at_if_loaded(cpool, index);
 191   Symbol* klass_name = NULL;
 192   if (klass == NULL) {
 193     klass_name = cpool->klass_name_at(index);
 194   }
 195 
 196   if (klass == NULL) {
 197     // Not found in constant pool.  Use the name to do the lookup.
 198     Klass* k = get_klass_by_name_impl(accessor,
 199                                       cpool,
 200                                       klass_name,
 201                                       false);
 202     // Calculate accessibility the hard way.
 203     if (k == NULL) {
 204       is_accessible = false;
 205     } else if (k->class_loader() != accessor->class_loader() &&
 206                get_klass_by_name_impl(accessor, cpool, k->name(), true) == NULL) {
 207       // Loaded only remotely.  Not linked yet.
 208       is_accessible = false;
 209     } else {
 210       // Linked locally, and we must also check public/private, etc.
 211       is_accessible = check_klass_accessibility(accessor, k);
 212     }
 213     if (!is_accessible) {
 214       return NULL;
 215     }
 216     return k;
 217   }
 218 
 219   // It is known to be accessible, since it was found in the constant pool.
 220   is_accessible = true;
 221   return klass;
 222 }
 223 
 224 // ------------------------------------------------------------------
 225 // Get a klass from the constant pool.
 226 Klass* JVMCIEnv::get_klass_by_index(const constantPoolHandle& cpool,
 227                                     int index,
 228                                     bool& is_accessible,
 229                                     Klass* accessor) {
 230   ResourceMark rm;
 231   return get_klass_by_index_impl(cpool, index, is_accessible, accessor);
 232 }
 233 
 234 // ------------------------------------------------------------------
 235 // Implementation of get_field_by_index.
 236 //
 237 // Implementation note: the results of field lookups are cached
 238 // in the accessor klass.
 239 void JVMCIEnv::get_field_by_index_impl(InstanceKlass* klass, fieldDescriptor& field_desc,
 240                                         int index) {
 241   JVMCI_EXCEPTION_CONTEXT;
 242 
 243   assert(klass->is_linked(), "must be linked before using its constant-pool");
 244 
 245   constantPoolHandle cpool(thread, klass->constants());
 246 
 247   // Get the field's name, signature, and type.
 248   Symbol* name  = cpool->name_ref_at(index);
 249 
 250   int nt_index = cpool->name_and_type_ref_index_at(index);
 251   int sig_index = cpool->signature_ref_index_at(nt_index);
 252   Symbol* signature = cpool->symbol_at(sig_index);
 253 
 254   // Get the field's declared holder.
 255   int holder_index = cpool->klass_ref_index_at(index);
 256   bool holder_is_accessible;
 257   Klass* declared_holder = get_klass_by_index(cpool, holder_index,
 258                                               holder_is_accessible,
 259                                               klass);
 260 
 261   // The declared holder of this field may not have been loaded.
 262   // Bail out with partial field information.
 263   if (!holder_is_accessible) {
 264     return;
 265   }
 266 
 267 
 268   // Perform the field lookup.
 269   Klass*  canonical_holder =
 270     InstanceKlass::cast(declared_holder)->find_field(name, signature, &field_desc);
 271   if (canonical_holder == NULL) {
 272     return;
 273   }
 274 
 275   assert(canonical_holder == field_desc.field_holder(), "just checking");
 276 }
 277 
 278 // ------------------------------------------------------------------
 279 // Get a field by index from a klass's constant pool.
 280 void JVMCIEnv::get_field_by_index(InstanceKlass* accessor, fieldDescriptor& fd, int index) {
 281   ResourceMark rm;
 282   return get_field_by_index_impl(accessor, fd, index);
 283 }
 284 
 285 // ------------------------------------------------------------------
 286 // Perform an appropriate method lookup based on accessor, holder,
 287 // name, signature, and bytecode.
 288 methodHandle JVMCIEnv::lookup_method(InstanceKlass* accessor,
 289                                Klass*         holder,
 290                                Symbol*        name,
 291                                Symbol*        sig,
 292                                Bytecodes::Code bc,
 293                                constantTag   tag) {
 294   // Accessibility checks are performed in JVMCIEnv::get_method_by_index_impl().
 295   assert(check_klass_accessibility(accessor, holder), "holder not accessible");
 296 
 297   methodHandle dest_method;
 298   LinkInfo link_info(holder, name, sig, accessor, LinkInfo::needs_access_check, tag);
 299   switch (bc) {
 300   case Bytecodes::_invokestatic:
 301     dest_method =
 302       LinkResolver::resolve_static_call_or_null(link_info);
 303     break;
 304   case Bytecodes::_invokespecial:
 305     dest_method =
 306       LinkResolver::resolve_special_call_or_null(link_info);
 307     break;
 308   case Bytecodes::_invokeinterface:
 309     dest_method =
 310       LinkResolver::linktime_resolve_interface_method_or_null(link_info);
 311     break;
 312   case Bytecodes::_invokevirtual:
 313     dest_method =
 314       LinkResolver::linktime_resolve_virtual_method_or_null(link_info);
 315     break;
 316   default: ShouldNotReachHere();
 317   }
 318 
 319   return dest_method;
 320 }
 321 
 322 
 323 // ------------------------------------------------------------------
 324 methodHandle JVMCIEnv::get_method_by_index_impl(const constantPoolHandle& cpool,
 325                                           int index, Bytecodes::Code bc,
 326                                           InstanceKlass* accessor) {
 327   if (bc == Bytecodes::_invokedynamic) {
 328     ConstantPoolCacheEntry* cpce = cpool->invokedynamic_cp_cache_entry_at(index);
 329     bool is_resolved = !cpce->is_f1_null();
 330     if (is_resolved) {
 331       // Get the invoker Method* from the constant pool.
 332       // (The appendix argument, if any, will be noted in the method's signature.)
 333       Method* adapter = cpce->f1_as_method();
 334       return methodHandle(adapter);
 335     }
 336 
 337     return NULL;
 338   }
 339 
 340   int holder_index = cpool->klass_ref_index_at(index);
 341   bool holder_is_accessible;
 342   Klass* holder = get_klass_by_index_impl(cpool, holder_index, holder_is_accessible, accessor);
 343 
 344   // Get the method's name and signature.
 345   Symbol* name_sym = cpool->name_ref_at(index);
 346   Symbol* sig_sym  = cpool->signature_ref_at(index);
 347 
 348   if (cpool->has_preresolution()
 349       || ((holder == SystemDictionary::MethodHandle_klass() || holder == SystemDictionary::VarHandle_klass()) &&
 350           MethodHandles::is_signature_polymorphic_name(holder, name_sym))) {
 351     // Short-circuit lookups for JSR 292-related call sites.
 352     // That is, do not rely only on name-based lookups, because they may fail
 353     // if the names are not resolvable in the boot class loader (7056328).
 354     switch (bc) {
 355     case Bytecodes::_invokevirtual:
 356     case Bytecodes::_invokeinterface:
 357     case Bytecodes::_invokespecial:
 358     case Bytecodes::_invokestatic:
 359       {
 360         Method* m = ConstantPool::method_at_if_loaded(cpool, index);
 361         if (m != NULL) {
 362           return m;
 363         }
 364       }
 365       break;
 366     default:
 367       break;
 368     }
 369   }
 370 
 371   if (holder_is_accessible) { // Our declared holder is loaded.
 372     constantTag tag = cpool->tag_ref_at(index);
 373     methodHandle m = lookup_method(accessor, holder, name_sym, sig_sym, bc, tag);
 374     if (!m.is_null()) {
 375       // We found the method.
 376       return m;
 377     }
 378   }
 379 
 380   // Either the declared holder was not loaded, or the method could
 381   // not be found.
 382 
 383   return NULL;
 384 }
 385 
 386 // ------------------------------------------------------------------
 387 InstanceKlass* JVMCIEnv::get_instance_klass_for_declared_method_holder(Klass* method_holder) {
 388   // For the case of <array>.clone(), the method holder can be an ArrayKlass*
 389   // instead of an InstanceKlass*.  For that case simply pretend that the
 390   // declared holder is Object.clone since that's where the call will bottom out.
 391   if (method_holder->is_instance_klass()) {
 392     return InstanceKlass::cast(method_holder);
 393   } else if (method_holder->is_array_klass()) {
 394     return SystemDictionary::Object_klass();
 395   } else {
 396     ShouldNotReachHere();
 397   }
 398   return NULL;
 399 }
 400 
 401 
 402 // ------------------------------------------------------------------
 403 methodHandle JVMCIEnv::get_method_by_index(const constantPoolHandle& cpool,
 404                                      int index, Bytecodes::Code bc,
 405                                      InstanceKlass* accessor) {
 406   ResourceMark rm;
 407   return get_method_by_index_impl(cpool, index, bc, accessor);
 408 }
 409 
 410 // ------------------------------------------------------------------
 411 // Check for changes to the system dictionary during compilation
 412 // class loads, evolution, breakpoints
 413 JVMCIEnv::CodeInstallResult JVMCIEnv::validate_compile_task_dependencies(Dependencies* dependencies, Handle compiled_code,
 414                                                                          JVMCIEnv* env, char** failure_detail) {
 415   // If JVMTI capabilities were enabled during compile, the compilation is invalidated.
 416   if (env != NULL) {
 417     if (!env->_jvmti_can_hotswap_or_post_breakpoint && JvmtiExport::can_hotswap_or_post_breakpoint()) {
 418       *failure_detail = (char*) "Hotswapping or breakpointing was enabled during compilation";
 419       return JVMCIEnv::dependencies_failed;
 420     }
 421   }
 422 
 423   // Dependencies must be checked when the system dictionary changes
 424   // or if we don't know whether it has changed (i.e., env == NULL).
 425   bool counter_changed = env == NULL || env->_system_dictionary_modification_counter != SystemDictionary::number_of_modifications();
 426   CompileTask* task = env == NULL ? NULL : env->task();
 427   Dependencies::DepType result = dependencies->validate_dependencies(task, counter_changed, failure_detail);
 428   if (result == Dependencies::end_marker) {
 429     return JVMCIEnv::ok;
 430   }
 431 
 432   if (!Dependencies::is_klass_type(result) || counter_changed) {
 433     return JVMCIEnv::dependencies_failed;
 434   }
 435   // The dependencies were invalid at the time of installation
 436   // without any intervening modification of the system
 437   // dictionary.  That means they were invalidly constructed.
 438   return JVMCIEnv::dependencies_invalid;
 439 }
 440 
 441 // ------------------------------------------------------------------
 442 JVMCIEnv::CodeInstallResult JVMCIEnv::register_method(
 443                                 const methodHandle& method,
 444                                 nmethod*& nm,
 445                                 int entry_bci,
 446                                 CodeOffsets* offsets,
 447                                 int orig_pc_offset,
 448                                 CodeBuffer* code_buffer,
 449                                 int frame_words,
 450                                 OopMapSet* oop_map_set,
 451                                 ExceptionHandlerTable* handler_table,
 452                                 AbstractCompiler* compiler,
 453                                 DebugInformationRecorder* debug_info,
 454                                 Dependencies* dependencies,
 455                                 JVMCIEnv* env,
 456                                 int compile_id,
 457                                 bool has_unsafe_access,
 458                                 bool has_wide_vector,
 459                                 Handle installed_code,
 460                                 Handle compiled_code,
 461                                 Handle speculation_log) {
 462   JVMCI_EXCEPTION_CONTEXT;
 463   nm = NULL;
 464   int comp_level = CompLevel_full_optimization;
 465   char* failure_detail = NULL;
 466   JVMCIEnv::CodeInstallResult result;
 467   {
 468     // To prevent compile queue updates.
 469     MutexLocker locker(MethodCompileQueue_lock, THREAD);
 470 
 471     // Prevent SystemDictionary::add_to_hierarchy from running
 472     // and invalidating our dependencies until we install this method.
 473     MutexLocker ml(Compile_lock);
 474 
 475     // Encode the dependencies now, so we can check them right away.
 476     dependencies->encode_content_bytes();
 477 
 478     // Record the dependencies for the current compile in the log
 479     if (LogCompilation) {
 480       for (Dependencies::DepStream deps(dependencies); deps.next(); ) {
 481         deps.log_dependency();
 482       }
 483     }
 484 
 485     // Check for {class loads, evolution, breakpoints} during compilation
 486     result = validate_compile_task_dependencies(dependencies, compiled_code, env, &failure_detail);
 487     if (result != JVMCIEnv::ok) {
 488       // While not a true deoptimization, it is a preemptive decompile.
 489       MethodData* mdp = method()->method_data();
 490       if (mdp != NULL) {
 491         mdp->inc_decompile_count();
 492 #ifdef ASSERT
 493         if (mdp->decompile_count() > (uint)PerMethodRecompilationCutoff) {
 494           ResourceMark m;
 495           tty->print_cr("WARN: endless recompilation of %s. Method was set to not compilable.", method()->name_and_sig_as_C_string());
 496         }
 497 #endif
 498       }
 499 
 500       // All buffers in the CodeBuffer are allocated in the CodeCache.
 501       // If the code buffer is created on each compile attempt
 502       // as in C2, then it must be freed.
 503       //code_buffer->free_blob();
 504     } else {
 505       ImplicitExceptionTable implicit_tbl;
 506       nm =  nmethod::new_nmethod(method,
 507                                  compile_id,
 508                                  entry_bci,
 509                                  offsets,
 510                                  orig_pc_offset,
 511                                  debug_info, dependencies, code_buffer,
 512                                  frame_words, oop_map_set,
 513                                  handler_table, &implicit_tbl,
 514                                  compiler, comp_level,
 515                                  JNIHandles::make_weak_global(installed_code),
 516                                  JNIHandles::make_weak_global(speculation_log));
 517 
 518       // Free codeBlobs
 519       //code_buffer->free_blob();
 520       if (nm == NULL) {
 521         // The CodeCache is full.  Print out warning and disable compilation.
 522         {
 523           MutexUnlocker ml(Compile_lock);
 524           MutexUnlocker locker(MethodCompileQueue_lock);
 525           CompileBroker::handle_full_code_cache(CodeCache::get_code_blob_type(comp_level));
 526         }
 527       } else {
 528         nm->set_has_unsafe_access(has_unsafe_access);
 529         nm->set_has_wide_vectors(has_wide_vector);
 530 
 531         // Record successful registration.
 532         // (Put nm into the task handle *before* publishing to the Java heap.)
 533         CompileTask* task = env == NULL ? NULL : env->task();
 534         if (task != NULL) {
 535           task->set_code(nm);
 536         }
 537 
 538         if (installed_code->is_a(HotSpotNmethod::klass()) && HotSpotNmethod::isDefault(installed_code())) {
 539           if (entry_bci == InvocationEntryBci) {
 540             if (TieredCompilation) {
 541               // If there is an old version we're done with it
 542               CompiledMethod* old = method->code();
 543               if (TraceMethodReplacement && old != NULL) {
 544                 ResourceMark rm;
 545                 char *method_name = method->name_and_sig_as_C_string();
 546                 tty->print_cr("Replacing method %s", method_name);
 547               }
 548               if (old != NULL ) {
 549                 old->make_not_entrant();
 550               }
 551             }
 552             if (TraceNMethodInstalls) {
 553               ResourceMark rm;
 554               char *method_name = method->name_and_sig_as_C_string();
 555               ttyLocker ttyl;
 556               tty->print_cr("Installing method (%d) %s [entry point: %p]",
 557                             comp_level,
 558                             method_name, nm->entry_point());
 559             }
 560             // Allow the code to be executed
 561             method->set_code(method, nm);
 562           } else {
 563             if (TraceNMethodInstalls ) {
 564               ResourceMark rm;
 565               char *method_name = method->name_and_sig_as_C_string();
 566               ttyLocker ttyl;
 567               tty->print_cr("Installing osr method (%d) %s @ %d",
 568                             comp_level,
 569                             method_name,
 570                             entry_bci);
 571             }
 572             InstanceKlass::cast(method->method_holder())->add_osr_nmethod(nm);
 573           }
 574         }
 575         nm->make_in_use();
 576       }
 577       result = nm != NULL ? JVMCIEnv::ok :JVMCIEnv::cache_full;
 578     }
 579   }
 580 
 581   // String creation must be done outside lock
 582   if (failure_detail != NULL) {
 583     // A failure to allocate the string is silently ignored.
 584     Handle message = java_lang_String::create_from_str(failure_detail, THREAD);
 585     HotSpotCompiledNmethod::set_installationFailureMessage(compiled_code, message());
 586   }
 587 
 588   // JVMTI -- compiled method notification (must be done outside lock)
 589   if (nm != NULL) {
 590     nm->post_compiled_method_load_event();
 591 
 592     if (env == NULL) {
 593       // This compile didn't come through the CompileBroker so perform the printing here
 594       DirectiveSet* directive = DirectivesStack::getMatchingDirective(method, compiler);
 595       nm->maybe_print_nmethod(directive);
 596       DirectivesStack::release(directive);
 597     }
 598   }
 599 
 600   return result;
 601 }