Code Review for basic-graal

Prepared by:Doug Simon on Fri Apr 11 16:41:57 CEST 2014
Workspace:/home/dsimon/linz/basic-graal
Compare against: ssh://hg.openjdk.java.net/graal/graal
Summary of changes: 2005 lines changed: 1907 ins; 21 del; 77 mod; 10833 unchg
Patch of changes: basic-graal.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.asm.hsail/src/com/oracle/graal/asm/hsail/HSAILAssembler.java

10 lines changed: 7 ins; 0 del; 3 mod; 597 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.compiler.hsail.test.infra/src/com/oracle/graal/compiler/hsail/test/infra/GraalKernelTester.java

5 lines changed: 5 ins; 0 del; 0 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.compiler.hsail/src/com/oracle/graal/compiler/hsail/HSAILLIRGenerator.java

3 lines changed: 2 ins; 0 del; 1 mod; 877 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.hotspot.hsail/src/com/oracle/graal/hotspot/hsail/HSAILHotSpotBackend.java

113 lines changed: 62 ins; 15 del; 36 mod; 872 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.hotspot.hsail/src/com/oracle/graal/hotspot/hsail/HSAILHotSpotBackendFactory.java

7 lines changed: 4 ins; 1 del; 2 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.hotspot.hsail/src/com/oracle/graal/hotspot/hsail/HSAILHotSpotLIRGenerator.java

3 lines changed: 3 ins; 0 del; 0 mod; 310 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.hotspot.hsail/src/com/oracle/graal/hotspot/hsail/HSAILHotSpotLoweringProvider.java

64 lines changed: 52 ins; 2 del; 10 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.hotspot.hsail/src/com/oracle/graal/hotspot/hsail/HSAILHotSpotNodeLIRBuilder.java

60 lines changed: 59 ins; 0 del; 1 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/HotSpotVMConfig.java

7 lines changed: 6 ins; 0 del; 1 mod; 1543 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/replacements/NewObjectSnippets.java

2 lines changed: 0 ins; 0 del; 2 mod; 493 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.hotspot/src/com/oracle/graal/hotspot/stubs/NewInstanceStub.java

1 line changed: 0 ins; 0 del; 1 mod; 264 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.hsail/src/com/oracle/graal/hsail/HSAIL.java

4 lines changed: 2 ins; 0 del; 2 mod; 217 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw graal/com.oracle.graal.lir.hsail/src/com/oracle/graal/lir/hsail/HSAILMove.java

31 lines changed: 31 ins; 0 del; 0 mod; 484 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/gpu/hsail/vm/gpu_hsail.cpp

143 lines changed: 130 ins; 3 del; 10 mod; 428 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/gpu/hsail/vm/gpu_hsail.hpp

9 lines changed: 5 ins; 0 del; 4 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/gpu/hsail/vm/vmStructs_hsail.hpp

5 lines changed: 1 ins; 0 del; 4 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_interface/collectedHeap.hpp

1 line changed: 1 ins; 0 del; 0 mod; 667 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/vmStructs.cpp

1 line changed: 1 ins; 0 del; 0 mod; 3470 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/EscapingNewBase.java

81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/EscapingNewFloatStringTest.java

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/EscapingNewFloatTest.java

40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/EscapingNewIntArrayTest.java

63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/EscapingNewIntegerTest.java

44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/EscapingNewStoreFieldTest.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/EscapingNewStringConcatTest.java

54 lines changed: 54 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/EscapingNewStringInternTest.java

42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/EscapingNewStringLargeRangeTest.java

43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/EscapingNewStringTest.java

44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/EscapingNewVec3ArrayTest.java

64 lines changed: 64 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/EscapingNewVec3Base.java

50 lines changed: 50 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/EscapingNewVec3LargeRangeDisp3Test.java

49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/EscapingNewVec3LargeRangeTest.java

44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/EscapingNewVec3MediumRangeTest.java

44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/EscapingNewVec3Partial2Test.java

49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/EscapingNewVec3PartialTest.java

45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/EscapingNewVec3Test.java

38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.compiler.hsail.test/src/com/oracle/graal/compiler/hsail/test/IntTestBranchTest.java

52 lines changed: 52 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.hotspot.hsail/src/com/oracle/graal/hotspot/hsail/DonorThreadPool.java

74 lines changed: 74 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.hotspot.hsail/src/com/oracle/graal/hotspot/hsail/nodes/AtomicGetAndAddNode.java

83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.hotspot.hsail/src/com/oracle/graal/hotspot/hsail/nodes/LoweredAtomicGetAndAddNode.java

90 lines changed: 90 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.hotspot.hsail/src/com/oracle/graal/hotspot/hsail/replacements/HSAILHotSpotReplacementsUtil.java

73 lines changed: 73 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw graal/com.oracle.graal.hotspot.hsail/src/com/oracle/graal/hotspot/hsail/replacements/HSAILNewObjectSnippets.java

255 lines changed: 255 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/dsimon/Dropbox/bin/webrev.ksh (vers 23.18-hg+jbs).