--- old/src/hotspot/share/gc/g1/g1SATBCardTableModRefBS.inline.hpp 2018-01-09 13:49:19.195913475 +0100 +++ new/src/hotspot/share/gc/g1/g1SATBCardTableModRefBS.inline.hpp 2018-01-09 13:49:18.883913486 +0100 @@ -61,12 +61,17 @@ _byte_map[card_index] = val; } -inline void G1SATBCardTableModRefBS::enqueue_if_weak(DecoratorSet decorators, oop value) { +inline void G1SATBCardTableModRefBS::enqueue_if_weak_or_archive(DecoratorSet decorators, oop value) { assert((decorators & ON_UNKNOWN_OOP_REF) == 0, "Reference strength must be known"); + // Archive roots need to be enqueued since they add subgraphs to the + // Java heap that were not there at the snapshot when marking started. + // Weak and phantom references also need enqueueing for similar reasons. + const bool in_archive_root = (decorators & IN_ARCHIVE_ROOT) != 0; const bool on_strong_oop_ref = (decorators & ON_STRONG_OOP_REF) != 0; const bool peek = (decorators & AS_NO_KEEPALIVE) != 0; + const bool needs_enqueue = in_archive_root || (!peek && !on_strong_oop_ref); - if (!peek && !on_strong_oop_ref && value != NULL) { + if (needs_enqueue && value != NULL) { enqueue(value); } } @@ -76,7 +81,7 @@ inline oop G1SATBCardTableLoggingModRefBS::AccessBarrier:: oop_load_not_in_heap(T* addr) { oop value = ModRef::oop_load_not_in_heap(addr); - enqueue_if_weak(decorators, value); + enqueue_if_weak_or_archive(decorators, value); return value; } @@ -85,7 +90,7 @@ inline oop G1SATBCardTableLoggingModRefBS::AccessBarrier:: oop_load_in_heap(T* addr) { oop value = ModRef::oop_load_in_heap(addr); - enqueue_if_weak(decorators, value); + enqueue_if_weak_or_archive(decorators, value); return value; } @@ -93,7 +98,7 @@ inline oop G1SATBCardTableLoggingModRefBS::AccessBarrier:: oop_load_in_heap_at(oop base, ptrdiff_t offset) { oop value = ModRef::oop_load_in_heap_at(base, offset); - enqueue_if_weak(AccessBarrierSupport::resolve_possibly_unknown_oop_ref_strength(base, offset), value); + enqueue_if_weak_or_archive(AccessBarrierSupport::resolve_possibly_unknown_oop_ref_strength(base, offset), value); return value; }