Code Review for rt

Prepared by:jagraham on Tue Apr 5 16:34:36 PDT 2016
Workspace:/Users/jagraham/Work/JavaFX/fx9/jfx/rt
Summary of changes: 2005 lines changed: 1060 ins; 141 del; 804 mod; 67771 unchg
Patch of changes: rt.patch
Diff from webrev.02 patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/stage/Screen.java

49 lines changed: 31 ins; 5 del; 13 mod; 310 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/stage/Window.java

199 lines changed: 181 ins; 4 del; 14 mod; 1299 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/layout/Region.java

277 lines changed: 192 ins; 0 del; 85 mod; 3329 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw apps/samples/3DViewer/src/main/java/com/javafx/experiments/jfx3dviewer/SubSceneResizer.java

2 lines changed: 0 ins; 0 del; 2 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw apps/samples/Ensemble8/src/app/java/ensemble/control/Popover.java

17 lines changed: 0 ins; 3 del; 14 mod; 466 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/com/sun/javafx/scene/control/ContextMenuContent.java

25 lines changed: 0 ins; 0 del; 25 mod; 1582 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/com/sun/javafx/scene/control/DatePickerContent.java

4 lines changed: 0 ins; 0 del; 4 mod; 792 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/com/sun/javafx/scene/control/EmbeddedTextContextMenuContent.java

7 lines changed: 0 ins; 0 del; 7 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/chart/Chart.java

15 lines changed: 0 ins; 0 del; 15 mod; 498 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/chart/XYChart.java

4 lines changed: 0 ins; 0 del; 4 mod; 1599 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/control/Control.java

2 lines changed: 0 ins; 0 del; 2 mod; 921 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/control/DialogPane.java

4 lines changed: 0 ins; 0 del; 4 mod; 1218 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/control/skin/ColorPalette.java

2 lines changed: 0 ins; 0 del; 2 mod; 687 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/control/skin/NestedTableColumnHeader.java

3 lines changed: 0 ins; 0 del; 3 mod; 664 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/control/skin/ScrollBarSkin.java

6 lines changed: 0 ins; 0 del; 6 mod; 686 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/control/skin/SplitPaneSkin.java

2 lines changed: 0 ins; 0 del; 2 mod; 1198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/control/skin/TableColumnHeader.java

1 line changed: 0 ins; 0 del; 1 mod; 1061 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/control/skin/TableHeaderRow.java

4 lines changed: 0 ins; 0 del; 4 mod; 601 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java

6 lines changed: 0 ins; 0 del; 6 mod; 2942 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/glass/events/WindowEvent.java

3 lines changed: 3 ins; 0 del; 0 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/glass/ui/Application.java

8 lines changed: 3 ins; 0 del; 5 mod; 738 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/glass/ui/Pixels.java

22 lines changed: 13 ins; 0 del; 9 mod; 226 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/glass/ui/Screen.java

148 lines changed: 92 ins; 39 del; 17 mod; 339 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/glass/ui/Window.java

66 lines changed: 46 ins; 3 del; 17 mod; 1557 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/glass/ui/gtk/GtkApplication.java

2 lines changed: 0 ins; 0 del; 2 mod; 343 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/glass/ui/gtk/GtkPixels.java

2 lines changed: 0 ins; 0 del; 2 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/glass/ui/ios/IosApplication.java

2 lines changed: 0 ins; 0 del; 2 mod; 287 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/glass/ui/ios/IosPixels.java

2 lines changed: 0 ins; 0 del; 2 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/glass/ui/lens/LensApplication.java

2 lines changed: 0 ins; 0 del; 2 mod; 1804 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/glass/ui/lens/LensPixels.java

2 lines changed: 0 ins; 0 del; 2 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/glass/ui/mac/MacApplication.java

2 lines changed: 0 ins; 0 del; 2 mod; 331 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/glass/ui/mac/MacPixels.java

2 lines changed: 0 ins; 0 del; 2 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/glass/ui/mac/MacView.java

33 lines changed: 26 ins; 0 del; 7 mod; 164 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/glass/ui/mac/MacWindow.java

32 lines changed: 22 ins; 6 del; 4 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/glass/ui/monocle/MonocleApplication.java

46 lines changed: 1 ins; 29 del; 16 mod; 336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/glass/ui/monocle/MonoclePixels.java

2 lines changed: 0 ins; 0 del; 2 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/glass/ui/win/WinApplication.java

22 lines changed: 6 ins; 8 del; 8 mod; 362 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/glass/ui/win/WinPixels.java

2 lines changed: 0 ins; 0 del; 2 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/glass/ui/win/WinWindow.java

9 lines changed: 0 ins; 9 del; 0 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/embed/EmbeddedSceneInterface.java

1 line changed: 0 ins; 0 del; 1 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/font/PrismFontFactory.java

3 lines changed: 0 ins; 1 del; 2 mod; 1975 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/sg/prism/CacheFilter.java

9 lines changed: 3 ins; 0 del; 6 mod; 824 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/sg/prism/NGCanvas.java

4 lines changed: 1 ins; 1 del; 2 mod; 1692 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/stage/WindowHelper.java

10 lines changed: 8 ins; 0 del; 2 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/stage/WindowPeerListener.java

5 lines changed: 5 ins; 0 del; 0 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/AppletWindow.java

2 lines changed: 1 ins; 0 del; 1 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/ScreenConfigurationAccessor.java

2 lines changed: 0 ins; 0 del; 2 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/TKStage.java

8 lines changed: 5 ins; 0 del; 3 mod; 217 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/TKStageListener.java

8 lines changed: 8 ins; 0 del; 0 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/quantum/EmbeddedScene.java

22 lines changed: 12 ins; 0 del; 10 mod; 350 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/quantum/EmbeddedStage.java

28 lines changed: 24 ins; 0 del; 4 mod; 284 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/quantum/EmbeddedState.java

3 lines changed: 1 ins; 0 del; 2 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/quantum/GlassAppletWindow.java

11 lines changed: 7 ins; 0 del; 4 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/quantum/GlassSceneDnDEventHandler.java

25 lines changed: 15 ins; 0 del; 10 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/quantum/GlassViewEventHandler.java

57 lines changed: 10 ins; 0 del; 47 mod; 1155 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/quantum/GlassWindowEventHandler.java

38 lines changed: 29 ins; 4 del; 5 mod; 164 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/quantum/QuantumToolkit.java

14 lines changed: 8 ins; 0 del; 6 mod; 1574 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/quantum/UploadingPainter.java

18 lines changed: 9 ins; 0 del; 9 mod; 211 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/quantum/ViewPainter.java

18 lines changed: 6 ins; 0 del; 12 mod; 467 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java

93 lines changed: 63 ins; 2 del; 28 mod; 877 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/prism/Graphics.java

3 lines changed: 1 ins; 0 del; 2 mod; 213 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/prism/Presentable.java

2 lines changed: 1 ins; 0 del; 1 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/prism/PresentableState.java

37 lines changed: 18 ins; 0 del; 19 mod; 353 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/prism/d3d/D3DContext.java

7 lines changed: 1 ins; 1 del; 5 mod; 591 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/prism/d3d/D3DResourceFactory.java

1 line changed: 0 ins; 0 del; 1 mod; 527 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/prism/d3d/D3DSwapChain.java

16 lines changed: 9 ins; 0 del; 7 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/prism/es2/ES2Context.java

7 lines changed: 1 ins; 1 del; 5 mod; 537 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/prism/es2/ES2SwapChain.java

17 lines changed: 11 ins; 0 del; 6 mod; 282 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/prism/impl/BaseGraphics.java

12 lines changed: 7 ins; 0 del; 5 mod; 760 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/prism/impl/QueuedPixelSource.java

6 lines changed: 2 ins; 0 del; 4 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/prism/j2d/J2DPresentable.java

8 lines changed: 6 ins; 0 del; 2 mod; 277 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/prism/j2d/J2DPrismGraphics.java

12 lines changed: 7 ins; 0 del; 5 mod; 1779 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/prism/null3d/DummySwapChain.java

7 lines changed: 6 ins; 0 del; 1 mod; 116 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/prism/sw/SWGraphics.java

11 lines changed: 6 ins; 0 del; 5 mod; 953 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/com/sun/prism/sw/SWPresentable.java

9 lines changed: 6 ins; 0 del; 3 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/layout/BorderPane.java

16 lines changed: 0 ins; 0 del; 16 mod; 681 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/layout/FlowPane.java

10 lines changed: 0 ins; 0 del; 10 mod; 955 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/layout/GridPane.java

46 lines changed: 0 ins; 0 del; 46 mod; 2752 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/layout/HBox.java

20 lines changed: 0 ins; 0 del; 20 mod; 733 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/layout/TilePane.java

22 lines changed: 2 ins; 0 del; 20 mod; 1229 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/layout/VBox.java

18 lines changed: 0 ins; 0 del; 18 mod; 653 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/java/javafx/scene/text/TextFlow.java

15 lines changed: 0 ins; 0 del; 15 mod; 608 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/native-font/fontpath.c

8 lines changed: 5 ins; 0 del; 3 mod; 774 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/native-glass/gtk/glass_general.cpp

1 line changed: 0 ins; 0 del; 1 mod; 542 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/native-glass/gtk/glass_screen.cpp

6 lines changed: 5 ins; 0 del; 1 mod; 178 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/native-glass/ios/GlassScreen.m

9 lines changed: 7 ins; 0 del; 2 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/native-glass/lens/LensScreen.c

7 lines changed: 5 ins; 0 del; 2 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/native-glass/mac/GlassApplication.m

1 line changed: 0 ins; 0 del; 1 mod; 1148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/native-glass/mac/GlassRobot.m

1 line changed: 0 ins; 0 del; 1 mod; 500 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/native-glass/mac/GlassScreen.m

9 lines changed: 7 ins; 0 del; 2 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/native-glass/mac/GlassView.h

1 line changed: 0 ins; 0 del; 1 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/native-glass/mac/GlassView.m

6 lines changed: 0 ins; 0 del; 6 mod; 770 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/native-glass/mac/GlassView2D.m

2 lines changed: 0 ins; 0 del; 2 mod; 426 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/native-glass/mac/GlassView3D.m

3 lines changed: 0 ins; 0 del; 3 mod; 905 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/native-glass/mac/GlassWindow.m

1 line changed: 0 ins; 0 del; 1 mod; 1548 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/native-glass/win/GlassApplication.cpp

8 lines changed: 0 ins; 7 del; 1 mod; 576 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/native-glass/win/GlassApplication.h

13 lines changed: 1 ins; 6 del; 6 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/native-glass/win/GlassScreen.cpp

34 lines changed: 12 ins; 0 del; 22 mod; 599 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/main/native-glass/win/GlassWindow.cpp

65 lines changed: 47 ins; 1 del; 17 mod; 1882 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/com/sun/javafx/pgstub/StubStage.java

27 lines changed: 22 ins; 0 del; 5 mod; 413 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/graphics/src/test/java/test/com/sun/javafx/pgstub/StubToolkit.java

2 lines changed: 0 ins; 0 del; 2 mod; 924 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/swing/src/main/java/javafx/embed/swing/JFXPanel.java

10 lines changed: 3 ins; 5 del; 2 mod; 1008 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/swing/src/main/java/javafx/embed/swing/SwingNode.java

65 lines changed: 28 ins; 6 del; 31 mod; 950 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/swt/src/main/java/javafx/embed/swt/FXCanvas.java

2 lines changed: 0 ins; 0 del; 2 mod; 1139 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw modules/web/src/main/java/com/sun/javafx/webkit/prism/PrismGraphicsManager.java

3 lines changed: 1 ins; 0 del; 2 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw tests/system/src/test/java/test/robot/javafx/embed/swing/RT32570Test.java

2 lines changed: 2 ins; 0 del; 0 mod; 111 unchg

This code review page was prepared using /Users/jagraham/Work/bin/webrev.sh (vers 23.10-hg).