Code Review for open

Prepared by:fparain on Thu Feb 15 15:34:32 EST 2018
Workspace:/Users/fparain/WORK/Valhalla/lworld-init/valhalla/open
Compare against: http://hg.openjdk.java.net/valhalla/valhalla
Branch:lworld
Summary of changes: 3144 lines changed: 142 ins; 2604 del; 398 mod; 111907 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/globals_x86.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 217 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/interp_masm_x86.cpp

7 lines changed: 0 ins; 7 del; 0 mod; 2095 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp

3 lines changed: 0 ins; 2 del; 1 mod; 1976 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/templateTable_x86.cpp

145 lines changed: 7 ins; 64 del; 74 mod; 4660 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/bcEscapeAnalyzer.cpp

23 lines changed: 1 ins; 9 del; 13 mod; 1525 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciEnv.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 1303 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciField.cpp

1 line changed: 0 ins; 0 del; 1 mod; 450 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciInstanceKlass.cpp

11 lines changed: 0 ins; 10 del; 1 mod; 821 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciMethodBlocks.cpp

1 line changed: 0 ins; 1 del; 0 mod; 405 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciStreams.cpp

4 lines changed: 0 ins; 2 del; 2 mod; 486 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciType.cpp

1 line changed: 0 ins; 0 del; 1 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/ci/ciTypeFlow.cpp

19 lines changed: 0 ins; 16 del; 3 mod; 3109 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classFileParser.cpp

105 lines changed: 1 ins; 63 del; 41 mod; 6459 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classFileParser.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 567 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/classLoader.cpp

1 line changed: 0 ins; 0 del; 1 mod; 2107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/javaClasses.cpp

4 lines changed: 0 ins; 4 del; 0 mod; 3976 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionary.cpp

34 lines changed: 0 ins; 32 del; 2 mod; 3184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/systemDictionary.hpp

4 lines changed: 0 ins; 4 del; 0 mod; 760 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/verificationType.cpp

5 lines changed: 0 ins; 5 del; 0 mod; 175 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/verificationType.hpp

1 line changed: 0 ins; 0 del; 1 mod; 375 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/verifier.cpp

134 lines changed: 0 ins; 66 del; 68 mod; 3289 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/verifier.hpp

2 lines changed: 0 ins; 2 del; 0 mod; 497 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/vmSymbols.cpp

5 lines changed: 0 ins; 4 del; 1 mod; 1050 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/vmSymbols.hpp

10 lines changed: 0 ins; 9 del; 1 mod; 1636 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/compiler/compileBroker.cpp

6 lines changed: 0 ins; 6 del; 0 mod; 2436 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/compiler/methodLiveness.cpp

10 lines changed: 0 ins; 8 del; 2 mod; 1052 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/include/jvm.h

4 lines changed: 2 ins; 0 del; 2 mod; 1321 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/bytecodeTracer.cpp

6 lines changed: 0 ins; 4 del; 2 mod; 603 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/bytecodes.cpp

9 lines changed: 0 ins; 7 del; 2 mod; 569 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/bytecodes.hpp

9 lines changed: 0 ins; 7 del; 2 mod; 449 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/interpreterRuntime.cpp

62 lines changed: 1 ins; 48 del; 13 mod; 1869 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/interpreterRuntime.hpp

7 lines changed: 0 ins; 5 del; 2 mod; 253 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/linkResolver.cpp

18 lines changed: 0 ins; 16 del; 2 mod; 1775 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/oopMapCache.cpp

5 lines changed: 0 ins; 1 del; 4 mod; 599 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/rewriter.cpp

1 line changed: 0 ins; 0 del; 1 mod; 628 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/templateInterpreter.cpp

8 lines changed: 0 ins; 4 del; 4 mod; 345 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/templateInterpreter.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 201 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/templateInterpreterGenerator.cpp

14 lines changed: 0 ins; 8 del; 6 mod; 481 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/templateInterpreterGenerator.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/templateTable.cpp

23 lines changed: 0 ins; 10 del; 13 mod; 549 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/templateTable.hpp

12 lines changed: 0 ins; 9 del; 3 mod; 358 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/arrayKlass.cpp

5 lines changed: 0 ins; 4 del; 1 mod; 278 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/cpCache.cpp

3 lines changed: 2 ins; 0 del; 1 mod; 835 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/cpCache.hpp

8 lines changed: 3 ins; 1 del; 4 mod; 548 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/fieldInfo.hpp

14 lines changed: 13 ins; 0 del; 1 mod; 275 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/generateOopMap.cpp

66 lines changed: 0 ins; 54 del; 12 mod; 2616 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/generateOopMap.hpp

22 lines changed: 0 ins; 21 del; 1 mod; 571 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.cpp

112 lines changed: 1 ins; 106 del; 5 mod; 3883 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.hpp

85 lines changed: 16 ins; 66 del; 3 mod; 1611 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/instanceKlass.inline.hpp

6 lines changed: 0 ins; 6 del; 0 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/klass.cpp

1 line changed: 0 ins; 0 del; 1 mod; 739 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/klassVtable.cpp

5 lines changed: 0 ins; 2 del; 3 mod; 1644 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/methodData.cpp

6 lines changed: 0 ins; 6 del; 0 mod; 1801 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/objArrayKlass.cpp

3 lines changed: 0 ins; 3 del; 0 mod; 452 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/valueKlass.cpp

29 lines changed: 0 ins; 27 del; 2 mod; 616 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/valueKlass.hpp

69 lines changed: 27 ins; 23 del; 19 mod; 229 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/compile.cpp

2 lines changed: 1 ins; 0 del; 1 mod; 4689 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/graphKit.cpp

3 lines changed: 0 ins; 1 del; 2 mod; 4717 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/parse.hpp

5 lines changed: 0 ins; 3 del; 2 mod; 626 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/parse2.cpp

38 lines changed: 1 ins; 12 del; 25 mod; 2430 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/parse3.cpp

81 lines changed: 0 ins; 81 del; 0 mod; 549 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/parseHelper.cpp

4 lines changed: 0 ins; 0 del; 4 mod; 665 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/type.cpp

7 lines changed: 2 ins; 3 del; 2 mod; 5837 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jni.cpp

6 lines changed: 0 ins; 6 del; 0 mod; 4341 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/methodHandles.cpp

12 lines changed: 0 ins; 11 del; 1 mod; 1562 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/fieldDescriptor.hpp

1 line changed: 1 ins; 0 del; 0 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/fieldType.cpp

2 lines changed: 0 ins; 1 del; 1 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/fieldType.hpp

8 lines changed: 0 ins; 8 del; 0 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/globals.hpp

1 line changed: 0 ins; 0 del; 1 mod; 4249 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/reflection.cpp

8 lines changed: 0 ins; 8 del; 0 mod; 1283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/sharedRuntime.cpp

6 lines changed: 0 ins; 2 del; 4 mod; 3510 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/signature.cpp

26 lines changed: 0 ins; 21 del; 5 mod; 540 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/signature.hpp

6 lines changed: 0 ins; 5 del; 1 mod; 476 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/accessFlags.hpp

1 line changed: 1 ins; 0 del; 0 mod; 285 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/globalDefinitions.cpp

8 lines changed: 0 ins; 5 del; 3 mod; 373 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/globalDefinitions.hpp

19 lines changed: 1 ins; 7 del; 11 mod; 1288 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/include/classfile_constants.h.template

1 line changed: 1 ins; 0 del; 0 mod; 584 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/TEST.groups

6 lines changed: 6 ins; 0 del; 0 mod; 262 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/valhalla/valuetypes/Empty.java

3 lines changed: 3 ins; 0 del; 0 mod; 51 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/valhalla/valuetypes/Test8186715.java

4 lines changed: 4 ins; 0 del; 0 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/valhalla/valuetypes/TestInheritedValueTypeFields.java

5 lines changed: 5 ins; 0 del; 0 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/valhalla/valuetypes/UninitializedValueFieldsTest.java

4 lines changed: 4 ins; 0 del; 0 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/valhalla/valuetypes/VDefaultTest.java

8 lines changed: 6 ins; 0 del; 2 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/valhalla/valuetypes/VTBufferTest.java

4 lines changed: 4 ins; 0 del; 0 mod; 338 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/valhalla/valuetypes/VWithFieldTest.java

5 lines changed: 5 ins; 0 del; 0 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueOops.java

5 lines changed: 5 ins; 0 del; 0 mod; 663 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypeArray.java

3 lines changed: 3 ins; 0 del; 0 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypeCreation.java

9 lines changed: 8 ins; 0 del; 1 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypeDensity.java

4 lines changed: 4 ins; 0 del; 0 mod; 238 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueTypeGetField.java

3 lines changed: 3 ins; 0 del; 0 mod; 92 unchg

------ ------ ------ ------ Old --- Patch --- test/hotspot/jtreg/runtime/valhalla/valuetypes/DeriveValueTypeCreation.java

316 lines changed: 0 ins; 316 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/hotspot/jtreg/runtime/valhalla/valuetypes/MVTCombo.java

412 lines changed: 0 ins; 412 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/hotspot/jtreg/runtime/valhalla/valuetypes/MVTComboDebugTier1.java

49 lines changed: 0 ins; 49 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/hotspot/jtreg/runtime/valhalla/valuetypes/MVTComboTier1.java

50 lines changed: 0 ins; 50 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/hotspot/jtreg/runtime/valhalla/valuetypes/ValueOopsMvt.java

734 lines changed: 0 ins; 734 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/hotspot/jtreg/runtime/valhalla/valuetypes/VboxUnbox.java

117 lines changed: 0 ins; 117 del; 0 mod; 0 unchg

This code review page was prepared using /Users/fparain/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).