src/hotspot/share/oops/klassVtable.cpp

rev 50967 : 8206977: Minor improvements of runtime code.

@@ -504,28 +504,24 @@
             Symbol* failed_type_symbol =
               SystemDictionary::check_signature_loaders(signature, target_loader,
                                                         super_loader, true,
                                                         CHECK_(false));
             if (failed_type_symbol != NULL) {
-              const char* msg = "loader constraint violation for class %s: when selecting "
+              ResourceMark rm(THREAD);
+              stringStream ss;
+              ss.print("loader constraint violation for class %s: when selecting "
                 "overriding method %s the class loader %s of the "
                 "selected method's type %s, and the class loader %s for its super "
-                "type %s have different Class objects for the type %s used in the signature";
-              const char* curr_class = klass->external_name();
-              const char* method = target_method()->name_and_sig_as_C_string();
-              const char* loader1 = java_lang_ClassLoader::describe_external(target_loader());
-              const char* sel_class = target_klass->external_name();
-              const char* loader2 = java_lang_ClassLoader::describe_external(super_loader());
-              const char* super_class = super_klass->external_name();
-              const char* failed_type_name = failed_type_symbol->as_klass_external_name();
-              size_t buflen = strlen(msg) + strlen(curr_class) + strlen(method) +
-                strlen(loader1) + strlen(sel_class) + strlen(loader2) +
-                strlen(super_class) + strlen(failed_type_name);
-              char* buf = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, buflen);
-              jio_snprintf(buf, buflen, msg, curr_class, method, loader1, sel_class, loader2,
-                           super_class, failed_type_name);
-              THROW_MSG_(vmSymbols::java_lang_LinkageError(), buf, false);
+                       "type %s have different Class objects for the type %s used in the signature",
+                       klass->external_name(),
+                       target_method()->name_and_sig_as_C_string(),
+                       java_lang_ClassLoader::describe_external(target_loader()),
+                       target_klass->external_name(),
+                       java_lang_ClassLoader::describe_external(super_loader()),
+                       super_klass->external_name(),
+                       failed_type_symbol->as_klass_external_name());
+              THROW_MSG_(vmSymbols::java_lang_LinkageError(), ss.as_string(), false);
             }
           }
         }
 
         put_method_at(target_method(), i);

@@ -1239,29 +1235,25 @@
             SystemDictionary::check_signature_loaders(m->signature(),
                                                       method_holder_loader,
                                                       interface_loader,
                                                       true, CHECK);
           if (failed_type_symbol != NULL) {
-            const char* msg = "loader constraint violation in interface itable"
+            ResourceMark rm(THREAD);
+            stringStream ss;
+            ss.print("loader constraint violation in interface itable"
               " initialization for class %s: when selecting method %s the"
               " class loader %s for super interface %s, and the class"
               " loader %s of the selected method's type, %s have"
-              " different Class objects for the type %s used in the signature";
-            const char* current = _klass->external_name();
-            const char* sig = m->name_and_sig_as_C_string();
-            const char* loader1 = java_lang_ClassLoader::describe_external(interface_loader());
-            const char* iface = InstanceKlass::cast(interf)->external_name();
-            const char* loader2 = java_lang_ClassLoader::describe_external(method_holder_loader());
-            const char* mclass = target()->method_holder()->external_name();
-            const char* failed_type_name = failed_type_symbol->as_klass_external_name();
-            size_t buflen = strlen(msg) + strlen(current) + strlen(sig) +
-              strlen(loader1) + strlen(iface) + strlen(loader2) + strlen(mclass) +
-              strlen(failed_type_name);
-            char* buf = NEW_RESOURCE_ARRAY_IN_THREAD(THREAD, char, buflen);
-            jio_snprintf(buf, buflen, msg, current, sig, loader1, iface,
-                         loader2, mclass, failed_type_name);
-            THROW_MSG(vmSymbols::java_lang_LinkageError(), buf);
+                     " different Class objects for the type %s used in the signature",
+                     _klass->external_name(),
+                     m->name_and_sig_as_C_string(),
+                     java_lang_ClassLoader::describe_external(interface_loader()),
+                     InstanceKlass::cast(interf)->external_name(),
+                     java_lang_ClassLoader::describe_external(method_holder_loader()),
+                     target()->method_holder()->external_name(),
+                     failed_type_symbol->as_klass_external_name());
+            THROW_MSG(vmSymbols::java_lang_LinkageError(), ss.as_string());
           }
         }
       }
 
       // ime may have moved during GC so recalculate address