Code Review for 8218628-exMsg-NPE-jdk

Prepared by:goetz on Tue May 7 15:09:28 CEST 2019
Workspace:
Compare against: http://hg.openjdk.java.net/jdk/jdk
Compare against version:54716
Summary of changes: 2875 lines changed: 2868 ins; 2 del; 5 mod; 14516 unchg
Changeset: 8218628-exMsg-NPE-jdk.changeset
Author comments:

The following file shows example output:

Messages if classfiles contain debug info.
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/hotspot/symbols/symbols-unix 

rev 54717 : 8218626: Add detailed message to NullPointerException describing what is null.
Reviewed-by: coleenp
2 lines changed: 1 ins; 0 del; 1 mod; 192 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/javaClasses.cpp 

rev 54717 : 8218626: Add detailed message to NullPointerException describing what is null.
Reviewed-by: coleenp
27 lines changed: 25 ins; 1 del; 1 mod; 4463 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/javaClasses.hpp 

rev 54717 : 8218626: Add detailed message to NullPointerException describing what is null.
Reviewed-by: coleenp
2 lines changed: 2 ins; 0 del; 0 mod; 1566 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/systemDictionary.hpp 

rev 54717 : 8218626: Add detailed message to NullPointerException describing what is null.
Reviewed-by: coleenp
1 line changed: 1 ins; 0 del; 0 mod; 686 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/vmSymbols.hpp 

rev 54717 : 8218626: Add detailed message to NullPointerException describing what is null.
Reviewed-by: coleenp
1 line changed: 1 ins; 0 del; 0 mod; 1664 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/include/jvm.h 

rev 54717 : 8218626: Add detailed message to NullPointerException describing what is null.
Reviewed-by: coleenp
7 lines changed: 7 ins; 0 del; 0 mod; 1346 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvm.cpp 

rev 54717 : 8218626: Add detailed message to NullPointerException describing what is null.
Reviewed-by: coleenp
26 lines changed: 25 ins; 1 del; 0 mod; 3650 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/lang/NullPointerException.java 

rev 54717 : 8218626: Add detailed message to NullPointerException describing what is null.
Reviewed-by: coleenp
26 lines changed: 25 ins; 0 del; 1 mod; 71 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/vmTestbase/jit/t/t104/t104.gold 

rev 54717 : 8218626: Add detailed message to NullPointerException describing what is null.
Reviewed-by: coleenp
1 line changed: 0 ins; 0 del; 1 mod; 1 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/langtools/jdk/jshell/ToolSimpleTest.java 

rev 54717 : 8218626: Add detailed message to NullPointerException describing what is null.
Reviewed-by: coleenp
1 line changed: 0 ins; 0 del; 1 mod; 877 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/interpreter/bytecodeUtils.cpp 

rev 54717 : 8218626: Add detailed message to NullPointerException describing what is null.
Reviewed-by: coleenp
1379 lines changed: 1379 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/interpreter/bytecodeUtils.hpp 

rev 54717 : 8218626: Add detailed message to NullPointerException describing what is null.
Reviewed-by: coleenp
42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/java.base/share/native/libjava/NullPointerException.c 

rev 54717 : 8218626: Add detailed message to NullPointerException describing what is null.
Reviewed-by: coleenp
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/runtime/exceptionMsgs/NullPointerException/NullPointerExceptionTest.java 

rev 54717 : 8218626: Add detailed message to NullPointerException describing what is null.
Reviewed-by: coleenp
1324 lines changed: 1324 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /usr/work/openjdk/bin/webrev.ksh (vers 25.12-hg+openjdk.java.net).