Prepared by: | goetz on Tue Jun 18 13:55:53 CEST 2019 | ||
---|---|---|---|
Workspace: | |||
Compare against: | http://hg.openjdk.java.net/jdk/jdk | ||
Compare against version: | 55401 | ||
Summary of changes: | 3044 lines changed: 3037 ins; 2 del; 5 mod; 14848 unchg | ||
Changeset: | 8218628-exMsg-NPE-jdk.changeset | ||
Author comments: | This webrev changes the text of the messages slightly. Removed method return type. Removed the word 'method' from "Cannot invoke method". Removed 'static' from printing static fields. Changed 'monitor' to 'synchronized block'. Changed 'write field' to 'assign field'. Messages if classfiles contain debug info.Messages if classfiles contain no debug info. These are the old messages: Messages if classfiles contain debug info.Messages if classfiles contain no debug info. Legend: |
Modified file | Deleted file New file |
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
make/hotspot/symbols/symbols-unix
rev 55402 : 8218626: Add detailed message to NullPointerException describing what is null. Reviewed-by: coleenp2 lines changed: 1 ins; 0 del; 1 mod; 192 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/hotspot/share/classfile/javaClasses.cpp
rev 55402 : 8218626: Add detailed message to NullPointerException describing what is null. Reviewed-by: coleenp27 lines changed: 25 ins; 1 del; 1 mod; 4655 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/hotspot/share/classfile/javaClasses.hpp
rev 55402 : 8218626: Add detailed message to NullPointerException describing what is null. Reviewed-by: coleenp2 lines changed: 2 ins; 0 del; 0 mod; 1654 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/hotspot/share/classfile/systemDictionary.hpp
rev 55402 : 8218626: Add detailed message to NullPointerException describing what is null. Reviewed-by: coleenp1 line changed: 1 ins; 0 del; 0 mod; 694 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/hotspot/share/classfile/vmSymbols.hpp
rev 55402 : 8218626: Add detailed message to NullPointerException describing what is null. Reviewed-by: coleenp1 line changed: 1 ins; 0 del; 0 mod; 1674 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/hotspot/share/include/jvm.h
rev 55402 : 8218626: Add detailed message to NullPointerException describing what is null. Reviewed-by: coleenp7 lines changed: 7 ins; 0 del; 0 mod; 1335 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/hotspot/share/prims/jvm.cpp
rev 55402 : 8218626: Add detailed message to NullPointerException describing what is null. Reviewed-by: coleenp48 lines changed: 47 ins; 1 del; 0 mod; 3668 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
src/java.base/share/classes/java/lang/NullPointerException.java
rev 55402 : 8218626: Add detailed message to NullPointerException describing what is null. Reviewed-by: coleenp26 lines changed: 25 ins; 0 del; 1 mod; 71 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
test/hotspot/jtreg/vmTestbase/jit/t/t104/t104.gold
rev 55402 : 8218626: Add detailed message to NullPointerException describing what is null. Reviewed-by: coleenp1 line changed: 0 ins; 0 del; 1 mod; 1 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
-----
Raw
test/langtools/jdk/jshell/ToolSimpleTest.java
rev 55402 : 8218626: Add detailed message to NullPointerException describing what is null. Reviewed-by: coleenp1 line changed: 0 ins; 0 del; 1 mod; 904 unchg
------ ------ ------
------
------
---
New
-----
Raw
src/hotspot/share/interpreter/bytecodeUtils.cpp
rev 55402 : 8218626: Add detailed message to NullPointerException describing what is null. Reviewed-by: coleenp1385 lines changed: 1385 ins; 0 del; 0 mod; 0 unchg
------ ------ ------
------
------
---
New
-----
Raw
src/hotspot/share/interpreter/bytecodeUtils.hpp
rev 55402 : 8218626: Add detailed message to NullPointerException describing what is null. Reviewed-by: coleenp42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg
------ ------ ------
------
------
---
New
-----
Raw
src/java.base/share/native/libjava/NullPointerException.c
rev 55402 : 8218626: Add detailed message to NullPointerException describing what is null. Reviewed-by: coleenp36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg
------ ------ ------
------
------
---
New
-----
Raw
test/hotspot/jtreg/runtime/exceptionMsgs/NullPointerException/NullPointerExceptionTest.java
rev 55402 : 8218626: Add detailed message to NullPointerException describing what is null. Reviewed-by: coleenp1465 lines changed: 1465 ins; 0 del; 0 mod; 0 unchg
This code review page was prepared using /usr/work/openjdk/bin/webrev.ksh (vers 25.12-hg+openjdk.java.net).