Code Review for 8218628-exMsg-NPE-jdk

Prepared by:goetz on Tue Sep 10 09:41:35 CEST 2019
Workspace:
Compare against: http://hg.openjdk.java.net/jdk/jdk
Compare against version:56221
Summary of changes: 3253 lines changed: 3246 ins; 2 del; 5 mod; 16456 unchg
Changeset: 8218628-exMsg-NPE-jdk.changeset
Author comments:

Only minor edits of the tests wrt. to webrev 15.

No change in message text wrt. webrev 14.

For examples of the messages printed see:

Messages if classfiles contain debug info.
Messages if classfiles contain no debug info.

To enable the feature by default (for testing), this patch is needed: enable_NPE_message.patch

Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw make/hotspot/symbols/symbols-unix 

rev 56222 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
1 line changed: 1 ins; 0 del; 0 mod; 194 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/javaClasses.cpp 

rev 56222 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
63 lines changed: 58 ins; 1 del; 4 mod; 4647 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/javaClasses.hpp 

rev 56222 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
4 lines changed: 3 ins; 0 del; 1 mod; 1653 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/systemDictionary.hpp 

rev 56222 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
1 line changed: 1 ins; 0 del; 0 mod; 677 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/classfile/vmSymbols.hpp 

rev 56222 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
1 line changed: 1 ins; 0 del; 0 mod; 1686 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/include/jvm.h 

rev 56222 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
7 lines changed: 7 ins; 0 del; 0 mod; 1340 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/jvm.cpp 

rev 56222 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
50 lines changed: 49 ins; 1 del; 0 mod; 3686 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/runtime/globals.hpp 

rev 56222 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
4 lines changed: 4 ins; 0 del; 0 mod; 2500 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/java.base/share/classes/java/lang/NullPointerException.java 

rev 56222 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
25 lines changed: 25 ins; 0 del; 0 mod; 73 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/interpreter/bytecodeUtils.cpp 

rev 56222 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
1388 lines changed: 1388 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/hotspot/share/interpreter/bytecodeUtils.hpp 

rev 56222 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
42 lines changed: 42 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw src/java.base/share/native/libjava/NullPointerException.c 

rev 56222 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/runtime/exceptionMsgs/NullPointerException/NPEInHiddenTopFrameTest.java 

rev 56222 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/runtime/exceptionMsgs/NullPointerException/NullPointerExceptionTest.java 

rev 56222 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
1470 lines changed: 1470 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New ----- Raw test/hotspot/jtreg/runtime/exceptionMsgs/NullPointerException/SuppressMessagesTest.java 

rev 56222 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
78 lines changed: 78 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /usr/work/openjdk/bin/webrev.ksh (vers 25.12-hg+openjdk.java.net).