Code Review for 8218628-exMsg-NPE-jdk

Prepared by:goetz on Tue Sep 17 11:07:44 CEST 2019
Workspace:
Compare against: http://hg.openjdk.java.net/jdk/jdk
Compare against version:56281
Summary of changes: 33 lines changed: 12 ins; 11 del; 10 mod; 6775 unchg
Patch of changes: 8218628-exMsg-NPE-jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/bytecodeUtils.cpp 

rev 56281 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
rev 56283 : [mq]: fixes_review_of_16.patch
18 lines changed: 4 ins; 7 del; 7 mod; 1374 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/interpreter/bytecodeUtils.hpp 

rev 56281 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
rev 56283 : [mq]: fixes_review_of_16.patch
1 line changed: 0 ins; 1 del; 0 mod; 41 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/jvm.cpp 

rev 56281 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
rev 56283 : [mq]: fixes_review_of_16.patch
2 lines changed: 1 ins; 1 del; 0 mod; 3734 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/exceptionMsgs/NullPointerException/NPEInHiddenTopFrameTest.java 

rev 56281 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
rev 56283 : [mq]: fixes_review_of_16.patch
5 lines changed: 2 ins; 0 del; 3 mod; 80 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/exceptionMsgs/NullPointerException/NullPointerExceptionTest.java 

rev 56281 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
rev 56283 : [mq]: fixes_review_of_16.patch
4 lines changed: 2 ins; 2 del; 0 mod; 1468 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/runtime/exceptionMsgs/NullPointerException/SuppressMessagesTest.java 

rev 56281 : 8218628: Add detailed message to NullPointerException describing what is null.
Summary: This is the implementation of JEP 358: Helpful NullPointerExceptions.
Reviewed-by: coleenp
rev 56283 : [mq]: fixes_review_of_16.patch
3 lines changed: 3 ins; 0 del; 0 mod; 78 unchg

This code review page was prepared using /usr/work/openjdk/bin/webrev.ksh (vers 25.12-hg+openjdk.java.net).