Code Review for downports-jdk11u-dev

Prepared by:goetz on Tue Jan 28 15:58:03 CET 2020
Workspace:/net/sapmnt.sapjvm_work/d045726/oJ/11/downports-jdk11u-dev
Compare against: http://hg.openjdk.java.net/jdk-updates/jdk11u-dev
Compare against version:52786
Summary of changes: 167 lines changed: 118 ins; 28 del; 21 mod; 2036 unchg
Changeset: downports-jdk11u-dev.changeset
Legend: Modified file
Deleted file
New file
I had to do several adaptions of the change to get the code into 11u. In filemap.cpp jdk13 distinguishes CDS_ARCHIVE_MAGIC and CDS_DYNAMIC_ARCHIVE_MAGIC. Also, 13 checks field _header_size which is not in 11. I simplified this to check only for CDS_ARCHIVE_MAGIC which is known in 11. I removed the checks for _header_size. The test too varies a lot between 11 and 13. Ran it through our testing, and ran the test manually. Both passed.

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/memory/filemap.cpp

rev 52787 : 8226406: JVM fails to detect mismatched or corrupt CDS archive
Summary: Check important archive header fields such as _jvm_ident before processing other fields.
Reviewed-by: iklam, jiangli
81 lines changed: 54 ins; 27 del; 0 mod; 1236 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw src/hotspot/share/prims/cdsoffsets.cpp

rev 52787 : 8226406: JVM fails to detect mismatched or corrupt CDS archive
Summary: Check important archive header fields such as _jvm_ident before processing other fields.
Reviewed-by: iklam, jiangli
1 line changed: 1 ins; 0 del; 0 mod; 76 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/runtime/appcds/SharedArchiveConsistency.java

rev 52787 : 8226406: JVM fails to detect mismatched or corrupt CDS archive
Summary: Check important archive header fields such as _jvm_ident before processing other fields.
Reviewed-by: iklam, jiangli
81 lines changed: 59 ins; 1 del; 21 mod; 359 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New ----- Raw test/hotspot/jtreg/runtime/appcds/TestCommon.java

rev 52787 : 8226406: JVM fails to detect mismatched or corrupt CDS archive
Summary: Check important archive header fields such as _jvm_ident before processing other fields.
Reviewed-by: iklam, jiangli
4 lines changed: 4 ins; 0 del; 0 mod; 365 unchg

This code review page was prepared using /sapmnt/home/d045726/bin/webrev.ksh (vers 25.17-hg+openjdk.java.net).